Re: OOPS at dmar_table_init (2.6.22-rc6-mm1 kernel)
On Tue, 10 Jul 2007 17:57:25 +0400 Pavel Emelianov <[EMAIL PROTECTED]> wrote:
> Hi.
>
> While working with Andrew's kernel I faced an OOPS on x86_64
> machine. Unfortunately kernel logs are not appearing in serial
> console by the time oops happens, but I have some info on the
> screen:
>
> OOPs is at dmar_table_init() here:
> 80532873 :
> 80532873: 41 55 push %r13
> 80532875: 41 54 push %r12
> 80532877: 55 push %rbp
> 80532878: 53 push %rbx
> 80532879: 51 push %rcx
> 8053287a: 4c 8b 2d 07 21 01 00mov73991(%rip),%r13
> # 80544988
> 80532881: 41 0f b6 45 24 movzbl 0x24(%r13),%eax
> <<< OOPS, %r13 = NULL
> 80532886: 84 c0 test %al,%al
> 80532888: 75 11 jne8053289b
>
> 8053288a: 48 c7 c7 b0 3d 45 80mov
> $0x80453db0,%rdi
> 80532891: e8 c2 4a cf ff callq 80227358
>
> 80532896: e9 f2 01 00 00 jmpq 80532a8d
>
>
> Looks like dmar_tbl is NULL.
> BUG is 100% reproducible. Is there any other info that can be useful?
>
This?
From: "Keshavamurthy, Anil S" <[EMAIL PROTECTED]>
Check for dmar_tbl pointer as this can be NULL on systems with no Intel
VT-d support.
Signed-off-by: Anil S Keshavamurthy <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
drivers/pci/dmar.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN
drivers/pci/dmar.c~intel-iommu-dmar-detection-and-parsing-logic-fix-intel-dmar-crash-on-amd-x86_64
drivers/pci/dmar.c
---
a/drivers/pci/dmar.c~intel-iommu-dmar-detection-and-parsing-logic-fix-intel-dmar-crash-on-amd-x86_64
+++ a/drivers/pci/dmar.c
@@ -260,6 +260,8 @@ parse_dmar_table(void)
int ret = 0;
dmar = (struct acpi_table_dmar *)dmar_tbl;
+ if (!dmar)
+ return -ENODEV;
if (!dmar->width) {
printk (KERN_WARNING PREFIX "Zero: Invalid DMAR haw\n");
@@ -301,7 +303,7 @@ int __init dmar_table_init(void)
parse_dmar_table();
if (list_empty(_drhd_units)) {
- printk(KERN_ERR PREFIX "No DMAR devices found\n");
+ printk(KERN_INFO PREFIX "No DMAR devices found\n");
return -ENODEV;
}
return 0;
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: OOPS at dmar_table_init (2.6.22-rc6-mm1 kernel)
(Sorry for the top post) This bug is fixed and the fix should appear in the next MM release. See this link for the patch http://marc.info/?l=linux-kernel=118313130109808=2 -Anil -Original Message- From: Randy Dunlap [mailto:[EMAIL PROTECTED] Sent: Tuesday, July 10, 2007 9:50 AM To: Pavel Emelianov Cc: Raj, Ashok; Li, Shaohua; Keshavamurthy, Anil S; Linux Kernel Mailing List; Andrew Morton Subject: Re: OOPS at dmar_table_init (2.6.22-rc6-mm1 kernel) On Tue, 10 Jul 2007 17:57:25 +0400 Pavel Emelianov wrote: > Hi. > > While working with Andrew's kernel I faced an OOPS on x86_64 > machine. Unfortunately kernel logs are not appearing in serial > console by the time oops happens, but I have some info on the > screen: > > OOPs is at dmar_table_init() here: > 80532873 : > 80532873: 41 55 push %r13 > 80532875: 41 54 push %r12 > 80532877: 55 push %rbp > 80532878: 53 push %rbx > 80532879: 51 push %rcx > 8053287a: 4c 8b 2d 07 21 01 00mov 73991(%rip),%r13# 80544988 > 80532881: 41 0f b6 45 24 movzbl 0x24(%r13),%eax <<<<<<<<<<< OOPS, %r13 = NULL > 80532886: 84 c0 test %al,%al > 80532888: 75 11 jne 8053289b > 8053288a: 48 c7 c7 b0 3d 45 80mov $0x80453db0,%rdi > 80532891: e8 c2 4a cf ff callq 80227358 > 80532896: e9 f2 01 00 00 jmpq 80532a8d > > Looks like dmar_tbl is NULL. > BUG is 100% reproducible. Is there any other info that can be useful? You could test the patch from http://lkml.org/lkml/2007/6/29/174 (see "Get diff 1"). --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: OOPS at dmar_table_init (2.6.22-rc6-mm1 kernel)
On Tue, 10 Jul 2007 17:57:25 +0400 Pavel Emelianov wrote: > Hi. > > While working with Andrew's kernel I faced an OOPS on x86_64 > machine. Unfortunately kernel logs are not appearing in serial > console by the time oops happens, but I have some info on the > screen: > > OOPs is at dmar_table_init() here: > 80532873 : > 80532873: 41 55 push %r13 > 80532875: 41 54 push %r12 > 80532877: 55 push %rbp > 80532878: 53 push %rbx > 80532879: 51 push %rcx > 8053287a: 4c 8b 2d 07 21 01 00mov73991(%rip),%r13 > # 80544988 > 80532881: 41 0f b6 45 24 movzbl 0x24(%r13),%eax > <<< OOPS, %r13 = NULL > 80532886: 84 c0 test %al,%al > 80532888: 75 11 jne8053289b > > 8053288a: 48 c7 c7 b0 3d 45 80mov > $0x80453db0,%rdi > 80532891: e8 c2 4a cf ff callq 80227358 > > 80532896: e9 f2 01 00 00 jmpq 80532a8d > > > Looks like dmar_tbl is NULL. > BUG is 100% reproducible. Is there any other info that can be useful? You could test the patch from http://lkml.org/lkml/2007/6/29/174 (see "Get diff 1"). --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: OOPS at dmar_table_init (2.6.22-rc6-mm1 kernel)
On Tue, 10 Jul 2007 17:57:25 +0400 Pavel Emelianov wrote: Hi. While working with Andrew's kernel I faced an OOPS on x86_64 machine. Unfortunately kernel logs are not appearing in serial console by the time oops happens, but I have some info on the screen: OOPs is at dmar_table_init() here: 80532873 dmar_table_init: 80532873: 41 55 push %r13 80532875: 41 54 push %r12 80532877: 55 push %rbp 80532878: 53 push %rbx 80532879: 51 push %rcx 8053287a: 4c 8b 2d 07 21 01 00mov73991(%rip),%r13 # 80544988 dmar_tbl 80532881: 41 0f b6 45 24 movzbl 0x24(%r13),%eax OOPS, %r13 = NULL 80532886: 84 c0 test %al,%al 80532888: 75 11 jne8053289b dmar_table_init+0x28 8053288a: 48 c7 c7 b0 3d 45 80mov $0x80453db0,%rdi 80532891: e8 c2 4a cf ff callq 80227358 printk 80532896: e9 f2 01 00 00 jmpq 80532a8d dmar_table_init+0x21a Looks like dmar_tbl is NULL. BUG is 100% reproducible. Is there any other info that can be useful? You could test the patch from http://lkml.org/lkml/2007/6/29/174 (see Get diff 1). --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: OOPS at dmar_table_init (2.6.22-rc6-mm1 kernel)
(Sorry for the top post) This bug is fixed and the fix should appear in the next MM release. See this link for the patch http://marc.info/?l=linux-kernelm=118313130109808w=2 -Anil -Original Message- From: Randy Dunlap [mailto:[EMAIL PROTECTED] Sent: Tuesday, July 10, 2007 9:50 AM To: Pavel Emelianov Cc: Raj, Ashok; Li, Shaohua; Keshavamurthy, Anil S; Linux Kernel Mailing List; Andrew Morton Subject: Re: OOPS at dmar_table_init (2.6.22-rc6-mm1 kernel) On Tue, 10 Jul 2007 17:57:25 +0400 Pavel Emelianov wrote: Hi. While working with Andrew's kernel I faced an OOPS on x86_64 machine. Unfortunately kernel logs are not appearing in serial console by the time oops happens, but I have some info on the screen: OOPs is at dmar_table_init() here: 80532873 dmar_table_init: 80532873: 41 55 push %r13 80532875: 41 54 push %r12 80532877: 55 push %rbp 80532878: 53 push %rbx 80532879: 51 push %rcx 8053287a: 4c 8b 2d 07 21 01 00mov 73991(%rip),%r13# 80544988 dmar_tbl 80532881: 41 0f b6 45 24 movzbl 0x24(%r13),%eax OOPS, %r13 = NULL 80532886: 84 c0 test %al,%al 80532888: 75 11 jne 8053289b dmar_table_init+0x28 8053288a: 48 c7 c7 b0 3d 45 80mov $0x80453db0,%rdi 80532891: e8 c2 4a cf ff callq 80227358 printk 80532896: e9 f2 01 00 00 jmpq 80532a8d dmar_table_init+0x21a Looks like dmar_tbl is NULL. BUG is 100% reproducible. Is there any other info that can be useful? You could test the patch from http://lkml.org/lkml/2007/6/29/174 (see Get diff 1). --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: OOPS at dmar_table_init (2.6.22-rc6-mm1 kernel)
On Tue, 10 Jul 2007 17:57:25 +0400 Pavel Emelianov [EMAIL PROTECTED] wrote:
Hi.
While working with Andrew's kernel I faced an OOPS on x86_64
machine. Unfortunately kernel logs are not appearing in serial
console by the time oops happens, but I have some info on the
screen:
OOPs is at dmar_table_init() here:
80532873 dmar_table_init:
80532873: 41 55 push %r13
80532875: 41 54 push %r12
80532877: 55 push %rbp
80532878: 53 push %rbx
80532879: 51 push %rcx
8053287a: 4c 8b 2d 07 21 01 00mov73991(%rip),%r13
# 80544988 dmar_tbl
80532881: 41 0f b6 45 24 movzbl 0x24(%r13),%eax
OOPS, %r13 = NULL
80532886: 84 c0 test %al,%al
80532888: 75 11 jne8053289b
dmar_table_init+0x28
8053288a: 48 c7 c7 b0 3d 45 80mov
$0x80453db0,%rdi
80532891: e8 c2 4a cf ff callq 80227358
printk
80532896: e9 f2 01 00 00 jmpq 80532a8d
dmar_table_init+0x21a
Looks like dmar_tbl is NULL.
BUG is 100% reproducible. Is there any other info that can be useful?
This?
From: Keshavamurthy, Anil S [EMAIL PROTECTED]
Check for dmar_tbl pointer as this can be NULL on systems with no Intel
VT-d support.
Signed-off-by: Anil S Keshavamurthy [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
drivers/pci/dmar.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff -puN
drivers/pci/dmar.c~intel-iommu-dmar-detection-and-parsing-logic-fix-intel-dmar-crash-on-amd-x86_64
drivers/pci/dmar.c
---
a/drivers/pci/dmar.c~intel-iommu-dmar-detection-and-parsing-logic-fix-intel-dmar-crash-on-amd-x86_64
+++ a/drivers/pci/dmar.c
@@ -260,6 +260,8 @@ parse_dmar_table(void)
int ret = 0;
dmar = (struct acpi_table_dmar *)dmar_tbl;
+ if (!dmar)
+ return -ENODEV;
if (!dmar-width) {
printk (KERN_WARNING PREFIX Zero: Invalid DMAR haw\n);
@@ -301,7 +303,7 @@ int __init dmar_table_init(void)
parse_dmar_table();
if (list_empty(dmar_drhd_units)) {
- printk(KERN_ERR PREFIX No DMAR devices found\n);
+ printk(KERN_INFO PREFIX No DMAR devices found\n);
return -ENODEV;
}
return 0;
_
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
