Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi,

On Fri, 5 Mar 2021 08:46:46 +0800 "jay...@rock-chips.com" 
 wrote:
>
> Thanks，and I think i have miss to upstream the changes,
> I have resend them in a new thread.
> 
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -155,9 +155,7 @@ config ARCH_REALTEK
>  config ARCH_ROCKCHIP
> bool "Rockchip Platforms"
> select ARCH_HAS_RESET_CONTROLLER
> -   select GPIOLIB
> select PINCTRL
> -   select PINCTRL_ROCKCHIP
> select PM
> select ROCKCHIP_TIMER
> help
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index b197d23324fb..970c18191f6f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -179,10 +179,14 @@ config PINCTRL_OXNAS
>  
>  config PINCTRL_ROCKCHIP
> tristate "Rockchip gpio and pinctrl driver"
> +   select GPIOLIB
> select PINMUX
> select GENERIC_PINCONF
> select GENERIC_IRQ_CHIP
> select MFD_SYSCON
> +   default ARCH_ROCKCHIP
> +   help
> + This support pinctrl and gpio driver for Rockchip SoCs.
>  
>  config PINCTRL_RZA1
> bool "Renesas RZ/A1 gpio and pinctrl driver"
> 
> 
>  
> From: Linus Walleij
> Date: 2021-03-05 08:43
> To: jay...@rock-chips.com
> CC: Stephen Rothwell; Linux Kernel Mailing List; Linux Next Mailing List
> Subject: Re: Re: linux-next: build failure after merge of the pinctrl tree
> On Fri, Mar 5, 2021 at 1:13 AM jay...@rock-chips.com
>  wrote:
>  
> > Could you show me the issue log ?  
>  
> It's attached to Stephen's original mail in this thread.

Sorry I lost the error message, but it was a reference to a symbol that
has no EXPORT_SYMBOL.  So building the driver as a module should show
the error.

-- 
Cheers,
Stephen Rothwell


pgpWqdu6DORVG.pgp
Description: OpenPGP digital signature

Re: Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, Mar 5, 2021 at 1:13 AM jay...@rock-chips.com
 wrote:

> Could you show me the issue log ?

It's attached to Stephen's original mail in this thread.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

On Thu, 4 Mar 2021 09:16:17 +0100 Linus Walleij  
wrote:
>
> On Thu, Mar 4, 2021 at 2:12 AM Stephen Rothwell  wrote:
> 
> > After merging the pinctrl tree, today's linux-next build (x86_64
> > allmodconfig ) failed like this:
> >
> >
> > Presumably caused by commit
> >
> >   c9e84d46cc03 ("pinctrl: rockchip: make driver be tristate module")
> >
> > I have used the pinctrl tree from next-20210303 for today.  
> 
> Thanks Stephen, I'm taking the patch out again.

Sorry I managed to not put the error message in the mail :-(

-- 
Cheers,
Stephen Rothwell


pgp_d2jNe5plS.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Thu, Mar 4, 2021 at 2:12 AM Stephen Rothwell  wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig ) failed like this:
>
>
> Presumably caused by commit
>
>   c9e84d46cc03 ("pinctrl: rockchip: make driver be tristate module")
>
> I have used the pinctrl tree from next-20210303 for today.

Thanks Stephen, I'm taking the patch out again.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Krzysztof Kozlowski]

On Wed, Jan 27, 2021 at 08:41:26PM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Thanks for the message. This should be fixed already.

Best regards,
Krzysztof

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Wed, Nov 4, 2020 at 4:10 AM Stephen Rothwell  wrote:
> On Fri, 30 Oct 2020 12:50:16 +1100 Stephen Rothwell  
> wrote:
> >
> > Hi all,
> >
> > After merging the pinctrl tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > ERROR: modpost: "irq_gc_set_wake" [drivers/pinctrl/pinctrl-rockchip.ko] 
> > undefined!
> >
> > Caused by commit
> >
> >   6c684f5e79ea ("pinctrl: rockchip: make driver be tristate module")
> >
> > I have reverted that commit for today.
>
> I am still getting this failure.

Sorry for the mess, I dropped this commit now.

I think we need a separate patch to export that call
before we make Rockchip tristate.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi all,

On Fri, 30 Oct 2020 12:50:16 +1100 Stephen Rothwell  
wrote:
>
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> ERROR: modpost: "irq_gc_set_wake" [drivers/pinctrl/pinctrl-rockchip.ko] 
> undefined!
> 
> Caused by commit
> 
>   6c684f5e79ea ("pinctrl: rockchip: make driver be tristate module")
> 
> I have reverted that commit for today.

I am still getting this failure.

-- 
Cheers,
Stephen Rothwell


pgpD4HslUwRMw.pgp
Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, Jul 17, 2020 at 11:01 AM Hanks Chen  wrote:
> On Fri, 2020-07-17 at 17:16 +1000, Stephen Rothwell wrote:

> > Caused by commit
> >
> >   e6f744c6ad4f ("pinctrl: mediatek: add pinctrl support for MT6779 SoC")
> >
> > Forgot to include module.h (since it is tristate in Kconfig) or init.h?
> >
> > I used the pinctrl tree from next-20200716 for today.
> >
>
> My fault, I'll fix it in next version.
> (Series: Add basic SoC Support for Mediatek MT6779 SoC)

OK I pulled out all the MTK6779 patches from my tree and wait
for a new version.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Hanks Chen]

On Fri, 2020-07-17 at 17:16 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: data definition has 
> no type or storage class
>   783 | arch_initcall(mt6779_pinctrl_init);
>   | ^
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: error: type defaults to 
> 'int' in declaration of 'arch_initcall' [-Werror=implicit-int]
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:783:1: warning: parameter names 
> (without types) in function declaration
> drivers/pinctrl/mediatek/pinctrl-mt6779.c:779:19: warning: 
> 'mt6779_pinctrl_init' defined but not used [-Wunused-function]
>   779 | static int __init mt6779_pinctrl_init(void)
>   |   ^~~
> 
> Caused by commit
> 
>   e6f744c6ad4f ("pinctrl: mediatek: add pinctrl support for MT6779 SoC")
> 
> Forgot to include module.h (since it is tristate in Kconfig) or init.h?
> 
> I used the pinctrl tree from next-20200716 for today.
> 

My fault, I'll fix it in next version.
(Series: Add basic SoC Support for Mediatek MT6779 SoC)

Thank you for your message


Hanks Chen

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Wed, Aug 21, 2019 at 8:16 AM Stephen Rothwell  wrote:

> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/pinctrl/pinctrl-st.c: In function 'st_pctl_dt_parse_groups':
> drivers/pinctrl/pinctrl-st.c:1212:15: error: implicit declaration of function 
> 'of_get_named_gpio'; did you mean 'of_get_address'? 
> [-Werror=implicit-function-declaration]
>conf->pin = of_get_named_gpio(pins, pp->name, 0);
>^
>of_get_address
>
> Probably caused by commit
>
>   712dfdaf62b6 ("pinctrl: st: Include the right header")

Yeah my mistake :(

I made a v2 patch fixing the error and took this out.

Thanks,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Dec 6, 2016 at 10:31 PM, Stephen Rothwell  wrote:
> Hi Linus,
>
> On Mon, 5 Dec 2016 10:00:38 +1100 Stephen Rothwell  
> wrote:
>>
>> After merging the pinctrl tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
>> drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member 
>> named 'irq_parent'
>>   return irq_set_irq_wake(gc->irq_parent, state);
>> ^
>> drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void 
>> function [-Wreturn-type]
>>  }
>>  ^
>>
>> Caused by commit
>>
>>   d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
>>
>> I have used the pinctrl tree from next-20161202 for today.
>
> I am still getting this.

Sorry. My intention was of course to put the required pl061 patches on
an immutable branch and pull into pinctrl as well.

Oh well.

FIxing it up now, sorry for the mess.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Dec 6, 2016 at 10:31 PM, Stephen Rothwell  wrote:
> Hi Linus,
>
> On Mon, 5 Dec 2016 10:00:38 +1100 Stephen Rothwell  
> wrote:
>>
>> After merging the pinctrl tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>> drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
>> drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member 
>> named 'irq_parent'
>>   return irq_set_irq_wake(gc->irq_parent, state);
>> ^
>> drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void 
>> function [-Wreturn-type]
>>  }
>>  ^
>>
>> Caused by commit
>>
>>   d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
>>
>> I have used the pinctrl tree from next-20161202 for today.
>
> I am still getting this.

Sorry. My intention was of course to put the required pl061 patches on
an immutable branch and pull into pinctrl as well.

Oh well.

FIxing it up now, sorry for the mess.

Yours,
Linus Walleij

Re: linux-next: build failure after merge of the pinctrl tree

[Peter Rosin]

> Hi Linus,
> 
> On Mon, 5 Dec 2016 10:00:38 +1100 Stephen Rothwell  
> wrote:
>>
>> After merging the pinctrl tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>> 
>> drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
>> drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member 
>> named 'irq_parent'
>>   return irq_set_irq_wake(gc->irq_parent, state);
>> ^
>> drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void 
>> function [-Wreturn-type]
>>  }
>>  ^
>> 
>> Caused by commit
>> 
>>   d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
>> 
>> I have used the pinctrl tree from next-20161202 for today.
> 
> I am still getting this.

The bug you are referring to is in the gpio tree, not pinctrl.
That had me confused for a while, and is the reason I'm writing
this. Maybe the next person need not be confused...

But when I'm writing on this topic anyway, I'll add some more
info, in case anyone cares.

I think fix for this bug is to use gc->irq_chained_parent instead
of gc->irq_parent, at least that changed as part of the indicated
commit. Completely untested...

The fix for the bug in the pinctrl tree is to add a missing >
as posted by Andrew Lunn in [1] (with a slightly broken commit
message; two counts of s/chip-/client-/, an extra line after
the sob and I guess the subject is no longer true).

Cheers,
Peter

[1] http://marc.info/?l=linux-gpio=148088890030876=2

Re: linux-next: build failure after merge of the pinctrl tree

[Peter Rosin]

> Hi Linus,
> 
> On Mon, 5 Dec 2016 10:00:38 +1100 Stephen Rothwell  
> wrote:
>>
>> After merging the pinctrl tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>> 
>> drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
>> drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member 
>> named 'irq_parent'
>>   return irq_set_irq_wake(gc->irq_parent, state);
>> ^
>> drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void 
>> function [-Wreturn-type]
>>  }
>>  ^
>> 
>> Caused by commit
>> 
>>   d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
>> 
>> I have used the pinctrl tree from next-20161202 for today.
> 
> I am still getting this.

The bug you are referring to is in the gpio tree, not pinctrl.
That had me confused for a while, and is the reason I'm writing
this. Maybe the next person need not be confused...

But when I'm writing on this topic anyway, I'll add some more
info, in case anyone cares.

I think fix for this bug is to use gc->irq_chained_parent instead
of gc->irq_parent, at least that changed as part of the indicated
commit. Completely untested...

The fix for the bug in the pinctrl tree is to add a missing >
as posted by Andrew Lunn in [1] (with a slightly broken commit
message; two counts of s/chip-/client-/, an extra line after
the sob and I guess the subject is no longer true).

Cheers,
Peter

[1] http://marc.info/?l=linux-gpio=148088890030876=2

Re: linux-next: build failure after merge of the pinctrl tree

[Peter Rosin]

On 2016-12-06 23:46, Stephen Rothwell wrote:
> Hi Peter,
> 
> On Tue, 6 Dec 2016 23:27:48 +0100 Peter Rosin  wrote:
>>
>> The bug you are referring to is in the gpio tree, not pinctrl.
>> That had me confused for a while, and is the reason I'm writing
>> this. Maybe the next person need not be confused...
> 
> Part of the gpio tree has been merged into the pinctrl tree (see commit
> 70afa835d2d7 ("Merge branch 'thread-irq-simpler' of /home/linus/linux-gpio
> into devel")), but when I merge the gpio tree later in my process, I do
> not get this error.

Right. *blush*

The reason appears that the gpio tree has updates to the pl061 driver
that is not present in pinctrl, specifically
009df9a02000 ("gpio: pl061: use local state for parent IRQ storage")

I guess you could merge gpio first, but you'd still hit the silly bug
in pinctrl that Andrew fixed so maybe that's not worth it...

>> But when I'm writing on this topic anyway, I'll add some more
>> info, in case anyone cares.
>>
>> I think fix for this bug is to use gc->irq_chained_parent instead
>> of gc->irq_parent, at least that changed as part of the indicated
>> commit. Completely untested...
>>
>> The fix for the bug in the pinctrl tree is to add a missing >
>> as posted by Andrew Lunn in [1] (with a slightly broken commit
>> message; two counts of s/chip-/client-/, an extra line after
>> the sob and I guess the subject is no longer true).
>>
>> Cheers,
>> Peter
>>
>> [1] http://marc.info/?l=linux-gpio=148088890030876=2
> 
> Thanks for the info ... this still needs fixing in the pinctrl tree.
> 
> P.S. Peter, your email had a bad header line:
> 
> Reply-To: 20161207083102.093fd...@canb.auug.org.au
> 
> that should probably have been In-Reply-To ...

Right. *blush*

Off to bed I guess. After all, it's a new day tomorrow and I don't seem
very effective at the moment...

Cheers,
Peter

Re: linux-next: build failure after merge of the pinctrl tree

[Peter Rosin]

On 2016-12-06 23:46, Stephen Rothwell wrote:
> Hi Peter,
> 
> On Tue, 6 Dec 2016 23:27:48 +0100 Peter Rosin  wrote:
>>
>> The bug you are referring to is in the gpio tree, not pinctrl.
>> That had me confused for a while, and is the reason I'm writing
>> this. Maybe the next person need not be confused...
> 
> Part of the gpio tree has been merged into the pinctrl tree (see commit
> 70afa835d2d7 ("Merge branch 'thread-irq-simpler' of /home/linus/linux-gpio
> into devel")), but when I merge the gpio tree later in my process, I do
> not get this error.

Right. *blush*

The reason appears that the gpio tree has updates to the pl061 driver
that is not present in pinctrl, specifically
009df9a02000 ("gpio: pl061: use local state for parent IRQ storage")

I guess you could merge gpio first, but you'd still hit the silly bug
in pinctrl that Andrew fixed so maybe that's not worth it...

>> But when I'm writing on this topic anyway, I'll add some more
>> info, in case anyone cares.
>>
>> I think fix for this bug is to use gc->irq_chained_parent instead
>> of gc->irq_parent, at least that changed as part of the indicated
>> commit. Completely untested...
>>
>> The fix for the bug in the pinctrl tree is to add a missing >
>> as posted by Andrew Lunn in [1] (with a slightly broken commit
>> message; two counts of s/chip-/client-/, an extra line after
>> the sob and I guess the subject is no longer true).
>>
>> Cheers,
>> Peter
>>
>> [1] http://marc.info/?l=linux-gpio=148088890030876=2
> 
> Thanks for the info ... this still needs fixing in the pinctrl tree.
> 
> P.S. Peter, your email had a bad header line:
> 
> Reply-To: 20161207083102.093fd...@canb.auug.org.au
> 
> that should probably have been In-Reply-To ...

Right. *blush*

Off to bed I guess. After all, it's a new day tomorrow and I don't seem
very effective at the moment...

Cheers,
Peter

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Peter,

On Tue, 6 Dec 2016 23:27:48 +0100 Peter Rosin  wrote:
>
> The bug you are referring to is in the gpio tree, not pinctrl.
> That had me confused for a while, and is the reason I'm writing
> this. Maybe the next person need not be confused...

Part of the gpio tree has been merged into the pinctrl tree (see commit
70afa835d2d7 ("Merge branch 'thread-irq-simpler' of /home/linus/linux-gpio
into devel")), but when I merge the gpio tree later in my process, I do
not get this error.

> But when I'm writing on this topic anyway, I'll add some more
> info, in case anyone cares.
> 
> I think fix for this bug is to use gc->irq_chained_parent instead
> of gc->irq_parent, at least that changed as part of the indicated
> commit. Completely untested...
> 
> The fix for the bug in the pinctrl tree is to add a missing >
> as posted by Andrew Lunn in [1] (with a slightly broken commit
> message; two counts of s/chip-/client-/, an extra line after
> the sob and I guess the subject is no longer true).
> 
> Cheers,
> Peter
> 
> [1] http://marc.info/?l=linux-gpio=148088890030876=2

Thanks for the info ... this still needs fixing in the pinctrl tree.

P.S. Peter, your email had a bad header line:

Reply-To: 20161207083102.093fd...@canb.auug.org.au

that should probably have been In-Reply-To ...
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Peter,

On Tue, 6 Dec 2016 23:27:48 +0100 Peter Rosin  wrote:
>
> The bug you are referring to is in the gpio tree, not pinctrl.
> That had me confused for a while, and is the reason I'm writing
> this. Maybe the next person need not be confused...

Part of the gpio tree has been merged into the pinctrl tree (see commit
70afa835d2d7 ("Merge branch 'thread-irq-simpler' of /home/linus/linux-gpio
into devel")), but when I merge the gpio tree later in my process, I do
not get this error.

> But when I'm writing on this topic anyway, I'll add some more
> info, in case anyone cares.
> 
> I think fix for this bug is to use gc->irq_chained_parent instead
> of gc->irq_parent, at least that changed as part of the indicated
> commit. Completely untested...
> 
> The fix for the bug in the pinctrl tree is to add a missing >
> as posted by Andrew Lunn in [1] (with a slightly broken commit
> message; two counts of s/chip-/client-/, an extra line after
> the sob and I guess the subject is no longer true).
> 
> Cheers,
> Peter
> 
> [1] http://marc.info/?l=linux-gpio=148088890030876=2

Thanks for the info ... this still needs fixing in the pinctrl tree.

P.S. Peter, your email had a bad header line:

Reply-To: 20161207083102.093fd...@canb.auug.org.au

that should probably have been In-Reply-To ...
-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

On Mon, 5 Dec 2016 10:00:38 +1100 Stephen Rothwell  
wrote:
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
> drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member 
> named 'irq_parent'
>   return irq_set_irq_wake(gc->irq_parent, state);
> ^
> drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void 
> function [-Wreturn-type]
>  }
>  ^
> 
> Caused by commit
> 
>   d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
> 
> I have used the pinctrl tree from next-20161202 for today.

I am still getting this.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

On Mon, 5 Dec 2016 10:00:38 +1100 Stephen Rothwell  
wrote:
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/gpio/gpio-pl061.c: In function 'pl061_irq_set_wake':
> drivers/gpio/gpio-pl061.c:280:28: error: 'struct gpio_chip' has no member 
> named 'irq_parent'
>   return irq_set_irq_wake(gc->irq_parent, state);
> ^
> drivers/gpio/gpio-pl061.c:281:1: warning: control reaches end of non-void 
> function [-Wreturn-type]
>  }
>  ^
> 
> Caused by commit
> 
>   d245b3f9bd36 ("gpio: simplify adding threaded interrupts")
> 
> I have used the pinctrl tree from next-20161202 for today.

I am still getting this.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

Laxman, this must be due to one of the two top commits for tegra:

commit 1d18a3f0f0809f6c71f1f6e9e268ee904ce0b588
"pinctrl: tegra: avoid parked_reg and parked_bank"
commit b22ef2a0979f2b91cfeeabb086e4d665183a93a1
"pinctrl: tegra: Correctly check the supported configuration"

Is it something you can fix quickly or should I just revert both patches
for the time being?

Yours,
Linus Walleij

On Thu, May 12, 2016 at 6:14 AM, Stephen Rothwell  wrote:
> Hi Linus,
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> In file included from include/linux/thread_info.h:11:0,
>  from include/asm-generic/preempt.h:4,
>  from arch/arm/include/generated/asm/preempt.h:1,
>  from include/linux/preempt.h:59,
>  from include/linux/spinlock.h:50,
>  from include/linux/seqlock.h:35,
>  from include/linux/time.h:5,
>  from include/linux/stat.h:18,
>  from include/linux/module.h:10,
>  from drivers/pinctrl/tegra/pinctrl-tegra20.c:20:
> include/linux/bug.h:34:45: error: unknown field 'parked_reg' specified in 
> initializer
>  #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
>  ^
> include/linux/compiler-gcc.h:64:28: note: in expansion of macro 
> 'BUILD_BUG_ON_ZERO'
>  #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
> ^
> include/linux/kernel.h:54:59: note: in expansion of macro '__must_be_array'
>  #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + 
> __must_be_array(arr))
>^
> drivers/pinctrl/tegra/pinctrl-tegra20.c:2027:12: note: in expansion of macro 
> 'ARRAY_SIZE'
>.npins = ARRAY_SIZE(drive_##pg_name##_pins), \
> ^
> drivers/pinctrl/tegra/pinctrl-tegra20.c:2050:2: note: in expansion of macro 
> 'DRV_PG_EXT'
>   DRV_PG_EXT(pg_name, r, 2,  3,  4, 12, 20, 28, 2, 30, 2)
>   ^
> drivers/pinctrl/tegra/pinctrl-tegra20.c:2178:2: note: in expansion of macro 
> 'DRV_PG'
>   DRV_PG(ao1,0x868),
>   ^
>
> and many more.
>
> I cannot figure out what caused it, but using the pinctrl tree from
> next-20160511 makes it build again.
>
> I am using gcc 5.2.0 hosted on powerpcle, if that matters.
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

Laxman, this must be due to one of the two top commits for tegra:

commit 1d18a3f0f0809f6c71f1f6e9e268ee904ce0b588
"pinctrl: tegra: avoid parked_reg and parked_bank"
commit b22ef2a0979f2b91cfeeabb086e4d665183a93a1
"pinctrl: tegra: Correctly check the supported configuration"

Is it something you can fix quickly or should I just revert both patches
for the time being?

Yours,
Linus Walleij

On Thu, May 12, 2016 at 6:14 AM, Stephen Rothwell  wrote:
> Hi Linus,
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> In file included from include/linux/thread_info.h:11:0,
>  from include/asm-generic/preempt.h:4,
>  from arch/arm/include/generated/asm/preempt.h:1,
>  from include/linux/preempt.h:59,
>  from include/linux/spinlock.h:50,
>  from include/linux/seqlock.h:35,
>  from include/linux/time.h:5,
>  from include/linux/stat.h:18,
>  from include/linux/module.h:10,
>  from drivers/pinctrl/tegra/pinctrl-tegra20.c:20:
> include/linux/bug.h:34:45: error: unknown field 'parked_reg' specified in 
> initializer
>  #define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
>  ^
> include/linux/compiler-gcc.h:64:28: note: in expansion of macro 
> 'BUILD_BUG_ON_ZERO'
>  #define __must_be_array(a) BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
> ^
> include/linux/kernel.h:54:59: note: in expansion of macro '__must_be_array'
>  #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + 
> __must_be_array(arr))
>^
> drivers/pinctrl/tegra/pinctrl-tegra20.c:2027:12: note: in expansion of macro 
> 'ARRAY_SIZE'
>.npins = ARRAY_SIZE(drive_##pg_name##_pins), \
> ^
> drivers/pinctrl/tegra/pinctrl-tegra20.c:2050:2: note: in expansion of macro 
> 'DRV_PG_EXT'
>   DRV_PG_EXT(pg_name, r, 2,  3,  4, 12, 20, 28, 2, 30, 2)
>   ^
> drivers/pinctrl/tegra/pinctrl-tegra20.c:2178:2: note: in expansion of macro 
> 'DRV_PG'
>   DRV_PG(ao1,0x868),
>   ^
>
> and many more.
>
> I cannot figure out what caused it, but using the pinctrl tree from
> next-20160511 makes it build again.
>
> I am using gcc 5.2.0 hosted on powerpcle, if that matters.
>
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Mon, Dec 21, 2015 at 5:58 AM, Stephen Rothwell  wrote:

> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:

Argh damned, I pushed a oneliner fix in accordance with Pramod's
report. Sorry about the mess.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Mon, Dec 21, 2015 at 5:58 AM, Stephen Rothwell  wrote:

> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:

Argh damned, I pushed a oneliner fix in accordance with Pramod's
report. Sorry about the mess.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: linux-next: build failure after merge of the pinctrl tree

[Pramod Kumar]

Hi Stephen Rothwell,

This is the same error what we discussed on Friday mail-chain. Please see the 
attachment of my reply.

Regards,
Pramod

> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: 21 December 2015 10:28
> To: Linus Walleij
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Pramod Kumar;
> Ray Jui; Scott Branden
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: 'struct cygnus_gpio'
> declared inside parameter list  static void 
> iproc_gpio_unregister_pinconf(struct
> cygnus_gpio *chip)
>   ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: its scope is only 
> this
> definition or declaration, which is probably not what you want
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function
> 'iproc_gpio_unregister_pinconf':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer 
> to
> incomplete type 'struct cygnus_gpio'
>   pinctrl_unregister(chip->pctl);
>  ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 
> of
> 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-
> Wincompatible-pointer-types]
>   iproc_gpio_unregister_pinconf(chip);
> ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct
> cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
>  static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
>  ^
> 
> Caused by commit
> 
>  afc8c78d179d ("gpio: Rename func/macro/var to IP-block,iproc")
> 
> This does not look like it has even been build tested :-(
> 
> I have used the pinctrl tree from next-20151217 again as the previous
> (fixed) error was hiding this one.
> 
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au

--- Begin Message ---
Hi Stephen/Linus,

The patch " [PATCH v2 5/7] gpio: Rename func/macro/var to IP-block,iproc" 
(https://lkml.org/lkml/2015/11/18/1004) in "for-next" and "devel" of  pinctrl
tree ( http://git.linaro.org/people/linus.walleij/linux-pinctrl.git ) has 
little rebase issue.

Original patch has:

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct iproc_gpio *chip)


while "for-next" and "devel" branch of pinctrl tree has:

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip) 


Please suggest us how could we fix this issue.

Regards,
Pramod

> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: 18 December 2015 09:15
> To: Linus Walleij
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Pramod Kumar;
> Ray Jui; Scott Branden
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function
> 'iproc_gpio_unregister_pinconf':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer 
> to
> incomplete type 'struct cygnus_gpio'
>   pinctrl_unregister(chip->pctl);
>  ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 
> of
> 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-
> Wincompatible-pointer-types]
>   iproc_gpio_unregister_pinconf(chip);
> ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct
> cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
>  static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
>  ^
> 
> Caused by commit
> 
>   616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc")
> 
> I have used the pinctrl tree from next-20151217 for today.
> 
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au

--- End Message ---

RE: linux-next: build failure after merge of the pinctrl tree

[Pramod Kumar]

Hi Stephen Rothwell,

This is the same error what we discussed on Friday mail-chain. Please see the 
attachment of my reply.

Regards,
Pramod

> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: 21 December 2015 10:28
> To: Linus Walleij
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Pramod Kumar;
> Ray Jui; Scott Branden
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: 'struct cygnus_gpio'
> declared inside parameter list  static void 
> iproc_gpio_unregister_pinconf(struct
> cygnus_gpio *chip)
>   ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:50: warning: its scope is only 
> this
> definition or declaration, which is probably not what you want
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function
> 'iproc_gpio_unregister_pinconf':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer 
> to
> incomplete type 'struct cygnus_gpio'
>   pinctrl_unregister(chip->pctl);
>  ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 
> of
> 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-
> Wincompatible-pointer-types]
>   iproc_gpio_unregister_pinconf(chip);
> ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct
> cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
>  static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
>  ^
> 
> Caused by commit
> 
>  afc8c78d179d ("gpio: Rename func/macro/var to IP-block,iproc")
> 
> This does not look like it has even been build tested :-(
> 
> I have used the pinctrl tree from next-20151217 again as the previous
> (fixed) error was hiding this one.
> 
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au

--- Begin Message ---
Hi Stephen/Linus,

The patch " [PATCH v2 5/7] gpio: Rename func/macro/var to IP-block,iproc" 
(https://lkml.org/lkml/2015/11/18/1004) in "for-next" and "devel" of  pinctrl
tree ( http://git.linaro.org/people/linus.walleij/linux-pinctrl.git ) has 
little rebase issue.

Original patch has:

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct iproc_gpio *chip)


while "for-next" and "devel" branch of pinctrl tree has:

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip) 


Please suggest us how could we fix this issue.

Regards,
Pramod

> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: 18 December 2015 09:15
> To: Linus Walleij
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Pramod Kumar;
> Ray Jui; Scott Branden
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function
> 'iproc_gpio_unregister_pinconf':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer 
> to
> incomplete type 'struct cygnus_gpio'
>   pinctrl_unregister(chip->pctl);
>  ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 
> of
> 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-
> Wincompatible-pointer-types]
>   iproc_gpio_unregister_pinconf(chip);
> ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct
> cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
>  static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
>  ^
> 
> Caused by commit
> 
>   616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc")
> 
> I have used the pinctrl tree from next-20151217 for today.
> 
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au

--- End Message ---

Re: linux-next: build failure after merge of the pinctrl tree

[Ray Jui]

Hi All,

Yes I also checked the original patch that Pramod sent out:

@@ -636,13 +638,13 @@ static int cygnus_gpio_register_pinconf(struct 
cygnus_gpio *chip)

return 0;
 }

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct iproc_gpio *chip)
 {
if (chip->pctl)
pinctrl_unregister(chip->pctl);
 }

Somehow it was not merged properly into Linus' tree? The fix is simple 
and just like Pramod proposed.


Linus, how do you want to proceed with this?

Thanks,

Ray


On 12/17/2015 10:12 PM, Pramod Kumar wrote:

Hi Stephen,

The issue I pointed out is the relevant and is fully related to the statement-

" After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:"

Even I tried the build for config "arm multi_v7_defconfig" it was compile 
failed. After fixing this I see compilation successful. I don't think we see any more 
issue after this fix.

Please let me know in case I should try any more compilation.

Regards,
Pramod


-Original Message-
From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
Sent: 18 December 2015 11:28
To: Pramod Kumar
Cc: Linus Walleij; linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Ray
Jui; Scott Branden
Subject: Re: linux-next: build failure after merge of the pinctrl tree

Hi Pramod,

On Fri, 18 Dec 2015 05:34:58 + Pramod Kumar
 wrote:


Hi Stephen/Linus,

Please suggest us how could we fix this issue.


I think you issue is different from what I reported, What I reported was caused
by the addition of the dependency on COMPILE_TEST which allowed the driver
to be built on architectures/platforms that do not have the needed definitions.

--
Cheers,
Stephen Rothwells...@canb.auug.org.au



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Ray Jui]

Hi All,

Yes I also checked the original patch that Pramod sent out:

@@ -636,13 +638,13 @@ static int cygnus_gpio_register_pinconf(struct 
cygnus_gpio *chip)

return 0;
 }

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct iproc_gpio *chip)
 {
if (chip->pctl)
pinctrl_unregister(chip->pctl);
 }

Somehow it was not merged properly into Linus' tree? The fix is simple 
and just like Pramod proposed.


Linus, how do you want to proceed with this?

Thanks,

Ray


On 12/17/2015 10:12 PM, Pramod Kumar wrote:

Hi Stephen,

The issue I pointed out is the relevant and is fully related to the statement-

" After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:"

Even I tried the build for config "arm multi_v7_defconfig" it was compile 
failed. After fixing this I see compilation successful. I don't think we see any more 
issue after this fix.

Please let me know in case I should try any more compilation.

Regards,
Pramod


-Original Message-
From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
Sent: 18 December 2015 11:28
To: Pramod Kumar
Cc: Linus Walleij; linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Ray
Jui; Scott Branden
Subject: Re: linux-next: build failure after merge of the pinctrl tree

Hi Pramod,

On Fri, 18 Dec 2015 05:34:58 + Pramod Kumar
<pramo...@broadcom.com> wrote:


Hi Stephen/Linus,

Please suggest us how could we fix this issue.


I think you issue is different from what I reported, What I reported was caused
by the addition of the dependency on COMPILE_TEST which allowed the driver
to be built on architectures/platforms that do not have the needed definitions.

--
Cheers,
Stephen Rothwells...@canb.auug.org.au



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: linux-next: build failure after merge of the pinctrl tree

[Pramod Kumar]

Hi Stephen,

The issue I pointed out is the relevant and is fully related to the statement-

" After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:"

Even I tried the build for config "arm multi_v7_defconfig" it was compile 
failed. After fixing this I see compilation successful. I don't think we see 
any more issue after this fix.

Please let me know in case I should try any more compilation.

Regards,
Pramod

> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: 18 December 2015 11:28
> To: Pramod Kumar
> Cc: Linus Walleij; linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; 
> Ray
> Jui; Scott Branden
> Subject: Re: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Pramod,
> 
> On Fri, 18 Dec 2015 05:34:58 + Pramod Kumar
>  wrote:
> >
> > Hi Stephen/Linus,
> >
> > Please suggest us how could we fix this issue.
> 
> I think you issue is different from what I reported, What I reported was 
> caused
> by the addition of the dependency on COMPILE_TEST which allowed the driver
> to be built on architectures/platforms that do not have the needed 
> definitions.
> 
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Pramod,

On Fri, 18 Dec 2015 05:34:58 + Pramod Kumar  wrote:
>
> Hi Stephen/Linus,
> 
> Please suggest us how could we fix this issue.

I think you issue is different from what I reported, What I reported
was caused by the addition of the dependency on COMPILE_TEST which
allowed the driver to be built on architectures/platforms that do not
have the needed definitions.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: linux-next: build failure after merge of the pinctrl tree

[Pramod Kumar]

Hi Stephen/Linus,

The patch " [PATCH v2 5/7] gpio: Rename func/macro/var to IP-block,iproc" 
(https://lkml.org/lkml/2015/11/18/1004) in "for-next" and "devel" of  pinctrl
tree ( http://git.linaro.org/people/linus.walleij/linux-pinctrl.git ) has 
little rebase issue.

Original patch has:

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct iproc_gpio *chip)


while "for-next" and "devel" branch of pinctrl tree has:

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip) 


Please suggest us how could we fix this issue.

Regards,
Pramod

> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: 18 December 2015 09:15
> To: Linus Walleij
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Pramod Kumar;
> Ray Jui; Scott Branden
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function
> 'iproc_gpio_unregister_pinconf':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer 
> to
> incomplete type 'struct cygnus_gpio'
>   pinctrl_unregister(chip->pctl);
>  ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 
> of
> 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-
> Wincompatible-pointer-types]
>   iproc_gpio_unregister_pinconf(chip);
> ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct
> cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
>  static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
>  ^
> 
> Caused by commit
> 
>   616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc")
> 
> I have used the pinctrl tree from next-20151217 for today.
> 
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: linux-next: build failure after merge of the pinctrl tree

[Pramod Kumar]

Hi Stephen/Linus,

The patch " [PATCH v2 5/7] gpio: Rename func/macro/var to IP-block,iproc" 
(https://lkml.org/lkml/2015/11/18/1004) in "for-next" and "devel" of  pinctrl
tree ( http://git.linaro.org/people/linus.walleij/linux-pinctrl.git ) has 
little rebase issue.

Original patch has:

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct iproc_gpio *chip)


while "for-next" and "devel" branch of pinctrl tree has:

-static void cygnus_gpio_unregister_pinconf(struct cygnus_gpio *chip)
+static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip) 


Please suggest us how could we fix this issue.

Regards,
Pramod

> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: 18 December 2015 09:15
> To: Linus Walleij
> Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; Pramod Kumar;
> Ray Jui; Scott Branden
> Subject: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Linus,
> 
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function
> 'iproc_gpio_unregister_pinconf':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:642:25: error: dereferencing pointer 
> to
> incomplete type 'struct cygnus_gpio'
>   pinctrl_unregister(chip->pctl);
>  ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c: In function 'iproc_gpio_probe':
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:738:32: warning: passing argument 1 
> of
> 'iproc_gpio_unregister_pinconf' from incompatible pointer type [-
> Wincompatible-pointer-types]
>   iproc_gpio_unregister_pinconf(chip);
> ^
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:640:13: note: expected 'struct
> cygnus_gpio *' but argument is of type 'struct iproc_gpio *'
>  static void iproc_gpio_unregister_pinconf(struct cygnus_gpio *chip)
>  ^
> 
> Caused by commit
> 
>   616043d58a89 ("pinctrl: Rename gpio driver from cygnus to iproc")
> 
> I have used the pinctrl tree from next-20151217 for today.
> 
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: linux-next: build failure after merge of the pinctrl tree

[Pramod Kumar]

Hi Stephen,

The issue I pointed out is the relevant and is fully related to the statement-

" After merging the pinctrl tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:"

Even I tried the build for config "arm multi_v7_defconfig" it was compile 
failed. After fixing this I see compilation successful. I don't think we see 
any more issue after this fix.

Please let me know in case I should try any more compilation.

Regards,
Pramod

> -Original Message-
> From: Stephen Rothwell [mailto:s...@canb.auug.org.au]
> Sent: 18 December 2015 11:28
> To: Pramod Kumar
> Cc: Linus Walleij; linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org; 
> Ray
> Jui; Scott Branden
> Subject: Re: linux-next: build failure after merge of the pinctrl tree
> 
> Hi Pramod,
> 
> On Fri, 18 Dec 2015 05:34:58 + Pramod Kumar
> <pramo...@broadcom.com> wrote:
> >
> > Hi Stephen/Linus,
> >
> > Please suggest us how could we fix this issue.
> 
> I think you issue is different from what I reported, What I reported was 
> caused
> by the addition of the dependency on COMPILE_TEST which allowed the driver
> to be built on architectures/platforms that do not have the needed 
> definitions.
> 
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Pramod,

On Fri, 18 Dec 2015 05:34:58 + Pramod Kumar  wrote:
>
> Hi Stephen/Linus,
> 
> Please suggest us how could we fix this issue.

I think you issue is different from what I reported, What I reported
was caused by the addition of the dependency on COMPILE_TEST which
allowed the driver to be built on architectures/platforms that do not
have the needed definitions.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, Oct 2, 2015 at 5:37 AM, Stephen Rothwell  wrote:

>> Caused by commit
>>
>>   776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")
>>
>> I have used the pinctrl tree from next-20150924 for today.
>
> I am still getting this error.

Sorry for slow fixing, I was travelling.

It should be fixed today.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, Oct 2, 2015 at 5:37 AM, Stephen Rothwell  wrote:

>> Caused by commit
>>
>>   776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")
>>
>> I have used the pinctrl tree from next-20150924 for today.
>
> I am still getting this error.

Sorry for slow fixing, I was travelling.

It should be fixed today.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

On Fri, 25 Sep 2015 13:34:10 +1000 Stephen Rothwell  
wrote:
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_gpio_irq_set_type':
> drivers/pinctrl/pinctrl-at91-pio4.c:170:3: error: implicit declaration of 
> function '__irq_set_handler_locked' [-Werror=implicit-function-declaration]
>__irq_set_handler_locked(d->irq, handle_edge_irq);
>^
> drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe':
> drivers/pinctrl/pinctrl-at91-pio4.c:925:3: warning: passing argument 2 of 
> 'irq_set_chained_handler' from incompatible pointer type
>irq_set_chained_handler(res->start, atmel_gpio_irq_handler);
>^
> In file included from include/linux/gpio/driver.h:6:0,
>  from include/asm-generic/gpio.h:12,
>  from arch/arm/include/asm/gpio.h:9,
>  from include/linux/gpio.h:48,
>  from drivers/pinctrl/pinctrl-at91-pio4.c:18:
> include/linux/irq.h:548:1: note: expected 'irq_flow_handler_t' but argument 
> is of type 'void (*)(unsigned int,  struct irq_desc *)'
>  irq_set_chained_handler(unsigned int irq, irq_flow_handler_t handle)
>  ^
> 
> Caused by commit
> 
>   776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")
> 
> I have used the pinctrl tree from next-20150924 for today.

I am still getting this error.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

On Fri, 25 Sep 2015 13:34:10 +1000 Stephen Rothwell  
wrote:
>
> After merging the pinctrl tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_gpio_irq_set_type':
> drivers/pinctrl/pinctrl-at91-pio4.c:170:3: error: implicit declaration of 
> function '__irq_set_handler_locked' [-Werror=implicit-function-declaration]
>__irq_set_handler_locked(d->irq, handle_edge_irq);
>^
> drivers/pinctrl/pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe':
> drivers/pinctrl/pinctrl-at91-pio4.c:925:3: warning: passing argument 2 of 
> 'irq_set_chained_handler' from incompatible pointer type
>irq_set_chained_handler(res->start, atmel_gpio_irq_handler);
>^
> In file included from include/linux/gpio/driver.h:6:0,
>  from include/asm-generic/gpio.h:12,
>  from arch/arm/include/asm/gpio.h:9,
>  from include/linux/gpio.h:48,
>  from drivers/pinctrl/pinctrl-at91-pio4.c:18:
> include/linux/irq.h:548:1: note: expected 'irq_flow_handler_t' but argument 
> is of type 'void (*)(unsigned int,  struct irq_desc *)'
>  irq_set_chained_handler(unsigned int irq, irq_flow_handler_t handle)
>  ^
> 
> Caused by commit
> 
>   776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller")
> 
> I have used the pinctrl tree from next-20150924 for today.

I am still getting this error.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Mon, Jan 12, 2015 at 6:02 AM, Stephen Rothwell  wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

Fixed already, hopefully. (Atleast the autobuilders are happy.)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Mon, Jan 12, 2015 at 6:02 AM, Stephen Rothwell s...@canb.auug.org.au wrote:

 After merging the pinctrl tree, today's linux-next build (x86_64
 allmodconfig) failed like this:

Fixed already, hopefully. (Atleast the autobuilders are happy.)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, May 30, 2014 at 8:08 AM, Stephen Rothwell  wrote:

> Hi Linus,
>
> After merging the pinctrl tree, today's linux-next build (arm 
> multi_v7_defconfig)
> failed like this:
>
> drivers/pinctrl/sirf/pinctrl-sirf.c: In function 'sirfsoc_gpio_handle_irq':
> drivers/pinctrl/sirf/pinctrl-sirf.c:578:11: error: 'sgpio_chip' undeclared 
> (first use in this function)
>
> Caused by commit 294d1351ff47 ("pinctrl: sirf: switch to using
> allocated state container").

Grr a bad cherry-pick from my side. I've fixed it up today.
Thanks a lot for this Stephen.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Fri, May 30, 2014 at 8:08 AM, Stephen Rothwell s...@canb.auug.org.au wrote:

 Hi Linus,

 After merging the pinctrl tree, today's linux-next build (arm 
 multi_v7_defconfig)
 failed like this:

 drivers/pinctrl/sirf/pinctrl-sirf.c: In function 'sirfsoc_gpio_handle_irq':
 drivers/pinctrl/sirf/pinctrl-sirf.c:578:11: error: 'sgpio_chip' undeclared 
 (first use in this function)

 Caused by commit 294d1351ff47 (pinctrl: sirf: switch to using
 allocated state container).

Grr a bad cherry-pick from my side. I've fixed it up today.
Thanks a lot for this Stephen.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Feb 11, 2014 at 4:56 AM, Stephen Rothwell  wrote:

> drivers/pinctrl/pinctrl-st.c:407:18: error: 'stid127_delays' undeclared here 
> (not in a function)
>
> Caused by commit cab6bf05bab5 ("pinctrl: st: add stid127 support").

Oh darn, I was waiting for an update of that patch but forgot.

I'll rip out that patch immediately, sorry!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Feb 11, 2014 at 4:56 AM, Stephen Rothwell s...@canb.auug.org.au wrote:

 drivers/pinctrl/pinctrl-st.c:407:18: error: 'stid127_delays' undeclared here 
 (not in a function)

 Caused by commit cab6bf05bab5 (pinctrl: st: add stid127 support).

Oh darn, I was waiting for an update of that patch but forgot.

I'll rip out that patch immediately, sorry!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Dec 10, 2013 at 4:02 AM, Stephen Rothwell  wrote:

> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/soc/fsl/eukrea-tlv320.c:28:28: fatal error: asm/mach-types.h: No such 
> file or directory
>  #include 
> ^

It is trying to include an ARM-only file in an x86_64 compile...
I think the Kconfig for that driver needs a

depends on ARM

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Linus Walleij]

On Tue, Dec 10, 2013 at 4:02 AM, Stephen Rothwell s...@canb.auug.org.au wrote:

 After merging the pinctrl tree, today's linux-next build (x86_64
 allmodconfig) failed like this:

 sound/soc/fsl/eukrea-tlv320.c:28:28: fatal error: asm/mach-types.h: No such 
 file or directory
  #include asm/mach-types.h
 ^

It is trying to include an ARM-only file in an x86_64 compile...
I think the Kconfig for that driver needs a

depends on ARM

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

On Tue, 10 Dec 2013 14:02:18 +1100 Stephen Rothwell  
wrote:
>
> After merging the pinctrl tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> sound/soc/fsl/eukrea-tlv320.c:28:28: fatal error: asm/mach-types.h: No such 
> file or directory
>  #include 
> ^
> 
> Probably caused by commit 6bca8471566c ("pinctrl: select dependency on OF
> for MSM driver").  the build of eukrea-tlv320.c depends on CONFIG_OF
> which is not normally set for as x86_64 build, but the above commit
> caused it to be selected (I think).
> 
> I have used the pinctrl tree from next-20131206 again.

It turns out that this is build failure is actually caused by a commit in
the sound-asoc tree (436aa86f0414 "ASoC: eukrea-tlv320: Add DT support"),
but was exposed by the pinctrl tree commit.

So I am not sure if the pinctrl tree needs fixing (I think it did select
CONFIG_OF where it would normally not be).
-- 
Cheers,
Stephen Rothwell 


pgpUZXdGkJkpt.pgp
Description: PGP signature

Re: linux-next: build failure after merge of the pinctrl tree

[Stephen Rothwell]

Hi Linus,

On Tue, 10 Dec 2013 14:02:18 +1100 Stephen Rothwell s...@canb.auug.org.au 
wrote:

 After merging the pinctrl tree, today's linux-next build (x86_64
 allmodconfig) failed like this:
 
 sound/soc/fsl/eukrea-tlv320.c:28:28: fatal error: asm/mach-types.h: No such 
 file or directory
  #include asm/mach-types.h
 ^
 
 Probably caused by commit 6bca8471566c (pinctrl: select dependency on OF
 for MSM driver).  the build of eukrea-tlv320.c depends on CONFIG_OF
 which is not normally set for as x86_64 build, but the above commit
 caused it to be selected (I think).
 
 I have used the pinctrl tree from next-20131206 again.

It turns out that this is build failure is actually caused by a commit in
the sound-asoc tree (436aa86f0414 ASoC: eukrea-tlv320: Add DT support),
but was exposed by the pinctrl tree commit.

So I am not sure if the pinctrl tree needs fixing (I think it did select
CONFIG_OF where it would normally not be).
-- 
Cheers,
Stephen Rothwell s...@canb.auug.org.au


pgpUZXdGkJkpt.pgp
Description: PGP signature