Re: linux-next: build failure after merge of the wireless-next tree
On Tue, Sep 09, 2014 at 04:37:33PM -0700, David Miller wrote: > From: Stephen Rothwell > Date: Wed, 10 Sep 2014 09:28:19 +1000 > > > Hi Dave, > ... > > This fix patch is now needed in the net-next tree ... > > Applied thanks Stephen. Doh! Sorry I missed that one... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Tue, Sep 09, 2014 at 04:37:33PM -0700, David Miller wrote: From: Stephen Rothwell s...@canb.auug.org.au Date: Wed, 10 Sep 2014 09:28:19 +1000 Hi Dave, ... This fix patch is now needed in the net-next tree ... Applied thanks Stephen. Doh! Sorry I missed that one... -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
From: Stephen Rothwell Date: Wed, 10 Sep 2014 09:28:19 +1000 > Hi Dave, ... > This fix patch is now needed in the net-next tree ... Applied thanks Stephen. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
Hi Dave,
On Mon, 8 Sep 2014 18:42:53 +1000 Stephen Rothwell
wrote:
>
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/net/wireless/ath/ath5k/debug.c: In function 'open_file_eeprom':
> drivers/net/wireless/ath/ath5k/debug.c:933:2: error: implicit declaration of
> function 'vmalloc' [-Werror=implicit-function-declaration]
> buf = vmalloc(eesize);
> ^
> drivers/net/wireless/ath/ath5k/debug.c:933:6: warning: assignment makes
> pointer from integer without a cast
> buf = vmalloc(eesize);
> ^
> drivers/net/wireless/ath/ath5k/debug.c:960:2: error: implicit declaration of
> function 'vfree' [-Werror=implicit-function-declaration]
> vfree(buf);
> ^
>
> Caused by commit db906eb2101b ("ath5k: added debugfs file for dumping
> eeprom"). Also reported by Guenter Roeck.
>
> I have used Geert Uytterhoeven's suggested fix of including vmalloc.h
> and so added this patch for today:
>
> From: Stephen Rothwell
> Date: Mon, 8 Sep 2014 18:39:23 +1000
> Subject: [PATCH] ath5k: fix debugfs addition
>
> Reported-by: Guenter Roeck
> Suggested-by: Geert Uytterhoeven
> Signed-off-by: Stephen Rothwell
> ---
> drivers/net/wireless/ath/ath5k/debug.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c
> b/drivers/net/wireless/ath/ath5k/debug.c
> index 30e4e1fd4b04..399728618fb9 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -62,6 +62,7 @@
>
> #include
> #include
> +#include
>
> #include
> #include
> --
> 2.1.0
This fix patch is now needed in the net-next tree ...
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
signature.asc
Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
Hi Dave, On Mon, 8 Sep 2014 18:42:53 +1000 Stephen Rothwell s...@canb.auug.org.au wrote: Hi John, After merging the wireless-next tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/net/wireless/ath/ath5k/debug.c: In function 'open_file_eeprom': drivers/net/wireless/ath/ath5k/debug.c:933:2: error: implicit declaration of function 'vmalloc' [-Werror=implicit-function-declaration] buf = vmalloc(eesize); ^ drivers/net/wireless/ath/ath5k/debug.c:933:6: warning: assignment makes pointer from integer without a cast buf = vmalloc(eesize); ^ drivers/net/wireless/ath/ath5k/debug.c:960:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration] vfree(buf); ^ Caused by commit db906eb2101b (ath5k: added debugfs file for dumping eeprom). Also reported by Guenter Roeck. I have used Geert Uytterhoeven's suggested fix of including vmalloc.h and so added this patch for today: From: Stephen Rothwell s...@canb.auug.org.au Date: Mon, 8 Sep 2014 18:39:23 +1000 Subject: [PATCH] ath5k: fix debugfs addition Reported-by: Guenter Roeck li...@roeck-us.net Suggested-by: Geert Uytterhoeven ge...@linux-m68k.org Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- drivers/net/wireless/ath/ath5k/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c index 30e4e1fd4b04..399728618fb9 100644 --- a/drivers/net/wireless/ath/ath5k/debug.c +++ b/drivers/net/wireless/ath/ath5k/debug.c @@ -62,6 +62,7 @@ #include linux/export.h #include linux/moduleparam.h +#include linux/vmalloc.h #include linux/seq_file.h #include linux/list.h -- 2.1.0 This fix patch is now needed in the net-next tree ... -- Cheers, Stephen Rothwells...@canb.auug.org.au signature.asc Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
From: Stephen Rothwell s...@canb.auug.org.au Date: Wed, 10 Sep 2014 09:28:19 +1000 Hi Dave, ... This fix patch is now needed in the net-next tree ... Applied thanks Stephen. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Wed, Jul 16, 2014 at 01:28:51PM +1000, Stephen Rothwell wrote:
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/staging/rtl8723au/core/rtw_sta_mgt.c: In function
> 'rtw_free_stainfo23a':
> drivers/staging/rtl8723au/core/rtw_sta_mgt.c:254:27: error: expected
> expression before ';' token
> pstapriv->asoc_sta_count-;
>^
>
> Caused by commit 3dd51964026e ("rtl8723au: Corrections in the coding
> style") (its always the cleanup patches that cause problems :-))
> Please unit test *all* patches.
>
> I have used the wireless-next tree from next-20140715 for today.
I'm dropping that one -- merging it was accidental anyway.
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Wed, Jul 16, 2014 at 01:28:51PM +1000, Stephen Rothwell wrote: Hi John, After merging the wireless-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/rtl8723au/core/rtw_sta_mgt.c: In function 'rtw_free_stainfo23a': drivers/staging/rtl8723au/core/rtw_sta_mgt.c:254:27: error: expected expression before ';' token pstapriv-asoc_sta_count-; ^ Caused by commit 3dd51964026e (rtl8723au: Corrections in the coding style) (its always the cleanup patches that cause problems :-)) Please unit test *all* patches. I have used the wireless-next tree from next-20140715 for today. I'm dropping that one -- merging it was accidental anyway. -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: linux-next: build failure after merge of the wireless-next tree
Hi Stephen,
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/net/wireless/mwifiex/pcie.c: In function 'mwifiex_pcie_fw_dump_work':
> drivers/net/wireless/mwifiex/pcie.c:2290:3: error: implicit declaration of
> function 'vmalloc' [-
> Werror=implicit-function-declaration]
>entry->mem_ptr = vmalloc(memory_size + 1);
>^
> drivers/net/wireless/mwifiex/pcie.c:2290:18: warning: assignment makes
> pointer from integer without a
> cast [enabled by default]
>entry->mem_ptr = vmalloc(memory_size + 1);
> ^
> drivers/net/wireless/mwifiex/pcie.c:2361:4: error: implicit declaration of
> function 'vfree' [-
> Werror=implicit-function-declaration]
> vfree(entry->mem_ptr);
> ^
>
> Caused by commit e050c76fcf49 ("mwifiex: add firmware dump feature for
> PCIe").
>
> I have applied this patch for today:
Sorry for the trouble and thanks a lot for the fix.
Regards,
Bing
>
> From: Stephen Rothwell
> Date: Wed, 23 Apr 2014 13:44:59 +1000
> Subject: [PATCH] mwifiex: using vmallog requires including vmalloc.h
>
> Signed-off-by: Stephen Rothwell
> ---
> drivers/net/wireless/mwifiex/pcie.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/mwifiex/pcie.c
> b/drivers/net/wireless/mwifiex/pcie.c
> index 51989b31137a..9c1f42754bbe 100644
> --- a/drivers/net/wireless/mwifiex/pcie.c
> +++ b/drivers/net/wireless/mwifiex/pcie.c
> @@ -17,6 +17,7 @@
> * this warranty disclaimer.
> */
>
> +#include
> #include
>
> #include "decl.h"
> --
> 1.9.2
>
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: linux-next: build failure after merge of the wireless-next tree
Hi Stephen, Hi John, After merging the wireless-next tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/net/wireless/mwifiex/pcie.c: In function 'mwifiex_pcie_fw_dump_work': drivers/net/wireless/mwifiex/pcie.c:2290:3: error: implicit declaration of function 'vmalloc' [- Werror=implicit-function-declaration] entry-mem_ptr = vmalloc(memory_size + 1); ^ drivers/net/wireless/mwifiex/pcie.c:2290:18: warning: assignment makes pointer from integer without a cast [enabled by default] entry-mem_ptr = vmalloc(memory_size + 1); ^ drivers/net/wireless/mwifiex/pcie.c:2361:4: error: implicit declaration of function 'vfree' [- Werror=implicit-function-declaration] vfree(entry-mem_ptr); ^ Caused by commit e050c76fcf49 (mwifiex: add firmware dump feature for PCIe). I have applied this patch for today: Sorry for the trouble and thanks a lot for the fix. Regards, Bing From: Stephen Rothwell s...@canb.auug.org.au Date: Wed, 23 Apr 2014 13:44:59 +1000 Subject: [PATCH] mwifiex: using vmallog requires including vmalloc.h Signed-off-by: Stephen Rothwell s...@canb.auug.org.au --- drivers/net/wireless/mwifiex/pcie.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mwifiex/pcie.c b/drivers/net/wireless/mwifiex/pcie.c index 51989b31137a..9c1f42754bbe 100644 --- a/drivers/net/wireless/mwifiex/pcie.c +++ b/drivers/net/wireless/mwifiex/pcie.c @@ -17,6 +17,7 @@ * this warranty disclaimer. */ +#include linux/vmalloc.h #include linux/firmware.h #include decl.h -- 1.9.2 -- Cheers, Stephen Rothwells...@canb.auug.org.au -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On 03/06/2014 03:43 AM, Stephen Rothwell wrote:
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build
> (arm multi_v7_defconfig) failed like this:
>
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c: In function
> 'brcmf_sdio_intr_rstatus':
> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:2464:3: error:
> implicit declaration of function 'atomic_set_mask'
> [-Werror=implicit-function-declaration]
>
> Caused by commit c98db0bec72a ("brcmfmac: Use atomic functions for
> intstatus update"). Arm does not seem to provide
> atomic_set_mask()?
>
> I reverted that commit for today.
That is fine. The kbuild robot also found issue with this function on
other archs. I must say I am surprised as this code fragment in
asm-generic/atomic.h suggests it is needed for SMP to work (?):
20 #ifdef CONFIG_SMP
21 /* Force people to define core atomics */
22 # if !defined(atomic_add_return) || !defined(atomic_sub_return) || \
23 !defined(atomic_clear_mask) || !defined(atomic_set_mask)
24 # error "SMP requires a little arch-specific magic"
25 # endif
26 #endif
Maybe this requirement is no longer valid. Anyway. I will sent revert
patch and replacement to John.
Thanks,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On 03/06/2014 03:43 AM, Stephen Rothwell wrote: Hi John, After merging the wireless-next tree, today's linux-next build (arm multi_v7_defconfig) failed like this: drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c: In function 'brcmf_sdio_intr_rstatus': drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:2464:3: error: implicit declaration of function 'atomic_set_mask' [-Werror=implicit-function-declaration] Caused by commit c98db0bec72a (brcmfmac: Use atomic functions for intstatus update). Arm does not seem to provide atomic_set_mask()? I reverted that commit for today. That is fine. The kbuild robot also found issue with this function on other archs. I must say I am surprised as this code fragment in asm-generic/atomic.h suggests it is needed for SMP to work (?): 20 #ifdef CONFIG_SMP 21 /* Force people to define core atomics */ 22 # if !defined(atomic_add_return) || !defined(atomic_sub_return) || \ 23 !defined(atomic_clear_mask) || !defined(atomic_set_mask) 24 # error SMP requires a little arch-specific magic 25 # endif 26 #endif Maybe this requirement is no longer valid. Anyway. I will sent revert patch and replacement to John. Thanks, Arend -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Wed, Mar 05, 2014 at 10:21:09AM +1100, Stephen Rothwell wrote:
> Hi John,
>
> On Wed, 5 Mar 2014 10:16:27 +1100 Stephen Rothwell
> wrote:
> >
> > If I revert commit 161d78555435 "Revert "Staging: rtl8812ae: remove
> > modules field of rate_control_ops"", it fails differently:
> >
> > In file included from drivers/staging/wlan-ng/p80211netdev.c:91:0:
> > drivers/staging/wlan-ng/cfg80211.c: In function 'prism2_scan':
> > drivers/staging/wlan-ng/cfg80211.c:419:10: error: implicit declaration of
> > function 'ieee80211_dsss_chan_to_freq'
> > [-Werror=implicit-function-declaration]
> > ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
> > ^
> > drivers/staging/rtl8821ae/rtl8821ae/trx.c: In function
> > 'rtl8821ae_rx_query_desc':
> > drivers/staging/rtl8821ae/rtl8821ae/trx.c:619:3: warning: passing argument
> > 1 of 'ieee80211_is_robust_mgmt_frame' from incompatible pointer type
> > [enabled by default]
> >if ((ieee80211_is_robust_mgmt_frame(hdr)) &&
> >^
> > In file included from include/net/mac80211.h:20:0,
> > from drivers/staging/rtl8821ae/rtl8821ae/../wifi.h:38,
> > from drivers/staging/rtl8821ae/rtl8821ae/trx.c:30:
> > include/linux/ieee80211.h:2286:20: note: expected 'struct sk_buff *' but
> > argument is of type 'struct ieee80211_hdr *'
> > static inline bool ieee80211_is_robust_mgmt_frame(struct sk_buff *skb)
> > ^
> > drivers/staging/rtl8821ae/rtl8821ae/dm.c: In function
> > 'rtl8821ae_dm_clear_txpower_tracking_state':
> > drivers/staging/rtl8821ae/rtl8821ae/dm.c:487:31: warning: iteration 2u
> > invokes undefined behavior [-Waggressive-loop-optimizations]
> >rtldm->bb_swing_idx_ofdm[p] = rtldm->default_ofdm_index;
> >^
> > drivers/staging/rtl8821ae/rtl8821ae/dm.c:485:2: note: containing loop
> > for (p = RF90_PATH_A; p < MAX_RF_PATH; ++p) {
> > ^
> >
> > So please revert 161d78555435, and then fix this other error.
>
> That fix could be a simple as just disabling the affected staging tree
> driver and letting Greg know. Or you could actually fix it.
John and Larry and I have been talking about how to handle some
cross-tree issues, and I should be merging with his tree soon to handle
them, hopefully this will get resolved at that point in time as well.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
Hi John,
On Wed, 5 Mar 2014 10:16:27 +1100 Stephen Rothwell
wrote:
>
> If I revert commit 161d78555435 "Revert "Staging: rtl8812ae: remove
> modules field of rate_control_ops"", it fails differently:
>
> In file included from drivers/staging/wlan-ng/p80211netdev.c:91:0:
> drivers/staging/wlan-ng/cfg80211.c: In function 'prism2_scan':
> drivers/staging/wlan-ng/cfg80211.c:419:10: error: implicit declaration of
> function 'ieee80211_dsss_chan_to_freq' [-Werror=implicit-function-declaration]
> ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
> ^
> drivers/staging/rtl8821ae/rtl8821ae/trx.c: In function
> 'rtl8821ae_rx_query_desc':
> drivers/staging/rtl8821ae/rtl8821ae/trx.c:619:3: warning: passing argument 1
> of 'ieee80211_is_robust_mgmt_frame' from incompatible pointer type [enabled
> by default]
>if ((ieee80211_is_robust_mgmt_frame(hdr)) &&
>^
> In file included from include/net/mac80211.h:20:0,
> from drivers/staging/rtl8821ae/rtl8821ae/../wifi.h:38,
> from drivers/staging/rtl8821ae/rtl8821ae/trx.c:30:
> include/linux/ieee80211.h:2286:20: note: expected 'struct sk_buff *' but
> argument is of type 'struct ieee80211_hdr *'
> static inline bool ieee80211_is_robust_mgmt_frame(struct sk_buff *skb)
> ^
> drivers/staging/rtl8821ae/rtl8821ae/dm.c: In function
> 'rtl8821ae_dm_clear_txpower_tracking_state':
> drivers/staging/rtl8821ae/rtl8821ae/dm.c:487:31: warning: iteration 2u
> invokes undefined behavior [-Waggressive-loop-optimizations]
>rtldm->bb_swing_idx_ofdm[p] = rtldm->default_ofdm_index;
>^
> drivers/staging/rtl8821ae/rtl8821ae/dm.c:485:2: note: containing loop
> for (p = RF90_PATH_A; p < MAX_RF_PATH; ++p) {
> ^
>
> So please revert 161d78555435, and then fix this other error.
That fix could be a simple as just disabling the affected staging tree
driver and letting Greg know. Or you could actually fix it.
--
Cheers,
Stephen Rothwell
pgpRyjksqbEpn.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
Hi John,
On Wed, 26 Feb 2014 07:47:38 +1100 Stephen Rothwell
wrote:
>
> On Tue, 25 Feb 2014 14:07:16 -0500 "John W. Linville"
> wrote:
> >
> > On Tue, Feb 25, 2014 at 01:35:37PM +1100, Stephen Rothwell wrote:
> > >
> > > After merging the wireless-next tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module'
> > > specified in initializer
> > > .module = NULL,
> > > ^
> > >
> > > Caused by commit 161d78555435 ("Revert "Staging: rtl8812ae: remove
> > > modules field of rate_control_ops"").
> > >
> > > The commit "Staging: rtl8812ae: remove modules field of rate_control_ops"
> > > was needed in the wireless-next tree - I said so at the time of reporting
> > > the original breakage:
> > >
> > > > Actually, your tree is based on -rc2, so you need this patch already (it
> > > > should have bee included in the merge commit 841577c3d33b ("Merge branch
> > > > 'for-john' of
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next").
> > >
> > > And now that part of the wireless-next tree has migrated to the net-next
> > > tree.
> > >
> > > I have no idea why you thought you should revert the fix.
> > >
> > > I have used the wireless tree from next-20140224 for today.
> >
> > The fix should go through Greg's tree. I shouldn't have merged it at all.
>
> No, the fix was only required in your tree (since it was a patch in your
> tree that caused the breakage). And that fix is now in Dave's tree, so
> reverting it in your tree just rebreaks stuff in your tree (and in Dave's
> tree if your tree is merged by Dave again).
Your tree is still broken. I just did some test x86_64 allmodconfig
builds of your tree alone. Current top of tree (wireless-next/master
997bc71a3601 "iwl4965: disable 8K A-MSDU by default") fails like above.
If I revert commit 161d78555435 "Revert "Staging: rtl8812ae: remove
modules field of rate_control_ops"", it fails differently:
In file included from drivers/staging/wlan-ng/p80211netdev.c:91:0:
drivers/staging/wlan-ng/cfg80211.c: In function 'prism2_scan':
drivers/staging/wlan-ng/cfg80211.c:419:10: error: implicit declaration of
function 'ieee80211_dsss_chan_to_freq' [-Werror=implicit-function-declaration]
ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
^
drivers/staging/rtl8821ae/rtl8821ae/trx.c: In function
'rtl8821ae_rx_query_desc':
drivers/staging/rtl8821ae/rtl8821ae/trx.c:619:3: warning: passing argument 1 of
'ieee80211_is_robust_mgmt_frame' from incompatible pointer type [enabled by
default]
if ((ieee80211_is_robust_mgmt_frame(hdr)) &&
^
In file included from include/net/mac80211.h:20:0,
from drivers/staging/rtl8821ae/rtl8821ae/../wifi.h:38,
from drivers/staging/rtl8821ae/rtl8821ae/trx.c:30:
include/linux/ieee80211.h:2286:20: note: expected 'struct sk_buff *' but
argument is of type 'struct ieee80211_hdr *'
static inline bool ieee80211_is_robust_mgmt_frame(struct sk_buff *skb)
^
drivers/staging/rtl8821ae/rtl8821ae/dm.c: In function
'rtl8821ae_dm_clear_txpower_tracking_state':
drivers/staging/rtl8821ae/rtl8821ae/dm.c:487:31: warning: iteration 2u invokes
undefined behavior [-Waggressive-loop-optimizations]
rtldm->bb_swing_idx_ofdm[p] = rtldm->default_ofdm_index;
^
drivers/staging/rtl8821ae/rtl8821ae/dm.c:485:2: note: containing loop
for (p = RF90_PATH_A; p < MAX_RF_PATH; ++p) {
^
So please revert 161d78555435, and then fix this other error.
I am still using the version of wireless-next from next-20140224.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpN3GHVXIqUy.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
Hi John,
On Wed, 26 Feb 2014 07:47:38 +1100 Stephen Rothwell s...@canb.auug.org.au
wrote:
On Tue, 25 Feb 2014 14:07:16 -0500 John W. Linville
linvi...@tuxdriver.com wrote:
On Tue, Feb 25, 2014 at 01:35:37PM +1100, Stephen Rothwell wrote:
After merging the wireless-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module'
specified in initializer
.module = NULL,
^
Caused by commit 161d78555435 (Revert Staging: rtl8812ae: remove
modules field of rate_control_ops).
The commit Staging: rtl8812ae: remove modules field of rate_control_ops
was needed in the wireless-next tree - I said so at the time of reporting
the original breakage:
Actually, your tree is based on -rc2, so you need this patch already (it
should have bee included in the merge commit 841577c3d33b (Merge branch
'for-john' of
git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next).
And now that part of the wireless-next tree has migrated to the net-next
tree.
I have no idea why you thought you should revert the fix.
I have used the wireless tree from next-20140224 for today.
The fix should go through Greg's tree. I shouldn't have merged it at all.
No, the fix was only required in your tree (since it was a patch in your
tree that caused the breakage). And that fix is now in Dave's tree, so
reverting it in your tree just rebreaks stuff in your tree (and in Dave's
tree if your tree is merged by Dave again).
Your tree is still broken. I just did some test x86_64 allmodconfig
builds of your tree alone. Current top of tree (wireless-next/master
997bc71a3601 iwl4965: disable 8K A-MSDU by default) fails like above.
If I revert commit 161d78555435 Revert Staging: rtl8812ae: remove
modules field of rate_control_ops, it fails differently:
In file included from drivers/staging/wlan-ng/p80211netdev.c:91:0:
drivers/staging/wlan-ng/cfg80211.c: In function 'prism2_scan':
drivers/staging/wlan-ng/cfg80211.c:419:10: error: implicit declaration of
function 'ieee80211_dsss_chan_to_freq' [-Werror=implicit-function-declaration]
ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
^
drivers/staging/rtl8821ae/rtl8821ae/trx.c: In function
'rtl8821ae_rx_query_desc':
drivers/staging/rtl8821ae/rtl8821ae/trx.c:619:3: warning: passing argument 1 of
'ieee80211_is_robust_mgmt_frame' from incompatible pointer type [enabled by
default]
if ((ieee80211_is_robust_mgmt_frame(hdr))
^
In file included from include/net/mac80211.h:20:0,
from drivers/staging/rtl8821ae/rtl8821ae/../wifi.h:38,
from drivers/staging/rtl8821ae/rtl8821ae/trx.c:30:
include/linux/ieee80211.h:2286:20: note: expected 'struct sk_buff *' but
argument is of type 'struct ieee80211_hdr *'
static inline bool ieee80211_is_robust_mgmt_frame(struct sk_buff *skb)
^
drivers/staging/rtl8821ae/rtl8821ae/dm.c: In function
'rtl8821ae_dm_clear_txpower_tracking_state':
drivers/staging/rtl8821ae/rtl8821ae/dm.c:487:31: warning: iteration 2u invokes
undefined behavior [-Waggressive-loop-optimizations]
rtldm-bb_swing_idx_ofdm[p] = rtldm-default_ofdm_index;
^
drivers/staging/rtl8821ae/rtl8821ae/dm.c:485:2: note: containing loop
for (p = RF90_PATH_A; p MAX_RF_PATH; ++p) {
^
So please revert 161d78555435, and then fix this other error.
I am still using the version of wireless-next from next-20140224.
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpN3GHVXIqUy.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
Hi John,
On Wed, 5 Mar 2014 10:16:27 +1100 Stephen Rothwell s...@canb.auug.org.au
wrote:
If I revert commit 161d78555435 Revert Staging: rtl8812ae: remove
modules field of rate_control_ops, it fails differently:
In file included from drivers/staging/wlan-ng/p80211netdev.c:91:0:
drivers/staging/wlan-ng/cfg80211.c: In function 'prism2_scan':
drivers/staging/wlan-ng/cfg80211.c:419:10: error: implicit declaration of
function 'ieee80211_dsss_chan_to_freq' [-Werror=implicit-function-declaration]
ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
^
drivers/staging/rtl8821ae/rtl8821ae/trx.c: In function
'rtl8821ae_rx_query_desc':
drivers/staging/rtl8821ae/rtl8821ae/trx.c:619:3: warning: passing argument 1
of 'ieee80211_is_robust_mgmt_frame' from incompatible pointer type [enabled
by default]
if ((ieee80211_is_robust_mgmt_frame(hdr))
^
In file included from include/net/mac80211.h:20:0,
from drivers/staging/rtl8821ae/rtl8821ae/../wifi.h:38,
from drivers/staging/rtl8821ae/rtl8821ae/trx.c:30:
include/linux/ieee80211.h:2286:20: note: expected 'struct sk_buff *' but
argument is of type 'struct ieee80211_hdr *'
static inline bool ieee80211_is_robust_mgmt_frame(struct sk_buff *skb)
^
drivers/staging/rtl8821ae/rtl8821ae/dm.c: In function
'rtl8821ae_dm_clear_txpower_tracking_state':
drivers/staging/rtl8821ae/rtl8821ae/dm.c:487:31: warning: iteration 2u
invokes undefined behavior [-Waggressive-loop-optimizations]
rtldm-bb_swing_idx_ofdm[p] = rtldm-default_ofdm_index;
^
drivers/staging/rtl8821ae/rtl8821ae/dm.c:485:2: note: containing loop
for (p = RF90_PATH_A; p MAX_RF_PATH; ++p) {
^
So please revert 161d78555435, and then fix this other error.
That fix could be a simple as just disabling the affected staging tree
driver and letting Greg know. Or you could actually fix it.
--
Cheers,
Stephen Rothwell s...@canb.auug.org.au
pgpRyjksqbEpn.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
On Wed, Mar 05, 2014 at 10:21:09AM +1100, Stephen Rothwell wrote:
Hi John,
On Wed, 5 Mar 2014 10:16:27 +1100 Stephen Rothwell s...@canb.auug.org.au
wrote:
If I revert commit 161d78555435 Revert Staging: rtl8812ae: remove
modules field of rate_control_ops, it fails differently:
In file included from drivers/staging/wlan-ng/p80211netdev.c:91:0:
drivers/staging/wlan-ng/cfg80211.c: In function 'prism2_scan':
drivers/staging/wlan-ng/cfg80211.c:419:10: error: implicit declaration of
function 'ieee80211_dsss_chan_to_freq'
[-Werror=implicit-function-declaration]
ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
^
drivers/staging/rtl8821ae/rtl8821ae/trx.c: In function
'rtl8821ae_rx_query_desc':
drivers/staging/rtl8821ae/rtl8821ae/trx.c:619:3: warning: passing argument
1 of 'ieee80211_is_robust_mgmt_frame' from incompatible pointer type
[enabled by default]
if ((ieee80211_is_robust_mgmt_frame(hdr))
^
In file included from include/net/mac80211.h:20:0,
from drivers/staging/rtl8821ae/rtl8821ae/../wifi.h:38,
from drivers/staging/rtl8821ae/rtl8821ae/trx.c:30:
include/linux/ieee80211.h:2286:20: note: expected 'struct sk_buff *' but
argument is of type 'struct ieee80211_hdr *'
static inline bool ieee80211_is_robust_mgmt_frame(struct sk_buff *skb)
^
drivers/staging/rtl8821ae/rtl8821ae/dm.c: In function
'rtl8821ae_dm_clear_txpower_tracking_state':
drivers/staging/rtl8821ae/rtl8821ae/dm.c:487:31: warning: iteration 2u
invokes undefined behavior [-Waggressive-loop-optimizations]
rtldm-bb_swing_idx_ofdm[p] = rtldm-default_ofdm_index;
^
drivers/staging/rtl8821ae/rtl8821ae/dm.c:485:2: note: containing loop
for (p = RF90_PATH_A; p MAX_RF_PATH; ++p) {
^
So please revert 161d78555435, and then fix this other error.
That fix could be a simple as just disabling the affected staging tree
driver and letting Greg know. Or you could actually fix it.
John and Larry and I have been talking about how to handle some
cross-tree issues, and I should be merging with his tree soon to handle
them, hopefully this will get resolved at that point in time as well.
thanks,
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
Hi John,
On Tue, 25 Feb 2014 14:07:16 -0500 "John W. Linville"
wrote:
>
> On Tue, Feb 25, 2014 at 01:35:37PM +1100, Stephen Rothwell wrote:
> > Hi John,
> >
> > After merging the wireless-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module'
> > specified in initializer
> > .module = NULL,
> > ^
> >
> > Caused by commit 161d78555435 ("Revert "Staging: rtl8812ae: remove
> > modules field of rate_control_ops"").
> >
> > The commit "Staging: rtl8812ae: remove modules field of rate_control_ops"
> > was needed in the wireless-next tree - I said so at the time of reporting
> > the original breakage:
> >
> > > Actually, your tree is based on -rc2, so you need this patch already (it
> > > should have bee included in the merge commit 841577c3d33b ("Merge branch
> > > 'for-john' of
> > > git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next").
> >
> > And now that part of the wireless-next tree has migrated to the net-next
> > tree.
> >
> > I have no idea why you thought you should revert the fix.
> >
> > I have used the wireless tree from next-20140224 for today.
>
> The fix should go through Greg's tree. I shouldn't have merged it at all.
No, the fix was only required in your tree (since it was a patch in your
tree that caused the breakage). And that fix is now in Dave's tree, so
reverting it in your tree just rebreaks stuff in your tree (and in Dave's
tree if your tree is merged by Dave again).
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpfu8DDXA1w7.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
On Tue, Feb 25, 2014 at 01:35:37PM +1100, Stephen Rothwell wrote:
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module' specified
> in initializer
> .module = NULL,
> ^
>
> Caused by commit 161d78555435 ("Revert "Staging: rtl8812ae: remove
> modules field of rate_control_ops"").
>
> The commit "Staging: rtl8812ae: remove modules field of rate_control_ops"
> was needed in the wireless-next tree - I said so at the time of reporting
> the original breakage:
>
> > Actually, your tree is based on -rc2, so you need this patch already (it
> > should have bee included in the merge commit 841577c3d33b ("Merge branch
> > 'for-john' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next").
>
> And now that part of the wireless-next tree has migrated to the net-next tree.
>
> I have no idea why you thought you should revert the fix.
>
> I have used the wireless tree from next-20140224 for today.
The fix should go through Greg's tree. I shouldn't have merged it at all.
--
John W. LinvilleSomeday the world will need a hero, and you
linvi...@tuxdriver.com might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Tue, Feb 25, 2014 at 01:35:37PM +1100, Stephen Rothwell wrote: Hi John, After merging the wireless-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module' specified in initializer .module = NULL, ^ Caused by commit 161d78555435 (Revert Staging: rtl8812ae: remove modules field of rate_control_ops). The commit Staging: rtl8812ae: remove modules field of rate_control_ops was needed in the wireless-next tree - I said so at the time of reporting the original breakage: Actually, your tree is based on -rc2, so you need this patch already (it should have bee included in the merge commit 841577c3d33b (Merge branch 'for-john' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next). And now that part of the wireless-next tree has migrated to the net-next tree. I have no idea why you thought you should revert the fix. I have used the wireless tree from next-20140224 for today. The fix should go through Greg's tree. I shouldn't have merged it at all. -- John W. LinvilleSomeday the world will need a hero, and you linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
Hi John, On Tue, 25 Feb 2014 14:07:16 -0500 John W. Linville linvi...@tuxdriver.com wrote: On Tue, Feb 25, 2014 at 01:35:37PM +1100, Stephen Rothwell wrote: Hi John, After merging the wireless-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module' specified in initializer .module = NULL, ^ Caused by commit 161d78555435 (Revert Staging: rtl8812ae: remove modules field of rate_control_ops). The commit Staging: rtl8812ae: remove modules field of rate_control_ops was needed in the wireless-next tree - I said so at the time of reporting the original breakage: Actually, your tree is based on -rc2, so you need this patch already (it should have bee included in the merge commit 841577c3d33b (Merge branch 'for-john' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next). And now that part of the wireless-next tree has migrated to the net-next tree. I have no idea why you thought you should revert the fix. I have used the wireless tree from next-20140224 for today. The fix should go through Greg's tree. I shouldn't have merged it at all. No, the fix was only required in your tree (since it was a patch in your tree that caused the breakage). And that fix is now in Dave's tree, so reverting it in your tree just rebreaks stuff in your tree (and in Dave's tree if your tree is merged by Dave again). -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpfu8DDXA1w7.pgp Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
On Thu, Feb 13, 2014 at 01:22:15PM -0500, Paul Gortmaker wrote:
> On Thu, Feb 13, 2014 at 12:31 PM, Paul Gortmaker
> wrote:
> > On Wed, Feb 12, 2014 at 9:19 PM, Stephen Rothwell
> > wrote:
> >> Hi John,
> >>
> >> After merging the wireless-next tree, today's linux-next build (x86_64
> >> allmodconfig) failed like this:
> >>
> >> drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module'
> >> specified in initializer
> >> .module = NULL,
> >> ^
> >>
> >> Caused by commit cc01f9b55fe7 ("mac80211: remove module handling from
> >> rate control ops") interacting with commit 3c05bedb5fef ("Staging:
> >> rtl8812ae: Add Realtek 8821 PCI WIFI driver") which entered Linus' tree
> >> before v3.14-rc1.
> >
> > It seems this new driver has multiple issues; I'm seeing this on sparc32
> > allmodconfig builds.
> >
> > In file included from
> > drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0,
> > from
> > drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:14:
> > drivers/staging/rtl8821ae/btcoexist/../pci.h:290:15: error: expected
> > '=', ',', ';', 'asm' or '__attribute__' before 'rtl_pci_probe'
> > make[3]: *** [drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.o] Error 1
> > make[3]: *** Waiting for unfinished jobs
> >
> > It looks like a mangled version check which is allowing it to try and use
> > __devinit on the rtl_pci_probe function, but of course __devinit is gone.
> >
> > Ideally all that version check stuff should be gutted.
>
> While it still should be gutted, I tracked down the source of the version
> skew. If a person is bisecting and if you go back to pre-UAPI days,
> you will create an include/linux/version.h -- then if you checkout a
> post-UAPI kernel, and run "make distclean" it won't delete that file.
> So you get a situation like this:
>
> $ grep -R LINUX_VERSION_CODE include/
> include/generated/uapi/linux/version.h:#define LINUX_VERSION_CODE 200192
> include/linux/version.h:#define LINUX_VERSION_CODE 132646
>
> Note the presence of a v2.6.38 version. And it will be sourced/used,
> hence the fail above. We might want to unconditionally clobber the
> old file in new kernels to avoid this trap, since it is subtle.
Yeah, I've run into that problem a number of times before, a 'git clean
-fdx' usually fixes it up for me, and is why I do it all the time when
switching major kernel versions.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Thu, Feb 13, 2014 at 12:31 PM, Paul Gortmaker
wrote:
> On Wed, Feb 12, 2014 at 9:19 PM, Stephen Rothwell
> wrote:
>> Hi John,
>>
>> After merging the wireless-next tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module'
>> specified in initializer
>> .module = NULL,
>> ^
>>
>> Caused by commit cc01f9b55fe7 ("mac80211: remove module handling from
>> rate control ops") interacting with commit 3c05bedb5fef ("Staging:
>> rtl8812ae: Add Realtek 8821 PCI WIFI driver") which entered Linus' tree
>> before v3.14-rc1.
>
> It seems this new driver has multiple issues; I'm seeing this on sparc32
> allmodconfig builds.
>
> In file included from
> drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0,
> from
> drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:14:
> drivers/staging/rtl8821ae/btcoexist/../pci.h:290:15: error: expected
> '=', ',', ';', 'asm' or '__attribute__' before 'rtl_pci_probe'
> make[3]: *** [drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.o] Error 1
> make[3]: *** Waiting for unfinished jobs
>
> It looks like a mangled version check which is allowing it to try and use
> __devinit on the rtl_pci_probe function, but of course __devinit is gone.
>
> Ideally all that version check stuff should be gutted.
While it still should be gutted, I tracked down the source of the version
skew. If a person is bisecting and if you go back to pre-UAPI days,
you will create an include/linux/version.h -- then if you checkout a
post-UAPI kernel, and run "make distclean" it won't delete that file.
So you get a situation like this:
$ grep -R LINUX_VERSION_CODE include/
include/generated/uapi/linux/version.h:#define LINUX_VERSION_CODE 200192
include/linux/version.h:#define LINUX_VERSION_CODE 132646
Note the presence of a v2.6.38 version. And it will be sourced/used,
hence the fail above. We might want to unconditionally clobber the
old file in new kernels to avoid this trap, since it is subtle.
Paul.
--
>
> Paul.
> --
>
>>
>> I added this merge fix patch and can carry it as necessary (John, if you
>> back merge v3.14-rc1, you should include this patch in the merge commit):
>>
>> From: Stephen Rothwell
>> Date: Thu, 13 Feb 2014 13:14:13 +1100
>> Subject: [PATCH] Staging: rtl8812ae: remove modules field of rate_control_ops
>>
>> This has been removed in further work.
>>
>> Signed-off-by: Stephen Rothwell
>> ---
>> drivers/staging/rtl8821ae/rc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8821ae/rc.c b/drivers/staging/rtl8821ae/rc.c
>> index d387f13ea7dc..0cc32c60ddee 100644
>> --- a/drivers/staging/rtl8821ae/rc.c
>> +++ b/drivers/staging/rtl8821ae/rc.c
>> @@ -286,7 +286,6 @@ static void rtl_rate_free_sta(void *rtlpriv,
>> }
>>
>> static struct rate_control_ops rtl_rate_ops = {
>> - .module = NULL,
>> .name = "rtl_rc",
>> .alloc = rtl_rate_alloc,
>> .free = rtl_rate_free,
>> --
>> 1.9.rc1
>>
>> --
>> Cheers,
>> Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Wed, Feb 12, 2014 at 9:19 PM, Stephen Rothwell wrote:
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module' specified
> in initializer
> .module = NULL,
> ^
>
> Caused by commit cc01f9b55fe7 ("mac80211: remove module handling from
> rate control ops") interacting with commit 3c05bedb5fef ("Staging:
> rtl8812ae: Add Realtek 8821 PCI WIFI driver") which entered Linus' tree
> before v3.14-rc1.
It seems this new driver has multiple issues; I'm seeing this on sparc32
allmodconfig builds.
In file included from drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0,
from drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:14:
drivers/staging/rtl8821ae/btcoexist/../pci.h:290:15: error: expected
'=', ',', ';', 'asm' or '__attribute__' before 'rtl_pci_probe'
make[3]: *** [drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.o] Error 1
make[3]: *** Waiting for unfinished jobs
It looks like a mangled version check which is allowing it to try and use
__devinit on the rtl_pci_probe function, but of course __devinit is gone.
Ideally all that version check stuff should be gutted.
Paul.
--
>
> I added this merge fix patch and can carry it as necessary (John, if you
> back merge v3.14-rc1, you should include this patch in the merge commit):
>
> From: Stephen Rothwell
> Date: Thu, 13 Feb 2014 13:14:13 +1100
> Subject: [PATCH] Staging: rtl8812ae: remove modules field of rate_control_ops
>
> This has been removed in further work.
>
> Signed-off-by: Stephen Rothwell
> ---
> drivers/staging/rtl8821ae/rc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8821ae/rc.c b/drivers/staging/rtl8821ae/rc.c
> index d387f13ea7dc..0cc32c60ddee 100644
> --- a/drivers/staging/rtl8821ae/rc.c
> +++ b/drivers/staging/rtl8821ae/rc.c
> @@ -286,7 +286,6 @@ static void rtl_rate_free_sta(void *rtlpriv,
> }
>
> static struct rate_control_ops rtl_rate_ops = {
> - .module = NULL,
> .name = "rtl_rc",
> .alloc = rtl_rate_alloc,
> .free = rtl_rate_free,
> --
> 1.9.rc1
>
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Wed, Feb 12, 2014 at 9:19 PM, Stephen Rothwell s...@canb.auug.org.au wrote:
Hi John,
After merging the wireless-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module' specified
in initializer
.module = NULL,
^
Caused by commit cc01f9b55fe7 (mac80211: remove module handling from
rate control ops) interacting with commit 3c05bedb5fef (Staging:
rtl8812ae: Add Realtek 8821 PCI WIFI driver) which entered Linus' tree
before v3.14-rc1.
It seems this new driver has multiple issues; I'm seeing this on sparc32
allmodconfig builds.
In file included from drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0,
from drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:14:
drivers/staging/rtl8821ae/btcoexist/../pci.h:290:15: error: expected
'=', ',', ';', 'asm' or '__attribute__' before 'rtl_pci_probe'
make[3]: *** [drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.o] Error 1
make[3]: *** Waiting for unfinished jobs
It looks like a mangled version check which is allowing it to try and use
__devinit on the rtl_pci_probe function, but of course __devinit is gone.
Ideally all that version check stuff should be gutted.
Paul.
--
I added this merge fix patch and can carry it as necessary (John, if you
back merge v3.14-rc1, you should include this patch in the merge commit):
From: Stephen Rothwell s...@canb.auug.org.au
Date: Thu, 13 Feb 2014 13:14:13 +1100
Subject: [PATCH] Staging: rtl8812ae: remove modules field of rate_control_ops
This has been removed in further work.
Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
drivers/staging/rtl8821ae/rc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rc.c b/drivers/staging/rtl8821ae/rc.c
index d387f13ea7dc..0cc32c60ddee 100644
--- a/drivers/staging/rtl8821ae/rc.c
+++ b/drivers/staging/rtl8821ae/rc.c
@@ -286,7 +286,6 @@ static void rtl_rate_free_sta(void *rtlpriv,
}
static struct rate_control_ops rtl_rate_ops = {
- .module = NULL,
.name = rtl_rc,
.alloc = rtl_rate_alloc,
.free = rtl_rate_free,
--
1.9.rc1
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Thu, Feb 13, 2014 at 12:31 PM, Paul Gortmaker
paul.gortma...@windriver.com wrote:
On Wed, Feb 12, 2014 at 9:19 PM, Stephen Rothwell s...@canb.auug.org.au
wrote:
Hi John,
After merging the wireless-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module'
specified in initializer
.module = NULL,
^
Caused by commit cc01f9b55fe7 (mac80211: remove module handling from
rate control ops) interacting with commit 3c05bedb5fef (Staging:
rtl8812ae: Add Realtek 8821 PCI WIFI driver) which entered Linus' tree
before v3.14-rc1.
It seems this new driver has multiple issues; I'm seeing this on sparc32
allmodconfig builds.
In file included from
drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0,
from
drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:14:
drivers/staging/rtl8821ae/btcoexist/../pci.h:290:15: error: expected
'=', ',', ';', 'asm' or '__attribute__' before 'rtl_pci_probe'
make[3]: *** [drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.o] Error 1
make[3]: *** Waiting for unfinished jobs
It looks like a mangled version check which is allowing it to try and use
__devinit on the rtl_pci_probe function, but of course __devinit is gone.
Ideally all that version check stuff should be gutted.
While it still should be gutted, I tracked down the source of the version
skew. If a person is bisecting and if you go back to pre-UAPI days,
you will create an include/linux/version.h -- then if you checkout a
post-UAPI kernel, and run make distclean it won't delete that file.
So you get a situation like this:
$ grep -R LINUX_VERSION_CODE include/
include/generated/uapi/linux/version.h:#define LINUX_VERSION_CODE 200192
include/linux/version.h:#define LINUX_VERSION_CODE 132646
Note the presence of a v2.6.38 version. And it will be sourced/used,
hence the fail above. We might want to unconditionally clobber the
old file in new kernels to avoid this trap, since it is subtle.
Paul.
--
Paul.
--
I added this merge fix patch and can carry it as necessary (John, if you
back merge v3.14-rc1, you should include this patch in the merge commit):
From: Stephen Rothwell s...@canb.auug.org.au
Date: Thu, 13 Feb 2014 13:14:13 +1100
Subject: [PATCH] Staging: rtl8812ae: remove modules field of rate_control_ops
This has been removed in further work.
Signed-off-by: Stephen Rothwell s...@canb.auug.org.au
---
drivers/staging/rtl8821ae/rc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8821ae/rc.c b/drivers/staging/rtl8821ae/rc.c
index d387f13ea7dc..0cc32c60ddee 100644
--- a/drivers/staging/rtl8821ae/rc.c
+++ b/drivers/staging/rtl8821ae/rc.c
@@ -286,7 +286,6 @@ static void rtl_rate_free_sta(void *rtlpriv,
}
static struct rate_control_ops rtl_rate_ops = {
- .module = NULL,
.name = rtl_rc,
.alloc = rtl_rate_alloc,
.free = rtl_rate_free,
--
1.9.rc1
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On Thu, Feb 13, 2014 at 01:22:15PM -0500, Paul Gortmaker wrote: On Thu, Feb 13, 2014 at 12:31 PM, Paul Gortmaker paul.gortma...@windriver.com wrote: On Wed, Feb 12, 2014 at 9:19 PM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi John, After merging the wireless-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/staging/rtl8821ae/rc.c:289:2: error: unknown field 'module' specified in initializer .module = NULL, ^ Caused by commit cc01f9b55fe7 (mac80211: remove module handling from rate control ops) interacting with commit 3c05bedb5fef (Staging: rtl8812ae: Add Realtek 8821 PCI WIFI driver) which entered Linus' tree before v3.14-rc1. It seems this new driver has multiple issues; I'm seeing this on sparc32 allmodconfig builds. In file included from drivers/staging/rtl8821ae/btcoexist/halbt_precomp.h:31:0, from drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.c:14: drivers/staging/rtl8821ae/btcoexist/../pci.h:290:15: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'rtl_pci_probe' make[3]: *** [drivers/staging/rtl8821ae/btcoexist/halbtc8192e2ant.o] Error 1 make[3]: *** Waiting for unfinished jobs It looks like a mangled version check which is allowing it to try and use __devinit on the rtl_pci_probe function, but of course __devinit is gone. Ideally all that version check stuff should be gutted. While it still should be gutted, I tracked down the source of the version skew. If a person is bisecting and if you go back to pre-UAPI days, you will create an include/linux/version.h -- then if you checkout a post-UAPI kernel, and run make distclean it won't delete that file. So you get a situation like this: $ grep -R LINUX_VERSION_CODE include/ include/generated/uapi/linux/version.h:#define LINUX_VERSION_CODE 200192 include/linux/version.h:#define LINUX_VERSION_CODE 132646 Note the presence of a v2.6.38 version. And it will be sourced/used, hence the fail above. We might want to unconditionally clobber the old file in new kernels to avoid this trap, since it is subtle. Yeah, I've run into that problem a number of times before, a 'git clean -fdx' usually fixes it up for me, and is why I do it all the time when switching major kernel versions. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
Hi John,
On Thu, 13 Feb 2014 13:19:23 +1100 Stephen Rothwell
wrote:
>
> I added this merge fix patch and can carry it as necessary (John, if you
> back merge v3.14-rc1, you should include this patch in the merge commit):
Actually, your tree is based on -rc2, so you need this patch already (it
should have bee included in the merge commit 841577c3d33b ("Merge branch
'for-john' of
git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next").
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpLLG6FQSnKA.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
Hi John, On Thu, 13 Feb 2014 13:19:23 +1100 Stephen Rothwell s...@canb.auug.org.au wrote: I added this merge fix patch and can carry it as necessary (John, if you back merge v3.14-rc1, you should include this patch in the merge commit): Actually, your tree is based on -rc2, so you need this patch already (it should have bee included in the merge commit 841577c3d33b (Merge branch 'for-john' of git://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next). -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpLLG6FQSnKA.pgp Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/23/2013 03:32 AM, Stephen Rothwell wrote:
> Hi John,
>
> After merging the wireless-next tree, today's linux-next build
> (x86_64 allmodconfig) failed like this:
>
> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error:
> bcm47xx_nvram.h: No such file or directory #include
> ^
>
> That file only exists for the MIPS architecture ...
>
> Caused by commit 6ffdead8027c ("bcma: make it possible to select
> SoC support without mips").
>
> I have used the version of the wireless-next tree from
> next-20130722 for today.
Thanks for spotting this. CONFIG_BGMAC should depend on
CONFIG_BCM47XX, I will send a patch for this to David Miller in the
evening.
Hauke
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/
iQIcBAEBAgAGBQJR7i+eAAoJEIZ0px9YPRMyxdMP/ixL8Dff/vZSXrncnWXGeBea
NgllYlmgPq44CyvPSYMi1WpsKBTOW2L3Yt8v7t/OJH4vDTQHrTxSbdtQFuFW9ZqN
+TTbmRkK4EgYyvnJ87RFAA0o6VWkho+oMMdQD88Nj9uBl38wSH2BoX9Dfe/4UPCt
xLS1TtrkNJOtwnu1crgh30aGUtX6Xw9AP201ySS6NElLuhulfHhx3pu3Y4ZiBPpW
sIKUYkpUvrqghKBvFdjy81iJxtdQ99ZYBHVrrTvAWfiV7WMCV8siGj6UDOi+ujgF
qzjMCy0Q4Bs4kL22XNDPTz+vFXRx45NoH7RJdPyV5Z6ylBVfAJZMSMMI5zqv08VG
ihnnyDDUlOGKcgBCoe2HpYDDIwV34WXKTNFNbzmQ2tgE9JntkfDxq6xr4cIS9FTL
iogNUJV32ColuansjkmAeeED6oy6QT7DcZYOMBXNcMHkRQGgt5/XfwYhVYTPWdsG
LuKxnw4RCnzWwL5hsghrtP2s9EPXsmWHf8BWtT+Ob8KmAx/rcnLZL2YDHd8uro0+
ZGZyqExkg9MFC3d+6goJd3E7BXEz/oytTUOBA7RuBsN7OlCVP2ixs1O4HtVwEi+/
o+5CXFKYAlY1+sOVy2lW/RRfZ8XrhUW3rP477HNnrri9bZKb5jvlw9Bb0C2ANDSL
JtW7+ofqPY7+m2xHNX76
=cySC
-END PGP SIGNATURE-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 07/23/2013 03:32 AM, Stephen Rothwell wrote: Hi John, After merging the wireless-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: bcm47xx_nvram.h: No such file or directory #include bcm47xx_nvram.h ^ That file only exists for the MIPS architecture ... Caused by commit 6ffdead8027c (bcma: make it possible to select SoC support without mips). I have used the version of the wireless-next tree from next-20130722 for today. Thanks for spotting this. CONFIG_BGMAC should depend on CONFIG_BCM47XX, I will send a patch for this to David Miller in the evening. Hauke -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBAgAGBQJR7i+eAAoJEIZ0px9YPRMyxdMP/ixL8Dff/vZSXrncnWXGeBea NgllYlmgPq44CyvPSYMi1WpsKBTOW2L3Yt8v7t/OJH4vDTQHrTxSbdtQFuFW9ZqN +TTbmRkK4EgYyvnJ87RFAA0o6VWkho+oMMdQD88Nj9uBl38wSH2BoX9Dfe/4UPCt xLS1TtrkNJOtwnu1crgh30aGUtX6Xw9AP201ySS6NElLuhulfHhx3pu3Y4ZiBPpW sIKUYkpUvrqghKBvFdjy81iJxtdQ99ZYBHVrrTvAWfiV7WMCV8siGj6UDOi+ujgF qzjMCy0Q4Bs4kL22XNDPTz+vFXRx45NoH7RJdPyV5Z6ylBVfAJZMSMMI5zqv08VG ihnnyDDUlOGKcgBCoe2HpYDDIwV34WXKTNFNbzmQ2tgE9JntkfDxq6xr4cIS9FTL iogNUJV32ColuansjkmAeeED6oy6QT7DcZYOMBXNcMHkRQGgt5/XfwYhVYTPWdsG LuKxnw4RCnzWwL5hsghrtP2s9EPXsmWHf8BWtT+Ob8KmAx/rcnLZL2YDHd8uro0+ ZGZyqExkg9MFC3d+6goJd3E7BXEz/oytTUOBA7RuBsN7OlCVP2ixs1O4HtVwEi+/ o+5CXFKYAlY1+sOVy2lW/RRfZ8XrhUW3rP477HNnrri9bZKb5jvlw9Bb0C2ANDSL JtW7+ofqPY7+m2xHNX76 =cySC -END PGP SIGNATURE- -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On 04/01/2013 10:31 PM, Stephen Rothwell wrote:
Hi Larry,
On Mon, 01 Apr 2013 22:07:24 -0500 Larry Finger
wrote:
On 04/01/2013 09:34 PM, Stephen Rothwell wrote:
After merging the wireless-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/net/wireless/rtlwifi/rtl8188ee/dm.c:30:18: fatal error: wifi.h: No such
file or directory
Caused by commit f0eb856e0b6c ("rtlwifi: rtl8188ee: Add new driver").
Forgot a file?
I do not understand. File wifi.h is definitely there and is in
drivers/net/wireless/rtlwifi/. Use of that directory as a source of include
files is handled by "ccflags-y += -I drivers/net/wireless/rtlwifi
-D__CHECK_ENDIAN__" in the Makefile for rtl8188ee. In fact, it builds just fine
here.
What am I missing?
I don't know, sorry. The tree I have also has
drivers/net/wireless/rtlwifi/wifi.h. All the other uses of wifi.h in the
other drivers below that directory use
#include "../wifi.h"
Maybe it has something to do with using O=... on the command line (which I do).
I was trying to get rid of the relative directory notation, but I guess I
screwed it up somewhere. Rather than "wifi.h, I suspect I should have used .
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
Hi Larry,
On Mon, 01 Apr 2013 22:07:24 -0500 Larry Finger
wrote:
>
> On 04/01/2013 09:34 PM, Stephen Rothwell wrote:
> >
> > After merging the wireless-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/net/wireless/rtlwifi/rtl8188ee/dm.c:30:18: fatal error: wifi.h: No
> > such file or directory
> >
> > Caused by commit f0eb856e0b6c ("rtlwifi: rtl8188ee: Add new driver").
> > Forgot a file?
>
> I do not understand. File wifi.h is definitely there and is in
> drivers/net/wireless/rtlwifi/. Use of that directory as a source of include
> files is handled by "ccflags-y += -I drivers/net/wireless/rtlwifi
> -D__CHECK_ENDIAN__" in the Makefile for rtl8188ee. In fact, it builds just
> fine
> here.
>
> What am I missing?
I don't know, sorry. The tree I have also has
drivers/net/wireless/rtlwifi/wifi.h. All the other uses of wifi.h in the
other drivers below that directory use
#include "../wifi.h"
Maybe it has something to do with using O=... on the command line (which I do).
--
Cheers,
Stephen Rothwells...@canb.auug.org.au
pgpJA81tMY9vl.pgp
Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
On 04/01/2013 09:34 PM, Stephen Rothwell wrote:
Hi John,
After merging the wireless-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/net/wireless/rtlwifi/rtl8188ee/dm.c:30:18: fatal error: wifi.h: No such
file or directory
Caused by commit f0eb856e0b6c ("rtlwifi: rtl8188ee: Add new driver").
Forgot a file?
I have used the wireless-next tree from next-20130328 for today.
Stephen,
I do not understand. File wifi.h is definitely there and is in
drivers/net/wireless/rtlwifi/. Use of that directory as a source of include
files is handled by "ccflags-y += -I drivers/net/wireless/rtlwifi
-D__CHECK_ENDIAN__" in the Makefile for rtl8188ee. In fact, it builds just fine
here.
What am I missing?
Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
On 04/01/2013 09:34 PM, Stephen Rothwell wrote: Hi John, After merging the wireless-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/wireless/rtlwifi/rtl8188ee/dm.c:30:18: fatal error: wifi.h: No such file or directory Caused by commit f0eb856e0b6c (rtlwifi: rtl8188ee: Add new driver). Forgot a file? I have used the wireless-next tree from next-20130328 for today. Stephen, I do not understand. File wifi.h is definitely there and is in drivers/net/wireless/rtlwifi/. Use of that directory as a source of include files is handled by ccflags-y += -I drivers/net/wireless/rtlwifi -D__CHECK_ENDIAN__ in the Makefile for rtl8188ee. In fact, it builds just fine here. What am I missing? Larry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: linux-next: build failure after merge of the wireless-next tree
Hi Larry, On Mon, 01 Apr 2013 22:07:24 -0500 Larry Finger larry.fin...@lwfinger.net wrote: On 04/01/2013 09:34 PM, Stephen Rothwell wrote: After merging the wireless-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/wireless/rtlwifi/rtl8188ee/dm.c:30:18: fatal error: wifi.h: No such file or directory Caused by commit f0eb856e0b6c (rtlwifi: rtl8188ee: Add new driver). Forgot a file? I do not understand. File wifi.h is definitely there and is in drivers/net/wireless/rtlwifi/. Use of that directory as a source of include files is handled by ccflags-y += -I drivers/net/wireless/rtlwifi -D__CHECK_ENDIAN__ in the Makefile for rtl8188ee. In fact, it builds just fine here. What am I missing? I don't know, sorry. The tree I have also has drivers/net/wireless/rtlwifi/wifi.h. All the other uses of wifi.h in the other drivers below that directory use #include ../wifi.h Maybe it has something to do with using O=... on the command line (which I do). -- Cheers, Stephen Rothwells...@canb.auug.org.au pgpJA81tMY9vl.pgp Description: PGP signature
Re: linux-next: build failure after merge of the wireless-next tree
On 04/01/2013 10:31 PM, Stephen Rothwell wrote: Hi Larry, On Mon, 01 Apr 2013 22:07:24 -0500 Larry Finger larry.fin...@lwfinger.net wrote: On 04/01/2013 09:34 PM, Stephen Rothwell wrote: After merging the wireless-next tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/net/wireless/rtlwifi/rtl8188ee/dm.c:30:18: fatal error: wifi.h: No such file or directory Caused by commit f0eb856e0b6c (rtlwifi: rtl8188ee: Add new driver). Forgot a file? I do not understand. File wifi.h is definitely there and is in drivers/net/wireless/rtlwifi/. Use of that directory as a source of include files is handled by ccflags-y += -I drivers/net/wireless/rtlwifi -D__CHECK_ENDIAN__ in the Makefile for rtl8188ee. In fact, it builds just fine here. What am I missing? I don't know, sorry. The tree I have also has drivers/net/wireless/rtlwifi/wifi.h. All the other uses of wifi.h in the other drivers below that directory use #include ../wifi.h Maybe it has something to do with using O=... on the command line (which I do). I was trying to get rid of the relative directory notation, but I guess I screwed it up somewhere. Rather than wifi.h, I suspect I should have used wifi.h. Larry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
