Re: linux-next: build warning after merge of the amdgpu tree
On Fri, Apr 16, 2021 at 1:47 AM Liang, Prike wrote: > > [AMD Public Use] > > > From: Stephen Rothwell > > Sent: Friday, April 16, 2021 12:09 PM > > To: Liang, Prike > > Cc: Alex Deucher ; S-k, Shyam-sundar > sundar@amd.com>; Linux Kernel Mailing List > ker...@vger.kernel.org>; Linux Next Mailing List > > > > Subject: Re: linux-next: build warning after merge of the amdgpu tree > > > > Hi, > > > > On Fri, 16 Apr 2021 03:12:12 + "Liang, Prike" > > wrote: > > > > > > Hi, Rothwell > > > > (Stephen, actually :-)) > > > > > This fix solution hasn't locked down and still being discussed and roll- > > updated in the NVMe mail group. > > > Will update the patch once it refined done. > > > > In which case, this patch should not be in linux-next (or any branch that is > > included by linux-next). > > > How about revert the patch temporally ? Once lock down the solution and will > land in the final latest patch. I'll drop it for now. I just have it in there temporarily while it makes its way upstream because a lot of people use this branch and it fixes an important bug. Alex
RE: linux-next: build warning after merge of the amdgpu tree
[AMD Public Use] > From: Stephen Rothwell > Sent: Friday, April 16, 2021 12:09 PM > To: Liang, Prike > Cc: Alex Deucher ; S-k, Shyam-sundar sundar@amd.com>; Linux Kernel Mailing List ker...@vger.kernel.org>; Linux Next Mailing List > Subject: Re: linux-next: build warning after merge of the amdgpu tree > > Hi, > > On Fri, 16 Apr 2021 03:12:12 + "Liang, Prike" > wrote: > > > > Hi, Rothwell > > (Stephen, actually :-)) > > > This fix solution hasn't locked down and still being discussed and roll- > updated in the NVMe mail group. > > Will update the patch once it refined done. > > In which case, this patch should not be in linux-next (or any branch that is > included by linux-next). > How about revert the patch temporally ? Once lock down the solution and will land in the final latest patch. > -- > Cheers, > Stephen Rothwell
Re: linux-next: build warning after merge of the amdgpu tree
Hi, On Fri, 16 Apr 2021 03:12:12 + "Liang, Prike" wrote: > > Hi, Rothwell (Stephen, actually :-)) > This fix solution hasn't locked down and still being discussed and > roll-updated in the NVMe mail group. > Will update the patch once it refined done. In which case, this patch should not be in linux-next (or any branch that is included by linux-next). -- Cheers, Stephen Rothwell pgpe8OeiFcmwZ.pgp Description: OpenPGP digital signature
RE: linux-next: build warning after merge of the amdgpu tree
[AMD Public Use]
Hi, Rothwell
This fix solution hasn't locked down and still being discussed and roll-updated
in the NVMe mail group.
Will update the patch once it refined done.
Thanks,
Prike
> -Original Message-
> From: Stephen Rothwell
> Sent: Friday, April 16, 2021 10:41 AM
> To: Alex Deucher
> Cc: Liang, Prike ; S-k, Shyam-sundar sundar@amd.com>; Linux Kernel Mailing List ker...@vger.kernel.org>; Linux Next Mailing List
> Subject: linux-next: build warning after merge of the amdgpu tree
>
> Hi all,
>
> After merging the amdgpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/pci/quirks.c: In function 'quirk_amd_nvme_fixup':
> drivers/pci/quirks.c:312:18: warning: unused variable 'rdev' [-Wunused-
> variable]
> 312 | struct pci_dev *rdev;
> | ^~~~
>
> Introduced by commit
>
> 9597624ef606 ("nvme: put some AMD PCIE downstream NVME device to
> simple suspend/resume path")
>
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: build warning after merge of the amdgpu tree
On Thu, Jan 21, 2021 at 4:07 AM Alex Deucher wrote:
>
> On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell
> wrote:
> >
> > Hi all,
> >
> > On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell
> > wrote:
> > >
> > > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell
> > > wrote:
> > > >
> > > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In
> > > > function 'dm_set_vblank':
> > > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33:
> > > > warning: unused variable 'dm' [-Wunused-variable]
> > > > 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> > > > | ^~
> > > >
> > > > Caused by commit
> > > >
> > > > 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> > >
> > > I am still getting this warning.
> >
> > I now get this warning from the drm tree merge.
Drat, I missed that when merging.
> Bhawan sent out the fix today:
> https://patchwork.freedesktop.org/patch/415092/
Applied directly to drm-next, thanks.
-Daniel
>
> Alex
>
> >
> > --
> > Cheers,
> > Stephen Rothwell
> ___
> dri-devel mailing list
> dri-de...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
Re: linux-next: build warning after merge of the amdgpu tree
On Wed, Jan 20, 2021 at 7:53 PM Stephen Rothwell wrote:
>
> Hi all,
>
> On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell
> wrote:
> >
> > On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell
> > wrote:
> > >
> > > After merging the amdgpu tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function
> > > 'dm_set_vblank':
> > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33:
> > > warning: unused variable 'dm' [-Wunused-variable]
> > > 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> > > | ^~
> > >
> > > Caused by commit
> > >
> > > 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
> >
> > I am still getting this warning.
>
> I now get this warning from the drm tree merge.
Bhawan sent out the fix today:
https://patchwork.freedesktop.org/patch/415092/
Alex
>
> --
> Cheers,
> Stephen Rothwell
Re: linux-next: build warning after merge of the amdgpu tree
Hi all,
On Wed, 20 Jan 2021 17:15:01 +1100 Stephen Rothwell
wrote:
>
> On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell
> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function
> > 'dm_set_vblank':
> > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33:
> > warning: unused variable 'dm' [-Wunused-variable]
> > 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> > | ^~
> >
> > Caused by commit
> >
> > 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
>
> I am still getting this warning.
I now get this warning from the drm tree merge.
--
Cheers,
Stephen Rothwell
pgp56mswBdrH8.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the amdgpu tree
Hi all,
On Fri, 15 Jan 2021 12:00:14 +1100 Stephen Rothwell
wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function
> 'dm_set_vblank':
> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5380:33: warning:
> unused variable 'dm' [-Wunused-variable]
> 5380 | struct amdgpu_display_manager *dm = &adev->dm;
> | ^~
>
> Caused by commit
>
> 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3")
I am still getting this warning.
--
Cheers,
Stephen Rothwell
pgpX_3bvJD44e.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the amdgpu tree
On Mon, Jan 18, 2021 at 02:52:18PM +0800, Stephen Rothwell wrote: > Hi Ray, > > On Mon, 18 Jan 2021 05:56:20 + "Huang, Ray" wrote: > > > > [AMD Public Use] > > > > Thanks Setphen. Please check attached V2 patch. > > (If you can share the config file to me, I can do the test in my side) > > It looks good, but I did not try to build it. I have attached the > config (it is just a powerpc allyesconfig). > -- > Cheers, > Stephen Rothwell Thanks Stephen. Ray
Re: linux-next: build warning after merge of the amdgpu tree
Hi Ray, On Mon, 18 Jan 2021 05:56:20 + "Huang, Ray" wrote: > > [AMD Public Use] > > Thanks Setphen. Please check attached V2 patch. > (If you can share the config file to me, I can do the test in my side) It looks good, but I did not try to build it. I have attached the config (it is just a powerpc allyesconfig). -- Cheers, Stephen Rothwell powerpc_allyesconfig.gz Description: application/gzip pgpBicKJ8g5Fi.pgp Description: OpenPGP digital signature
RE: linux-next: build warning after merge of the amdgpu tree
[AMD Public Use]
Thanks Setphen. Please check attached V2 patch.
(If you can share the config file to me, I can do the test in my side)
Best Regards,
Ray
-Original Message-
From: Stephen Rothwell
Sent: Monday, January 18, 2021 1:29 PM
To: Alex Deucher
Cc: Huang, Ray ; Linux Kernel Mailing List
; Linux Next Mailing List
Subject: linux-next: build warning after merge of the amdgpu tree
Hi all,
After merging the amdgpu tree, today's linux-next build (powerpc
allyesconfig) gave this warning:
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c: In function
'vangogh_init_smc_tables':
drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:338:5: warning:
"CONFIG_X86" is not defined, evaluates to 0 [-Wundef]
338 | #if CONFIG_X86
| ^~
Caused by commit
9dd19d5232a6 ("drm/amdgpu: fix build error without x86 kconfig")
--
Cheers,
Stephen Rothwell
0001-drm-amdgpu-fix-build-error-without-x86-kconfig-v2.patch
Description: 0001-drm-amdgpu-fix-build-error-without-x86-kconfig-v2.patch
Re: linux-next: build warning after merge of the amdgpu tree
Hi all,
On Tue, 15 Dec 2020 06:56:08 +1100 Stephen Rothwell
wrote:
>
> On Tue, 17 Nov 2020 15:45:14 +1100 Stephen Rothwell
> wrote:
> >
> > After merging the amdgpu tree, today's linux-next build (htmldocs)
> > produced this warning:
> >
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function
> > parameter or member 'crc_win_x_start_property' not described in
> > 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function
> > parameter or member 'crc_win_y_start_property' not described in
> > 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function
> > parameter or member 'crc_win_x_end_property' not described in
> > 'amdgpu_display_manager'
> > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function
> > parameter or member 'crc_win_y_end_property' not described in
> > 'amdgpu_display_manager'
> >
> > Introduced by commit
> >
> > c920888c604d ("drm/amd/display: Expose new CRC window property")
>
> I am still getting those warnings. That commit is now in the drm tree.
These warnings are now from Linus' tree.
--
Cheers,
Stephen Rothwell
pgpkiZM3j6a9I.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the amdgpu tree
Hi all,
On Tue, 17 Nov 2020 15:45:14 +1100 Stephen Rothwell
wrote:
>
> After merging the amdgpu tree, today's linux-next build (htmldocs)
> produced this warning:
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function
> parameter or member 'crc_win_x_start_property' not described in
> 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function
> parameter or member 'crc_win_y_start_property' not described in
> 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function
> parameter or member 'crc_win_x_end_property' not described in
> 'amdgpu_display_manager'
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h:353: warning: Function
> parameter or member 'crc_win_y_end_property' not described in
> 'amdgpu_display_manager'
>
> Introduced by commit
>
> c920888c604d ("drm/amd/display: Expose new CRC window property")
I am still getting those warnings. That commit is now in the drm tree.
--
Cheers,
Stephen Rothwell
pgpzO5X8gNz0Y.pgp
Description: OpenPGP digital signature
Re: linux-next: build warning after merge of the amdgpu tree
Hi all,
On Fri, 10 May 2019 10:59:13 +1000 Stephen Rothwell
wrote:
>
> After merging the amdgpu tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> In file included from drivers/gpu/drm/amd/amdgpu/df_v3_6.c:23:
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c: In function 'df_v3_6_pmc_start':
> drivers/gpu/drm/amd/amdgpu/amdgpu.h:1010:29: warning: 'lo_val' may be used
> uninitialized in this function [-Wmaybe-uninitialized]
> #define WREG32_PCIE(reg, v) adev->pcie_wreg(adev, (reg), (v))
> ^~~~
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c:334:39: note: 'lo_val' was declared here
> uint32_t lo_base_addr, hi_base_addr, lo_val, hi_val;
>^~
>
> Introduced by commit
>
> a6ac0b44bab9 ("drm/amdgpu: add df perfmon regs and funcs for xgmi")
I now get this warning after merging the drm tree ...
--
Cheers,
Stephen Rothwell
pgpsOnD4RGGfZ.pgp
Description: OpenPGP digital signature
