Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
On Tue, Feb 19, 2013 at 11:59:10AM +0200, Felipe Balbi wrote: > Hi, > > On Mon, Feb 18, 2013 at 09:20:10PM +0200, Felipe Balbi wrote: > > On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote: > > > On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: > > > > Whenever a struct device_attribute is registered > > > > with mismatched permissions - read permission without > > > > a show routine or write permission without store > > > > routine - we will issue a big warning so we catch > > > > those early enough. > > > > > > > > Signed-off-by: Felipe Balbi > > > > --- > > > > > > > > This is completely untested. I have only compile tested > > > > to make sure I'm not breaking anything. > > > > > > > > Greg, do you think this would be nice to have ? I could > > > > fire up kvm tomorrow and run on a few of my OMAP-based > > > > boards to make sure it works as expected. > > > > > > Looks good, but you better fix up all of the big offenders that this > > > points out, before I apply it, otherwise we will get a ton of bug > > > reports :) > > > > sure, will do that tomorrow though ;-) > > Just tested $SUBJECT and it didn't trigger any extra warnings. Only the > one whose fix you already applied (I reverted it to make sure $SUBJECT > was working as expected). Ok, care to resend so that I can queue it up after 3.9-rc1 is out, for inclusion in 3.10, and we can have lots of time to see what falls out? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
Hi, On Mon, Feb 18, 2013 at 09:20:10PM +0200, Felipe Balbi wrote: > On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote: > > On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: > > > Whenever a struct device_attribute is registered > > > with mismatched permissions - read permission without > > > a show routine or write permission without store > > > routine - we will issue a big warning so we catch > > > those early enough. > > > > > > Signed-off-by: Felipe Balbi > > > --- > > > > > > This is completely untested. I have only compile tested > > > to make sure I'm not breaking anything. > > > > > > Greg, do you think this would be nice to have ? I could > > > fire up kvm tomorrow and run on a few of my OMAP-based > > > boards to make sure it works as expected. > > > > Looks good, but you better fix up all of the big offenders that this > > points out, before I apply it, otherwise we will get a ton of bug > > reports :) > > sure, will do that tomorrow though ;-) Just tested $SUBJECT and it didn't trigger any extra warnings. Only the one whose fix you already applied (I reverted it to make sure $SUBJECT was working as expected). -- balbi signature.asc Description: Digital signature
Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
Hi, On Mon, Feb 18, 2013 at 09:20:10PM +0200, Felipe Balbi wrote: On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote: On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: Whenever a struct device_attribute is registered with mismatched permissions - read permission without a show routine or write permission without store routine - we will issue a big warning so we catch those early enough. Signed-off-by: Felipe Balbi ba...@ti.com --- This is completely untested. I have only compile tested to make sure I'm not breaking anything. Greg, do you think this would be nice to have ? I could fire up kvm tomorrow and run on a few of my OMAP-based boards to make sure it works as expected. Looks good, but you better fix up all of the big offenders that this points out, before I apply it, otherwise we will get a ton of bug reports :) sure, will do that tomorrow though ;-) Just tested $SUBJECT and it didn't trigger any extra warnings. Only the one whose fix you already applied (I reverted it to make sure $SUBJECT was working as expected). -- balbi signature.asc Description: Digital signature
Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
On Tue, Feb 19, 2013 at 11:59:10AM +0200, Felipe Balbi wrote: Hi, On Mon, Feb 18, 2013 at 09:20:10PM +0200, Felipe Balbi wrote: On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote: On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: Whenever a struct device_attribute is registered with mismatched permissions - read permission without a show routine or write permission without store routine - we will issue a big warning so we catch those early enough. Signed-off-by: Felipe Balbi ba...@ti.com --- This is completely untested. I have only compile tested to make sure I'm not breaking anything. Greg, do you think this would be nice to have ? I could fire up kvm tomorrow and run on a few of my OMAP-based boards to make sure it works as expected. Looks good, but you better fix up all of the big offenders that this points out, before I apply it, otherwise we will get a ton of bug reports :) sure, will do that tomorrow though ;-) Just tested $SUBJECT and it didn't trigger any extra warnings. Only the one whose fix you already applied (I reverted it to make sure $SUBJECT was working as expected). Ok, care to resend so that I can queue it up after 3.9-rc1 is out, for inclusion in 3.10, and we can have lots of time to see what falls out? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote: > On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: > > Whenever a struct device_attribute is registered > > with mismatched permissions - read permission without > > a show routine or write permission without store > > routine - we will issue a big warning so we catch > > those early enough. > > > > Signed-off-by: Felipe Balbi > > --- > > > > This is completely untested. I have only compile tested > > to make sure I'm not breaking anything. > > > > Greg, do you think this would be nice to have ? I could > > fire up kvm tomorrow and run on a few of my OMAP-based > > boards to make sure it works as expected. > > Looks good, but you better fix up all of the big offenders that this > points out, before I apply it, otherwise we will get a ton of bug > reports :) sure, will do that tomorrow though ;-) -- balbi signature.asc Description: Digital signature
Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: > Whenever a struct device_attribute is registered > with mismatched permissions - read permission without > a show routine or write permission without store > routine - we will issue a big warning so we catch > those early enough. > > Signed-off-by: Felipe Balbi > --- > > This is completely untested. I have only compile tested > to make sure I'm not breaking anything. > > Greg, do you think this would be nice to have ? I could > fire up kvm tomorrow and run on a few of my OMAP-based > boards to make sure it works as expected. Looks good, but you better fix up all of the big offenders that this points out, before I apply it, otherwise we will get a ton of bug reports :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: Whenever a struct device_attribute is registered with mismatched permissions - read permission without a show routine or write permission without store routine - we will issue a big warning so we catch those early enough. Signed-off-by: Felipe Balbi ba...@ti.com --- This is completely untested. I have only compile tested to make sure I'm not breaking anything. Greg, do you think this would be nice to have ? I could fire up kvm tomorrow and run on a few of my OMAP-based boards to make sure it works as expected. Looks good, but you better fix up all of the big offenders that this points out, before I apply it, otherwise we will get a ton of bug reports :) thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote: On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote: Whenever a struct device_attribute is registered with mismatched permissions - read permission without a show routine or write permission without store routine - we will issue a big warning so we catch those early enough. Signed-off-by: Felipe Balbi ba...@ti.com --- This is completely untested. I have only compile tested to make sure I'm not breaking anything. Greg, do you think this would be nice to have ? I could fire up kvm tomorrow and run on a few of my OMAP-based boards to make sure it works as expected. Looks good, but you better fix up all of the big offenders that this points out, before I apply it, otherwise we will get a ton of bug reports :) sure, will do that tomorrow though ;-) -- balbi signature.asc Description: Digital signature
