Re: [GIT PULL] Thermal-SoC management updates for v4.21-rc1
On Tue, Jan 01, 2019 at 03:32:50PM -0800, Linus Torvalds wrote: > On Tue, Jan 1, 2019 at 3:16 PM Eduardo Valentin wrote: > > > > > It doesn't even build cleanly. > > > > > > > Do you still have have a copy of the build error? > > A plain "make allmodconfig" shows a warning. I see. I am afraid I really did not catch this. I supposed you are referring to the warning like this: thermal_hwmon.h:29:1: warning: ‘thermal_remove_hwmon_sysfs’ defined but not used [-Wunused-function] I am sending out a patch for this on thermal_hwmon.h and will be resending the pull request once the CIs report back. > > And I refuse to add new warnings. Fair enough. I would not expect anything different. Thanks for reporting. > > Linus
Re: [GIT PULL] Thermal-SoC management updates for v4.21-rc1
On Tue, Jan 1, 2019 at 3:16 PM Eduardo Valentin wrote: > > > It doesn't even build cleanly. > > > > Do you still have have a copy of the build error? A plain "make allmodconfig" shows a warning. And I refuse to add new warnings. Linus
Re: [GIT PULL] Thermal-SoC management updates for v4.21-rc1
On Tue, Jan 01, 2019 at 01:35:36PM -0800, Linus Torvalds wrote: > On Tue, Jan 1, 2019 at 8:05 AM Eduardo Valentin wrote: > > > > Please consider pulling from > > > > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal > > linus > > No. > > I pulled and immediately unpulled again. > hmm... ok I am double checking. > It doesn't even build cleanly. > Do you still have have a copy of the build error? The local tests I did were not enough to see this error, neither were the kernel CI builds. Only failed build was on something completely unrelated (ARC) to these changes: Full Build Summary: https://kernelci.org/build/evalenti/branch/for-kernelci/kernel/v4.20-rc5-42-g055ddb633a35/ > Linus
Re: [GIT PULL] Thermal-SoC management updates for v4.21-rc1
On Tue, Jan 1, 2019 at 8:05 AM Eduardo Valentin wrote: > > Please consider pulling from > > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal > linus No. I pulled and immediately unpulled again. It doesn't even build cleanly. Linus
