Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase
On Tuesday, April 13, 2021 9:39:44 AM CEST Greg Kroah-Hartman wrote: > On Mon, Apr 12, 2021 at 11:02:58PM +0200, Fabio M. De Francesco wrote: > > Removed camelcase in (some) symbols. Further work is needed. > > What symbols did you do this for? What did you change them from and to?> > > Be specific, and try to do only one structure at a time at the most, > trying to review 1000 lines of changes at once is hard, would you want > to do that? :) > For sure, if I were you, I wouldn't be reviewing one thousand lines of code at once :) OK, let's work on one item at a time I'd place each change in a patch of a series: a) one global variable -> one patch with subject containing the name of the symbol (beware that if not 1000 lines you'll have to review 200 lines or more because that file is huge and its globals are used hundreds of times); b) one or more local variables -> one single patch containing the name of the function where they are used; In the while, I'll remove also the trailing "p_" that stand for "pointer" (as Julia suggested). The above seems reasonable to me. Doesn't it? Regarding what Matthew wrote about making use of drivers/net/wireless/realtek/rtlwifi/btcoexist/ I cannot work on it (too much time commitment would be needed, I suppose), but, if someone else can, I won't do the above-mentioned tasks because they would be useless. Said that, I'm not sure if removing camelcase in this file should be done at all. Thanks, Fabio > > thanks, > > greg k-h
Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase
On Mon, Apr 12, 2021 at 11:02:58PM +0200, Fabio M. De Francesco wrote: > Removed camelcase in (some) symbols. Further work is needed. What symbols did you do this for? What did you change them from and to? Be specific, and try to do only one structure at a time at the most, trying to review 1000 lines of changes at once is hard, would you want to do that? :) thanks, greg k-h
Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase
On Mon, Apr 12, 2021 at 11:02:58PM +0200, Fabio M. De Francesco wrote: > Removed camelcase in (some) symbols. Further work is needed. What would be more useful for this driver is making it use drivers/net/wireless/realtek/rtlwifi/btcoexist/ which has already graduated out of staging. I haven't checked how closely it matches, but this is surely a better use of time than "cleaning up" this version.
Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase
On Wednesday, April 7, 2021 7:27:38 PM CEST Greg KH wrote: > On Wed, Apr 07, 2021 at 06:30:00PM +0200, Fabio M. De Francesco wrote: > > Remove camelcase. Issue detected by checkpatch.pl. For now, change only > > names of static functions in order to not break the driver's code. > > > > Signed-off-by: Fabio M. De Francesco > > --- > > drivers/staging/rtl8723bs/hal/sdio_ops.c | 44 > > 1 file changed, 22 insertions(+), 22 deletions(-) > > > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c > > b/drivers/staging/rtl8723bs/hal/sdio_ops.c > > index b1f02bb9f0a9..5e28818e58e0 100644 > > --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c > > +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c > > @@ -19,7 +19,7 @@ > > /* */ > > /* Creadted by Roger, 2011.01.31. */ > > /* */ > > -static void HalSdioGetCmdAddr8723BSdio( > > +static void hal_sdio_get_cmd_addr_8723b_sdio( > > struct adapter *adapter, > > u8 device_id, > > u32 addr, > > @@ -97,7 +97,7 @@ static u8 get_deviceid(u32 addr) > > > > /* > > * Ref: > > - *HalSdioGetCmdAddr8723BSdio() > > + *hal_sdio_get_cmd_addr_8723b_sdio() > > What does this comment even mean? Who can tell? Maybe we should ask the author :( > > I think you can delete it. > Mission accomplished. I'm about to send a new patch. > But really, that's a crazy function name length, can you make it any > shorter? Device drivers developers have their own "style": functions names must have 25 characters or more! > thanks, > > greg k-h >
Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove camelcase
On Wed, Apr 07, 2021 at 06:30:00PM +0200, Fabio M. De Francesco wrote: > Remove camelcase. Issue detected by checkpatch.pl. For now, change only > names of static functions in order to not break the driver's code. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/rtl8723bs/hal/sdio_ops.c | 44 > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c > b/drivers/staging/rtl8723bs/hal/sdio_ops.c > index b1f02bb9f0a9..5e28818e58e0 100644 > --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c > +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c > @@ -19,7 +19,7 @@ > /* */ > /* Creadted by Roger, 2011.01.31. */ > /* */ > -static void HalSdioGetCmdAddr8723BSdio( > +static void hal_sdio_get_cmd_addr_8723b_sdio( > struct adapter *adapter, > u8 device_id, > u32 addr, > @@ -97,7 +97,7 @@ static u8 get_deviceid(u32 addr) > > /* > * Ref: > - *HalSdioGetCmdAddr8723BSdio() > + *hal_sdio_get_cmd_addr_8723b_sdio() What does this comment even mean? I think you can delete it. But really, that's a crazy function name length, can you make it any shorter? thanks, greg k-h
