Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Jan 18, 2008, at 3:56 PM, Jochen Friedrich wrote: Hi Kumar, Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? It's the editor for the kernel command line. thanks, learn something everyday. - k -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Hi Kumar, Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? It's the editor for the kernel command line. Thanks, Jochen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Kumar Gala wrote: So I'll ask, what serial input are you waiting for from the boot wrapper? The bootwrapper has a command line editing prompt. It's fairly gratuitous in the presence of semi-decent firmware, but it's there nonetheless. -Scott -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Jan 18, 2008, at 2:40 PM, Alan Cox wrote: On Fri, 18 Jan 2008 19:47:43 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? This is in the boot wrapper code, not in the linux kernel. Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? - k -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Fri, 18 Jan 2008 19:47:43 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > Hi Alan, > > >> If a freescale watchdog device node is present, reset the watchdog > >> while waiting for serial input. > > > > Why ? We normally rely on user space for watchdog management as only the > > fact user space is behaving really proves a box is happy ? > > This is in the boot wrapper code, not in the linux kernel. Ok now that makes sense, thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? This is in the boot wrapper code, not in the linux kernel. Thanks, Jochen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Thu, 17 Jan 2008 13:32:35 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > If a freescale watchdog device node is present, reset the watchdog > while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Scott Wood schrieb:
+void watchdog_poke(void)
+{
+if (wdt) {
+out_be16(>swsrr, 0x556c);
+out_be16(>swsrr, 0xaa39);
+}
+}
This should be a function pointer, to allow for other watchdog types.
Thanks for the comments. Stephen Rothwell also asked if the filename watchdog.c
is too generic.
I think the pq watchdog is easy enough to keep it in the generic watchdog.c
file, but the
function pointer definitely is the way to go. I'll resubmit.
Thanks,
Jochen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Jochen Friedrich wrote:
+void watchdog_poke(void)
+{
+if (wdt) {
+out_be16(>swsrr, 0x556c);
+out_be16(>swsrr, 0xaa39);
+}
+}
This should be a function pointer, to allow for other watchdog types.
-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Jochen Friedrich wrote:
+void watchdog_poke(void)
+{
+if (wdt) {
+out_be16(wdt-swsrr, 0x556c);
+out_be16(wdt-swsrr, 0xaa39);
+}
+}
This should be a function pointer, to allow for other watchdog types.
-Scott
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Jan 18, 2008, at 2:40 PM, Alan Cox wrote: On Fri, 18 Jan 2008 19:47:43 +0100 Jochen Friedrich [EMAIL PROTECTED] wrote: Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? This is in the boot wrapper code, not in the linux kernel. Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? - k -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Hi Kumar, Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? It's the editor for the kernel command line. Thanks, Jochen -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Jan 18, 2008, at 3:56 PM, Jochen Friedrich wrote: Hi Kumar, Ok now that makes sense, thanks So I'll ask, what serial input are you waiting for from the boot wrapper? It's the editor for the kernel command line. thanks, learn something everyday. - k -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Fri, 18 Jan 2008 19:47:43 +0100 Jochen Friedrich [EMAIL PROTECTED] wrote: Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? This is in the boot wrapper code, not in the linux kernel. Ok now that makes sense, thanks -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Scott Wood schrieb:
+void watchdog_poke(void)
+{
+if (wdt) {
+out_be16(wdt-swsrr, 0x556c);
+out_be16(wdt-swsrr, 0xaa39);
+}
+}
This should be a function pointer, to allow for other watchdog types.
Thanks for the comments. Stephen Rothwell also asked if the filename watchdog.c
is too generic.
I think the pq watchdog is easy enough to keep it in the generic watchdog.c
file, but the
function pointer definitely is the way to go. I'll resubmit.
Thanks,
Jochen
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
Hi Alan, If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? This is in the boot wrapper code, not in the linux kernel. Thanks, Jochen -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Thu, 17 Jan 2008 13:32:35 +0100 Jochen Friedrich [EMAIL PROTECTED] wrote: If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Why ? We normally rely on user space for watchdog management as only the fact user space is behaving really proves a box is happy ? Alan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Thu, 17 Jan 2008 13:32:35 +0100 Jochen Friedrich <[EMAIL PROTECTED]> wrote: > > If a freescale watchdog device node is present, reset the watchdog > while waiting for serial input. > > Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/Makefile |2 +- > arch/powerpc/boot/cpm-serial.c |6 > arch/powerpc/boot/cuboot-8xx.c |1 + > arch/powerpc/boot/ops.h|2 + > arch/powerpc/boot/watchdog.c | 65 > I am just wondering if maybe that file name is to generic. -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgphj0uw92xGg.pgp Description: PGP signature
Re: [PATCH/RFCv2] [POWERPC] Add support for freescale watchdog to CPM serial driver.
On Thu, 17 Jan 2008 13:32:35 +0100 Jochen Friedrich [EMAIL PROTECTED] wrote: If a freescale watchdog device node is present, reset the watchdog while waiting for serial input. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- arch/powerpc/boot/Makefile |2 +- arch/powerpc/boot/cpm-serial.c |6 arch/powerpc/boot/cuboot-8xx.c |1 + arch/powerpc/boot/ops.h|2 + arch/powerpc/boot/watchdog.c | 65 I am just wondering if maybe that file name is to generic. -- Cheers, Stephen Rothwell[EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/ pgphj0uw92xGg.pgp Description: PGP signature
