Re: [PATCH][v2] tools/power turbostat: if --max_loop, print for specific time of loops
On Wed, Apr 11, 2018 at 12:29:04PM +0300, Artem Bityutskiy wrote:
> On Tue, 2018-04-10 at 22:51 +0800, Yu Chen wrote:
> > + case 't':
> > + {
> > + int loops = strtod(optarg, NULL);
> > +
> > + if (loops <= 0) {
> > + fprintf(outf, "loops %d should be
> > positive number\n",
> > + iterations);
> > + exit(2);
> > + }
> > + iterations = loops;
> > + }
>
> What is the point of the additional {} scope and the 'loops' variable
> in it? You could use the 'iterations' variable directly and simplify
> the code.
Got your point, will change it.
>
> Artem.
Re: [PATCH][v2] tools/power turbostat: if --max_loop, print for specific time of loops
On Wed, Apr 11, 2018 at 12:29:04PM +0300, Artem Bityutskiy wrote:
> On Tue, 2018-04-10 at 22:51 +0800, Yu Chen wrote:
> > + case 't':
> > + {
> > + int loops = strtod(optarg, NULL);
> > +
> > + if (loops <= 0) {
> > + fprintf(outf, "loops %d should be
> > positive number\n",
> > + iterations);
> > + exit(2);
> > + }
> > + iterations = loops;
> > + }
>
> What is the point of the additional {} scope and the 'loops' variable
> in it? You could use the 'iterations' variable directly and simplify
> the code.
Got your point, will change it.
>
> Artem.
Re: [PATCH][v2] tools/power turbostat: if --max_loop, print for specific time of loops
On Tue, 2018-04-10 at 22:51 +0800, Yu Chen wrote:
> + case 't':
> + {
> + int loops = strtod(optarg, NULL);
> +
> + if (loops <= 0) {
> + fprintf(outf, "loops %d should be
> positive number\n",
> + iterations);
> + exit(2);
> + }
> + iterations = loops;
> + }
What is the point of the additional {} scope and the 'loops' variable
in it? You could use the 'iterations' variable directly and simplify
the code.
Artem.
Re: [PATCH][v2] tools/power turbostat: if --max_loop, print for specific time of loops
On Tue, 2018-04-10 at 22:51 +0800, Yu Chen wrote:
> + case 't':
> + {
> + int loops = strtod(optarg, NULL);
> +
> + if (loops <= 0) {
> + fprintf(outf, "loops %d should be
> positive number\n",
> + iterations);
> + exit(2);
> + }
> + iterations = loops;
> + }
What is the point of the additional {} scope and the 'loops' variable
in it? You could use the 'iterations' variable directly and simplify
the code.
Artem.
