Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr
On Tuesday 15 January 2008 11:15:02 Harvey Harrison wrote: > On Tue, 2008-01-15 at 11:06 +0100, Andi Kleen wrote: > > On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote: > > > On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote: > > > > Instead of open coding the bit accesses uses standard style > > > > *PageDeferred* macros. > > > > > > > > > > Any reason these couldn't be static inlines in a shared header? > > > > The whole usage of that bit is private to the file > > True if pageattr_32|64.c get merged, not one I have looked at yet, > but wouldn't a static inline in the files then be better for the > typechecking? If you pass in something other than a struct page * the compiler will already complain. Also all the other Page* accessor in page-flags.h are macros. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr
On Tue, 2008-01-15 at 11:06 +0100, Andi Kleen wrote: > On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote: > > On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote: > > > Instead of open coding the bit accesses uses standard style > > > *PageDeferred* macros. > > > > > > > Any reason these couldn't be static inlines in a shared header? > > The whole usage of that bit is private to the file True if pageattr_32|64.c get merged, not one I have looked at yet, but wouldn't a static inline in the files then be better for the typechecking? Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr
On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote: > On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote: > > Instead of open coding the bit accesses uses standard style > > *PageDeferred* macros. > > > > Any reason these couldn't be static inlines in a shared header? The whole usage of that bit is private to the file -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote: > Instead of open coding the bit accesses uses standard style > *PageDeferred* macros. > Any reason these couldn't be static inlines in a shared header? asm/page.h perhaps? Cheers, Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr
On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote: Instead of open coding the bit accesses uses standard style *PageDeferred* macros. Any reason these couldn't be static inlines in a shared header? asm/page.h perhaps? Cheers, Harvey -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr
On Tue, 2008-01-15 at 11:06 +0100, Andi Kleen wrote: On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote: On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote: Instead of open coding the bit accesses uses standard style *PageDeferred* macros. Any reason these couldn't be static inlines in a shared header? The whole usage of that bit is private to the file True if pageattr_32|64.c get merged, not one I have looked at yet, but wouldn't a static inline in the files then be better for the typechecking? Harvey -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr
On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote: On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote: Instead of open coding the bit accesses uses standard style *PageDeferred* macros. Any reason these couldn't be static inlines in a shared header? The whole usage of that bit is private to the file -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [13/31] CPA: Use macros to modify the PG_arch_1 page flags in change_page_attr
On Tuesday 15 January 2008 11:15:02 Harvey Harrison wrote: On Tue, 2008-01-15 at 11:06 +0100, Andi Kleen wrote: On Tuesday 15 January 2008 10:29:51 Harvey Harrison wrote: On Mon, 2008-01-14 at 23:16 +0100, Andi Kleen wrote: Instead of open coding the bit accesses uses standard style *PageDeferred* macros. Any reason these couldn't be static inlines in a shared header? The whole usage of that bit is private to the file True if pageattr_32|64.c get merged, not one I have looked at yet, but wouldn't a static inline in the files then be better for the typechecking? If you pass in something other than a struct page * the compiler will already complain. Also all the other Page* accessor in page-flags.h are macros. -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
