Re: [PATCH] [MTD] CHIPS: oops in cfi_amdstd_sync
On Wed, 2007-02-21 at 14:54 +, Jörn Engel wrote: > On Tue, 20 February 2007 17:46:13 -0800, Vijay Sampath wrote: > > > > The files cfi_cmdset_0002.c and cfi_cmdset_0020.c do not initialize > > their wait queues like is done in cfi_cmdset_0001.c. This causes an > > oops when the wait queue is accessed. I have copied the code from > > cfi_cmdset_0001.c that is pertinent to initialization of the wait > > queue. > > Patch looks good, but I can no longer test it. Josh may still have > access to some commandset 20 chips. Josh, any objections? The patch looks good to me as well. No access to those chips anymore, but I have no objections. josh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] [MTD] CHIPS: oops in cfi_amdstd_sync
On Tue, 20 February 2007 17:46:13 -0800, Vijay Sampath wrote: > > The files cfi_cmdset_0002.c and cfi_cmdset_0020.c do not initialize > their wait queues like is done in cfi_cmdset_0001.c. This causes an > oops when the wait queue is accessed. I have copied the code from > cfi_cmdset_0001.c that is pertinent to initialization of the wait > queue. Patch looks good, but I can no longer test it. Josh may still have access to some commandset 20 chips. Josh, any objections? Jörn -- The only real mistake is the one from which we learn nothing. -- John Powell signature.asc Description: Digital signature
Re: [PATCH] [MTD] CHIPS: oops in cfi_amdstd_sync
On Tue, 20 February 2007 17:46:13 -0800, Vijay Sampath wrote: The files cfi_cmdset_0002.c and cfi_cmdset_0020.c do not initialize their wait queues like is done in cfi_cmdset_0001.c. This causes an oops when the wait queue is accessed. I have copied the code from cfi_cmdset_0001.c that is pertinent to initialization of the wait queue. Patch looks good, but I can no longer test it. Josh may still have access to some commandset 20 chips. Josh, any objections? Jörn -- The only real mistake is the one from which we learn nothing. -- John Powell signature.asc Description: Digital signature
Re: [PATCH] [MTD] CHIPS: oops in cfi_amdstd_sync
On Wed, 2007-02-21 at 14:54 +, Jörn Engel wrote: On Tue, 20 February 2007 17:46:13 -0800, Vijay Sampath wrote: The files cfi_cmdset_0002.c and cfi_cmdset_0020.c do not initialize their wait queues like is done in cfi_cmdset_0001.c. This causes an oops when the wait queue is accessed. I have copied the code from cfi_cmdset_0001.c that is pertinent to initialization of the wait queue. Patch looks good, but I can no longer test it. Josh may still have access to some commandset 20 chips. Josh, any objections? The patch looks good to me as well. No access to those chips anymore, but I have no objections. josh - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
