Re: [PATCH] Better BUG() macro - take 2

[Aaron Lehmann]

On Tue, Feb 20, 2001 at 05:48:35AM -0500, Paul Gortmaker wrote:
> Ok, it appears that some people want the __FILE__, __LINE__ (or equivalent)
> in BUG() and some don't.  Fair enough.  I used the existing config option
> CONFIG_DEBUG_ERRORS to allow people to choose.  There was also interest
> in having BUG() in a more sensible place (e.g. ) and the
> arch specific part separate (I picked ).
> 
> This only deals with i386 - wanted to put this out for comment before
> editing for the others.  Change for other arch is simple though - just
> remove BUG() from asm/page.h and put the *(int *)0=0; type part of what
> was BUG() into asm/system.h as machine_bug(). Oh, and add the config
> option to arch/*/config.in if it isn't already in use.

I noticed the wasteful strings in the kernel image recently and am
excited about this patch.

However, shouldn't this be fixed for all architectures?

Once that happens and the EXPORT_SYMBOL is #ifdef'd, I hope you submit
this to Alan.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] Better BUG() macro - take 2

[J . A . Magallon]

On 02.20 Paul Gortmaker wrote:
>  
> +#ifdef CONFIG_DEBUG_ERRORS
> +const char *kernel_bug = "kernel BUG at %s: line %d!\n";
> +#endif
> 
..
>  EXPORT_SYMBOL(daemonize);
> +EXPORT_SYMBOL(kernel_bug);
>  

Should also be #ifdef'd.
 
-- 
J.A. Magallon  $> cd pub
mailto:[EMAIL PROTECTED]  $> more beer

Linux werewolf 2.4.1-ac19 #1 SMP Mon Feb 19 21:52:31 CET 2001 i686

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/