Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl
On Mon, Jan 14, 2008 at 03:31:17PM +0100, Mathieu Segaud wrote: > + .owner = THIS_MODULE, > + .open = ch_open, > + .release= ch_release, > + .unlocked_ioctl = ch_ioctl, Do you have a tab setting that's not 8? You seem to have used one tab too many for the first three lines. Please correct that one, and then add my: Reviewed-by: Matthew Wilcox <[EMAIL PROTECTED]> Thanks! -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl
Vous m'avez dit récemment : > On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: >> +#include > You don't add any uses of lock_kernel() and there are none in the > driver currently. yep, it was before I noticed the locking semantics of ch_ioctl_compat() >> -.owner= THIS_MODULE, >> -.open = ch_open, >> -.release = ch_release, >> -.ioctl= ch_ioctl, >> +.owner = THIS_MODULE, >> +.open = ch_open, >> +.release= ch_release, >> +.unlocked_ioctl = ch_ioctl, > > If you're going to do the gratuitous reformatting, at least use tabs > instead of spaces. thanks, will do > Other than that, should be fine. I repost this one thanks a lot. -- Mathieu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl
On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: > +#include You don't add any uses of lock_kernel() and there are none in the driver currently. > - .owner= THIS_MODULE, > - .open = ch_open, > - .release = ch_release, > - .ioctl= ch_ioctl, > + .owner = THIS_MODULE, > + .open = ch_open, > + .release= ch_release, > + .unlocked_ioctl = ch_ioctl, If you're going to do the gratuitous reformatting, at least use tabs instead of spaces. Other than that, should be fine. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl
On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: +#include linux/smp_lock.h You don't add any uses of lock_kernel() and there are none in the driver currently. - .owner= THIS_MODULE, - .open = ch_open, - .release = ch_release, - .ioctl= ch_ioctl, + .owner = THIS_MODULE, + .open = ch_open, + .release= ch_release, + .unlocked_ioctl = ch_ioctl, If you're going to do the gratuitous reformatting, at least use tabs instead of spaces. Other than that, should be fine. -- Intel are signing my paycheques ... these opinions are still mine Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl
Vous m'avez dit récemment : On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote: +#include linux/smp_lock.h You don't add any uses of lock_kernel() and there are none in the driver currently. yep, it was before I noticed the locking semantics of ch_ioctl_compat() -.owner= THIS_MODULE, -.open = ch_open, -.release = ch_release, -.ioctl= ch_ioctl, +.owner = THIS_MODULE, +.open = ch_open, +.release= ch_release, +.unlocked_ioctl = ch_ioctl, If you're going to do the gratuitous reformatting, at least use tabs instead of spaces. thanks, will do Other than that, should be fine. I repost this one thanks a lot. -- Mathieu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl
On Mon, Jan 14, 2008 at 03:31:17PM +0100, Mathieu Segaud wrote: + .owner = THIS_MODULE, + .open = ch_open, + .release= ch_release, + .unlocked_ioctl = ch_ioctl, Do you have a tab setting that's not 8? You seem to have used one tab too many for the first three lines. Please correct that one, and then add my: Reviewed-by: Matthew Wilcox [EMAIL PROTECTED] Thanks! -- Intel are signing my paycheques ... these opinions are still mine Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
