Re: [PATCH] DMA: Fix allocation size for PL330 data buffer depth.
On Fri, Nov 14, 2014 at 12:33:01PM +, Liviu Dudau wrote: > On Wed, Nov 12, 2014 at 09:39:52AM +, Vinod Koul wrote: > > On Thu, Nov 06, 2014 at 05:20:12PM +, Liviu Dudau wrote: > > > The datasheet for PL330 says that the data buffer value in the CRD > > > register is 10bits wide. However, the value stored is "minus one", > > > which the driver corrects for. Maximum value that the data buffer > > > depth can have is 1024 lines, which requires 11 bits for storage. > > > > > > While making updates I found printing the peripheral ID as a hex > > > value to be more useful as the datasheet shows the values that way. > > > > Applied, thanks > > Thanks! > > > > > Please snure you use the right subsytem name > > Sorry about that. Just for clarity, it should've been 'dmaengine', right? Yes... -- ~vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: Fix allocation size for PL330 data buffer depth.
On Fri, Nov 14, 2014 at 12:33:01PM +, Liviu Dudau wrote: On Wed, Nov 12, 2014 at 09:39:52AM +, Vinod Koul wrote: On Thu, Nov 06, 2014 at 05:20:12PM +, Liviu Dudau wrote: The datasheet for PL330 says that the data buffer value in the CRD register is 10bits wide. However, the value stored is minus one, which the driver corrects for. Maximum value that the data buffer depth can have is 1024 lines, which requires 11 bits for storage. While making updates I found printing the peripheral ID as a hex value to be more useful as the datasheet shows the values that way. Applied, thanks Thanks! Please snure you use the right subsytem name Sorry about that. Just for clarity, it should've been 'dmaengine', right? Yes... -- ~vinod -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: Fix allocation size for PL330 data buffer depth.
On Wed, Nov 12, 2014 at 09:39:52AM +, Vinod Koul wrote: > On Thu, Nov 06, 2014 at 05:20:12PM +, Liviu Dudau wrote: > > The datasheet for PL330 says that the data buffer value in the CRD > > register is 10bits wide. However, the value stored is "minus one", > > which the driver corrects for. Maximum value that the data buffer > > depth can have is 1024 lines, which requires 11 bits for storage. > > > > While making updates I found printing the peripheral ID as a hex > > value to be more useful as the datasheet shows the values that way. > > Applied, thanks Thanks! > > Please snure you use the right subsytem name Sorry about that. Just for clarity, it should've been 'dmaengine', right? Best regards, Liviu > > -- > ~Vinod > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: Fix allocation size for PL330 data buffer depth.
On Wed, Nov 12, 2014 at 09:39:52AM +, Vinod Koul wrote: On Thu, Nov 06, 2014 at 05:20:12PM +, Liviu Dudau wrote: The datasheet for PL330 says that the data buffer value in the CRD register is 10bits wide. However, the value stored is minus one, which the driver corrects for. Maximum value that the data buffer depth can have is 1024 lines, which requires 11 bits for storage. While making updates I found printing the peripheral ID as a hex value to be more useful as the datasheet shows the values that way. Applied, thanks Thanks! Please snure you use the right subsytem name Sorry about that. Just for clarity, it should've been 'dmaengine', right? Best regards, Liviu -- ~Vinod ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --- ¯\_(ツ)_/¯ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: Fix allocation size for PL330 data buffer depth.
On Thu, Nov 06, 2014 at 05:20:12PM +, Liviu Dudau wrote: > The datasheet for PL330 says that the data buffer value in the CRD > register is 10bits wide. However, the value stored is "minus one", > which the driver corrects for. Maximum value that the data buffer > depth can have is 1024 lines, which requires 11 bits for storage. > > While making updates I found printing the peripheral ID as a hex > value to be more useful as the datasheet shows the values that way. Applied, thanks Please snure you use the right subsytem name -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] DMA: Fix allocation size for PL330 data buffer depth.
On Thu, Nov 06, 2014 at 05:20:12PM +, Liviu Dudau wrote: The datasheet for PL330 says that the data buffer value in the CRD register is 10bits wide. However, the value stored is minus one, which the driver corrects for. Maximum value that the data buffer depth can have is 1024 lines, which requires 11 bits for storage. While making updates I found printing the peripheral ID as a hex value to be more useful as the datasheet shows the values that way. Applied, thanks Please snure you use the right subsytem name -- ~Vinod -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
