Re: [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3_defconfig to fix build warning
On Fri, Aug 14, 2020 at 03:31:19PM +0800, Tiezhu Yang wrote:
> On 08/14/2020 02:53 PM, Thomas Bogendoerfer wrote:
> >On Fri, Aug 14, 2020 at 10:56:33AM +0800, Tiezhu Yang wrote:
> >>Fixes: 70b838292bef ("MIPS: Update default config file for Loongson-3")
> >I'm not so sure whether this warrants a fixes tag.
>
> I use git bisect to find it is the first bad commit. Please let me know
> if it is not necessary and then I will remove the Fixes tag.
Please remove it.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.[ RFC1925, 2.3 ]
Re: [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3_defconfig to fix build warning
On 08/14/2020 02:53 PM, Thomas Bogendoerfer wrote:
On Fri, Aug 14, 2020 at 10:56:33AM +0800, Tiezhu Yang wrote:
Fixes: 70b838292bef ("MIPS: Update default config file for Loongson-3")
I'm not so sure whether this warrants a fixes tag.
I use git bisect to find it is the first bad commit. Please let me know
if it is not necessary and then I will remove the Fixes tag.
arch/mips/configs/loongson3_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/configs/loongson3_defconfig
b/arch/mips/configs/loongson3_defconfig
index a65b08d..2b356d9 100644
--- a/arch/mips/configs/loongson3_defconfig
+++ b/arch/mips/configs/loongson3_defconfig
@@ -403,7 +403,7 @@ CONFIG_CRYPTO_TEA=m
CONFIG_CRYPTO_TWOFISH=m
CONFIG_CRYPTO_DEFLATE=m
CONFIG_PRINTK_TIME=y
-CONFIG_FRAME_WARN=1024
+CONFIG_FRAME_WARN=2048
what about just dropping it ? Default for 64bit is 2048. Leaving it out
of the config has the advantage that you will get a change of the default
for free.
OK, looks good to me, I will send v2.
Thanks,
Tiezhu
Thomas.
Re: [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3_defconfig to fix build warning
On Fri, Aug 14, 2020 at 10:56:33AM +0800, Tiezhu Yang wrote:
> Fixes: 70b838292bef ("MIPS: Update default config file for Loongson-3")
I'm not so sure whether this warrants a fixes tag.
> arch/mips/configs/loongson3_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/configs/loongson3_defconfig
> b/arch/mips/configs/loongson3_defconfig
> index a65b08d..2b356d9 100644
> --- a/arch/mips/configs/loongson3_defconfig
> +++ b/arch/mips/configs/loongson3_defconfig
> @@ -403,7 +403,7 @@ CONFIG_CRYPTO_TEA=m
> CONFIG_CRYPTO_TWOFISH=m
> CONFIG_CRYPTO_DEFLATE=m
> CONFIG_PRINTK_TIME=y
> -CONFIG_FRAME_WARN=1024
> +CONFIG_FRAME_WARN=2048
what about just dropping it ? Default for 64bit is 2048. Leaving it out
of the config has the advantage that you will get a change of the default
for free.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.[ RFC1925, 2.3 ]
