Re: [PATCH] aoe: document sysfs interface

[Ed Cashin]

> On Feb 17, 2018, at 9:37 AM, Julia Lawall  wrote:
> 
> 
> 
>> On Fri, 16 Feb 2018, Ed Cashin wrote:
>> 
>>> On 02/16/2018 10:39 AM, Aishwarya Pant wrote:
>>> Documentation has been compiled from git commit logs and descriptions in
>>> Documentation/aoe/aoe.txt. This should be useful for scripting and
>>> tracking changes in the ABI.
>> ...
>>> +What:/sys/block/etherd*/netif
>> ...
>>> +Description:
>>> +(RO) The name of the network interface on the localhost
>>> through
>>> +which we are communicating with the remote AoE device.
>> 
>> I'd recommend changing that to, "network interfaces".
> 
> Should it then be "names"?

Yes, s’il vous plait. Merci.

— 
  Ed

Re: [PATCH] aoe: document sysfs interface

[Ed Cashin]

> On Feb 17, 2018, at 9:37 AM, Julia Lawall  wrote:
> 
> 
> 
>> On Fri, 16 Feb 2018, Ed Cashin wrote:
>> 
>>> On 02/16/2018 10:39 AM, Aishwarya Pant wrote:
>>> Documentation has been compiled from git commit logs and descriptions in
>>> Documentation/aoe/aoe.txt. This should be useful for scripting and
>>> tracking changes in the ABI.
>> ...
>>> +What:/sys/block/etherd*/netif
>> ...
>>> +Description:
>>> +(RO) The name of the network interface on the localhost
>>> through
>>> +which we are communicating with the remote AoE device.
>> 
>> I'd recommend changing that to, "network interfaces".
> 
> Should it then be "names"?

Yes, s’il vous plait. Merci.

— 
  Ed

Re: [PATCH] aoe: document sysfs interface

[Julia Lawall]

On Fri, 16 Feb 2018, Ed Cashin wrote:

> On 02/16/2018 10:39 AM, Aishwarya Pant wrote:
> > Documentation has been compiled from git commit logs and descriptions in
> > Documentation/aoe/aoe.txt. This should be useful for scripting and
> > tracking changes in the ABI.
> ...
> > +What:  /sys/block/etherd*/netif
> ...
> > +Description:
> > +   (RO) The name of the network interface on the localhost
> > through
> > +   which we are communicating with the remote AoE device.
>
> I'd recommend changing that to, "network interfaces".

Should it then be "names"?

julia

Re: [PATCH] aoe: document sysfs interface

[Julia Lawall]

On Fri, 16 Feb 2018, Ed Cashin wrote:

> On 02/16/2018 10:39 AM, Aishwarya Pant wrote:
> > Documentation has been compiled from git commit logs and descriptions in
> > Documentation/aoe/aoe.txt. This should be useful for scripting and
> > tracking changes in the ABI.
> ...
> > +What:  /sys/block/etherd*/netif
> ...
> > +Description:
> > +   (RO) The name of the network interface on the localhost
> > through
> > +   which we are communicating with the remote AoE device.
>
> I'd recommend changing that to, "network interfaces".

Should it then be "names"?

julia

Re: [PATCH] aoe: document sysfs interface

[Ed Cashin]

On 02/16/2018 10:39 AM, Aishwarya Pant wrote:

Documentation has been compiled from git commit logs and descriptions in
Documentation/aoe/aoe.txt. This should be useful for scripting and
tracking changes in the ABI.

...

+What:  /sys/block/etherd*/netif

...

+Description:
+   (RO) The name of the network interface on the localhost through
+   which we are communicating with the remote AoE device.


I'd recommend changing that to, "network interfaces".

Thanks!

--
  Ed

Re: [PATCH] aoe: document sysfs interface

[Ed Cashin]

On 02/16/2018 10:39 AM, Aishwarya Pant wrote:

Documentation has been compiled from git commit logs and descriptions in
Documentation/aoe/aoe.txt. This should be useful for scripting and
tracking changes in the ABI.

...

+What:  /sys/block/etherd*/netif

...

+Description:
+   (RO) The name of the network interface on the localhost through
+   which we are communicating with the remote AoE device.


I'd recommend changing that to, "network interfaces".

Thanks!

--
  Ed