Re: [PATCH] clk: qcom: Add some missing gcc clks for msm8996

2018-06-19 Thread Stephen Boyd 
Quoting Stephen Boyd (2018-05-15 11:05:44)
> Quoting Bjorn Andersson (2018-04-17 17:09:26)
> > @@ -3350,6 +3522,7 @@ static struct clk_regmap *gcc_msm8996_clocks[] = {
> > [GCC_AGGRE0_CNOC_AHB_CLK] = _aggre0_cnoc_ahb_clk.clkr,
> > [GCC_SMMU_AGGRE0_AXI_CLK] = _smmu_aggre0_axi_clk.clkr,
> > [GCC_SMMU_AGGRE0_AHB_CLK] = _smmu_aggre0_ahb_clk.clkr,
> > +   [GCC_AGGRE1_PNOC_AHB_CLK] = _aggre1_pnoc_ahb_clk.clkr,
> > [GCC_AGGRE2_UFS_AXI_CLK] = _aggre2_ufs_axi_clk.clkr,
> > [GCC_AGGRE2_USB3_AXI_CLK] = _aggre2_usb3_axi_clk.clkr,
> > [GCC_QSPI_AHB_CLK] = _qspi_ahb_clk.clkr,
> > @@ -3360,6 +3533,19 @@ static struct clk_regmap *gcc_msm8996_clocks[] = {
> > [GCC_PCIE_CLKREF_CLK] = _pcie_clkref_clk.clkr,
> > [GCC_RX2_USB2_CLKREF_CLK] = _rx2_usb2_clkref_clk.clkr,
> > [GCC_RX1_USB2_CLKREF_CLK] = _rx1_usb2_clkref_clk.clkr,
> > +   [GCC_HLOS1_VOTE_LPASS_CORE_SMMU_CLK] =
> > +   
> > _vote_lpass_core_smmu_clk.clkr,
> 
> drivers/clk/qcom/gcc-msm8996.c:3512:10: warning: Initializer entry defined 
> twice
> drivers/clk/qcom/gcc-msm8996.c:3536:10: also defined here
> 
> Resend please, or at least let me know what to do here. It looks like
> the one you sent has the parent chain setup properly so that the bus
> rcgs are in the chain of clks, while the one that is already there
> doesn't have the chain setup.

Reminder, this fell out as one of the patches I looked at merging for
v4.18 but didn't make the cut because of this confusion.

Re: [PATCH] clk: qcom: Add some missing gcc clks for msm8996

2018-06-19 Thread Stephen Boyd 
Quoting Stephen Boyd (2018-05-15 11:05:44)
> Quoting Bjorn Andersson (2018-04-17 17:09:26)
> > @@ -3350,6 +3522,7 @@ static struct clk_regmap *gcc_msm8996_clocks[] = {
> > [GCC_AGGRE0_CNOC_AHB_CLK] = _aggre0_cnoc_ahb_clk.clkr,
> > [GCC_SMMU_AGGRE0_AXI_CLK] = _smmu_aggre0_axi_clk.clkr,
> > [GCC_SMMU_AGGRE0_AHB_CLK] = _smmu_aggre0_ahb_clk.clkr,
> > +   [GCC_AGGRE1_PNOC_AHB_CLK] = _aggre1_pnoc_ahb_clk.clkr,
> > [GCC_AGGRE2_UFS_AXI_CLK] = _aggre2_ufs_axi_clk.clkr,
> > [GCC_AGGRE2_USB3_AXI_CLK] = _aggre2_usb3_axi_clk.clkr,
> > [GCC_QSPI_AHB_CLK] = _qspi_ahb_clk.clkr,
> > @@ -3360,6 +3533,19 @@ static struct clk_regmap *gcc_msm8996_clocks[] = {
> > [GCC_PCIE_CLKREF_CLK] = _pcie_clkref_clk.clkr,
> > [GCC_RX2_USB2_CLKREF_CLK] = _rx2_usb2_clkref_clk.clkr,
> > [GCC_RX1_USB2_CLKREF_CLK] = _rx1_usb2_clkref_clk.clkr,
> > +   [GCC_HLOS1_VOTE_LPASS_CORE_SMMU_CLK] =
> > +   
> > _vote_lpass_core_smmu_clk.clkr,
> 
> drivers/clk/qcom/gcc-msm8996.c:3512:10: warning: Initializer entry defined 
> twice
> drivers/clk/qcom/gcc-msm8996.c:3536:10: also defined here
> 
> Resend please, or at least let me know what to do here. It looks like
> the one you sent has the parent chain setup properly so that the bus
> rcgs are in the chain of clks, while the one that is already there
> doesn't have the chain setup.

Reminder, this fell out as one of the patches I looked at merging for
v4.18 but didn't make the cut because of this confusion.

Re: [PATCH] clk: qcom: Add some missing gcc clks for msm8996

2018-05-15 Thread Stephen Boyd 
Quoting Bjorn Andersson (2018-04-17 17:09:26)
> @@ -3350,6 +3522,7 @@ static struct clk_regmap *gcc_msm8996_clocks[] = {
> [GCC_AGGRE0_CNOC_AHB_CLK] = _aggre0_cnoc_ahb_clk.clkr,
> [GCC_SMMU_AGGRE0_AXI_CLK] = _smmu_aggre0_axi_clk.clkr,
> [GCC_SMMU_AGGRE0_AHB_CLK] = _smmu_aggre0_ahb_clk.clkr,
> +   [GCC_AGGRE1_PNOC_AHB_CLK] = _aggre1_pnoc_ahb_clk.clkr,
> [GCC_AGGRE2_UFS_AXI_CLK] = _aggre2_ufs_axi_clk.clkr,
> [GCC_AGGRE2_USB3_AXI_CLK] = _aggre2_usb3_axi_clk.clkr,
> [GCC_QSPI_AHB_CLK] = _qspi_ahb_clk.clkr,
> @@ -3360,6 +3533,19 @@ static struct clk_regmap *gcc_msm8996_clocks[] = {
> [GCC_PCIE_CLKREF_CLK] = _pcie_clkref_clk.clkr,
> [GCC_RX2_USB2_CLKREF_CLK] = _rx2_usb2_clkref_clk.clkr,
> [GCC_RX1_USB2_CLKREF_CLK] = _rx1_usb2_clkref_clk.clkr,
> +   [GCC_HLOS1_VOTE_LPASS_CORE_SMMU_CLK] =
> +   _vote_lpass_core_smmu_clk.clkr,

drivers/clk/qcom/gcc-msm8996.c:3512:10: warning: Initializer entry defined twice
drivers/clk/qcom/gcc-msm8996.c:3536:10: also defined here

Resend please, or at least let me know what to do here. It looks like
the one you sent has the parent chain setup properly so that the bus
rcgs are in the chain of clks, while the one that is already there
doesn't have the chain setup.

Re: [PATCH] clk: qcom: Add some missing gcc clks for msm8996

2018-05-15 Thread Stephen Boyd 
Quoting Bjorn Andersson (2018-04-17 17:09:26)
> @@ -3350,6 +3522,7 @@ static struct clk_regmap *gcc_msm8996_clocks[] = {
> [GCC_AGGRE0_CNOC_AHB_CLK] = _aggre0_cnoc_ahb_clk.clkr,
> [GCC_SMMU_AGGRE0_AXI_CLK] = _smmu_aggre0_axi_clk.clkr,
> [GCC_SMMU_AGGRE0_AHB_CLK] = _smmu_aggre0_ahb_clk.clkr,
> +   [GCC_AGGRE1_PNOC_AHB_CLK] = _aggre1_pnoc_ahb_clk.clkr,
> [GCC_AGGRE2_UFS_AXI_CLK] = _aggre2_ufs_axi_clk.clkr,
> [GCC_AGGRE2_USB3_AXI_CLK] = _aggre2_usb3_axi_clk.clkr,
> [GCC_QSPI_AHB_CLK] = _qspi_ahb_clk.clkr,
> @@ -3360,6 +3533,19 @@ static struct clk_regmap *gcc_msm8996_clocks[] = {
> [GCC_PCIE_CLKREF_CLK] = _pcie_clkref_clk.clkr,
> [GCC_RX2_USB2_CLKREF_CLK] = _rx2_usb2_clkref_clk.clkr,
> [GCC_RX1_USB2_CLKREF_CLK] = _rx1_usb2_clkref_clk.clkr,
> +   [GCC_HLOS1_VOTE_LPASS_CORE_SMMU_CLK] =
> +   _vote_lpass_core_smmu_clk.clkr,

drivers/clk/qcom/gcc-msm8996.c:3512:10: warning: Initializer entry defined twice
drivers/clk/qcom/gcc-msm8996.c:3536:10: also defined here

Resend please, or at least let me know what to do here. It looks like
the one you sent has the parent chain setup properly so that the bus
rcgs are in the chain of clks, while the one that is already there
doesn't have the chain setup.

Re: [PATCH] clk: qcom: Add some missing gcc clks for msm8996

2018-04-24 Thread Rob Herring 
On Tue, Apr 17, 2018 at 05:09:26PM -0700, Bjorn Andersson wrote:
> From: Rajendra Nayak 
> 
> Add a few missing gcc clks for msm8996
> 
> Signed-off-by: Rajendra Nayak 
> [bjorn: omit aggre0_noc_qosgen_extref_clk]
> Signed-off-by: Bjorn Andersson 
> ---
> 
> This patch was accompanied by one that allows the udelay to be defined per
> branch clock, used by the aggre0_noc_qosgen_extref_clk. I dropped this clock
> and the accompanying path in hope that we can get these clock in place.
> 
> Several of these clocks are needed by the MSS remoteproc driver.
> 
>  drivers/clk/qcom/gcc-msm8996.c   | 186 
> +++
>  include/dt-bindings/clock/qcom,gcc-msm8996.h |   9 ++
>  2 files changed, 195 insertions(+)

Reviewed-by: Rob Herring

Re: [PATCH] clk: qcom: Add some missing gcc clks for msm8996

2018-04-24 Thread Rob Herring 
On Tue, Apr 17, 2018 at 05:09:26PM -0700, Bjorn Andersson wrote:
> From: Rajendra Nayak 
> 
> Add a few missing gcc clks for msm8996
> 
> Signed-off-by: Rajendra Nayak 
> [bjorn: omit aggre0_noc_qosgen_extref_clk]
> Signed-off-by: Bjorn Andersson 
> ---
> 
> This patch was accompanied by one that allows the udelay to be defined per
> branch clock, used by the aggre0_noc_qosgen_extref_clk. I dropped this clock
> and the accompanying path in hope that we can get these clock in place.
> 
> Several of these clocks are needed by the MSS remoteproc driver.
> 
>  drivers/clk/qcom/gcc-msm8996.c   | 186 
> +++
>  include/dt-bindings/clock/qcom,gcc-msm8996.h |   9 ++
>  2 files changed, 195 insertions(+)

Reviewed-by: Rob Herring