Re: [PATCH] cnic: remove redundant assignment to variable ret
On Fri, May 08, 2020 at 11:40:26PM +0100, Colin King wrote:
> From: Colin Ian King
>
> The variable ret is being assigned with a value that is never read,
> the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
We used to return negative error codes until commit 23021c21055f ("cnic:
Improve error recovery on bnx2x devices").
To be honest, I like the deliberate "ret = 0;" because this code will
trigger a static checker warning about wrong error codes. Also it looks
wrong to human reviewers. We should probably add a comment:
/* Deliberately returning success */
return 0;
regards,
dan carpenter
Re: [PATCH] cnic: remove redundant assignment to variable ret
On Fri, 8 May 2020 23:40:26 +0100 Colin King wrote:
> From: Colin Ian King
>
> The variable ret is being assigned with a value that is never read,
> the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
Applied, thank you!
Re: [PATCH] cnic: remove redundant assignment to variable ret
On Fri, May 8, 2020 at 3:40 PM Colin King wrote:
>
> From: Colin Ian King
>
> The variable ret is being assigned with a value that is never read,
> the assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
Reviewed-by: Michael Chan
