Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-29 Thread Linus Walleij 
On Thu, Jun 29, 2017 at 1:03 PM, Bartosz Golaszewski  wrote:
> 2017-06-29 11:33 GMT+02:00 Linus Walleij :
>> On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski  wrote:
>>
>>> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
>>> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>>>
>>> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
>>> evaluated to true even if only one event type was requested.
>>>
>>> Fix it by checking both RISING & FALLING flags explicitly.
>>>
>>> Signed-off-by: Bartosz Golaszewski 
>>
>> Patch applied for fixes.
>>
>> Yours,
>> Linus Walleij
>
> Thanks. I think this should also go to linux-stable (e.g. 4.9 LTS is
> affected). Will you forward it or should I do it myself?

I have added the stable tag so it should JustWork(TM).

Yours,
Linus Walleij

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-29 Thread Linus Walleij 
On Thu, Jun 29, 2017 at 1:03 PM, Bartosz Golaszewski  wrote:
> 2017-06-29 11:33 GMT+02:00 Linus Walleij :
>> On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski  wrote:
>>
>>> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
>>> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>>>
>>> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
>>> evaluated to true even if only one event type was requested.
>>>
>>> Fix it by checking both RISING & FALLING flags explicitly.
>>>
>>> Signed-off-by: Bartosz Golaszewski 
>>
>> Patch applied for fixes.
>>
>> Yours,
>> Linus Walleij
>
> Thanks. I think this should also go to linux-stable (e.g. 4.9 LTS is
> affected). Will you forward it or should I do it myself?

I have added the stable tag so it should JustWork(TM).

Yours,
Linus Walleij

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-29 Thread Bartosz Golaszewski 
2017-06-29 11:33 GMT+02:00 Linus Walleij :
> On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski  wrote:
>
>> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
>> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>>
>> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
>> evaluated to true even if only one event type was requested.
>>
>> Fix it by checking both RISING & FALLING flags explicitly.
>>
>> Signed-off-by: Bartosz Golaszewski 
>
> Patch applied for fixes.
>
> Yours,
> Linus Walleij

Thanks. I think this should also go to linux-stable (e.g. 4.9 LTS is
affected). Will you forward it or should I do it myself?

Thanks,
Bartosz

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-29 Thread Bartosz Golaszewski 
2017-06-29 11:33 GMT+02:00 Linus Walleij :
> On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski  wrote:
>
>> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
>> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>>
>> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
>> evaluated to true even if only one event type was requested.
>>
>> Fix it by checking both RISING & FALLING flags explicitly.
>>
>> Signed-off-by: Bartosz Golaszewski 
>
> Patch applied for fixes.
>
> Yours,
> Linus Walleij

Thanks. I think this should also go to linux-stable (e.g. 4.9 LTS is
affected). Will you forward it or should I do it myself?

Thanks,
Bartosz

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-29 Thread Linus Walleij 
On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski  wrote:

> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>
> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
> evaluated to true even if only one event type was requested.
>
> Fix it by checking both RISING & FALLING flags explicitly.
>
> Signed-off-by: Bartosz Golaszewski 

Patch applied for fixes.

Yours,
Linus Walleij

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-29 Thread Linus Walleij 
On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski  wrote:

> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>
> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
> evaluated to true even if only one event type was requested.
>
> Fix it by checking both RISING & FALLING flags explicitly.
>
> Signed-off-by: Bartosz Golaszewski 

Patch applied for fixes.

Yours,
Linus Walleij

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-23 Thread Bartosz Golaszewski 
2017-06-23 13:45 GMT+02:00 Bartosz Golaszewski :
> Hi Linux,
>

s/Linux/Linus :)

Bartosz

Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-23 Thread Bartosz Golaszewski 
2017-06-23 13:45 GMT+02:00 Bartosz Golaszewski :
> Hi Linux,
>

s/Linux/Linus :)

Bartosz