Re: [PATCH] iommu/io-pgtable-arm: fix self-test WARNs on i386
On Mon, Feb 16, 2015 at 06:38:20PM +, Will Deacon wrote: > Various build/boot bots have reported WARNs being triggered by the ARM > iopgtable LPAE self-tests on i386 machines. > > This boils down to two instances of right-shifting a 32-bit unsigned > long (i.e. an iova) by more than the size of the type. On 32-bit ARM, > this happens to give us zero, hence my testing didn't catch this > earlier. > > This patch fixes the issue by using DIV_ROUND_UP and explicit case to > to avoid the erroneous shifts. > > Reported-by: Fengguang Wu > Reported-by: Huang Ying > Signed-off-by: Will Deacon > --- > > Joerg -- please can you apply this as a fix for 3.20? Applied to my fixes branch, thanks Will. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] iommu/io-pgtable-arm: fix self-test WARNs on i386
On Mon, Feb 16, 2015 at 06:38:20PM +, Will Deacon wrote: Various build/boot bots have reported WARNs being triggered by the ARM iopgtable LPAE self-tests on i386 machines. This boils down to two instances of right-shifting a 32-bit unsigned long (i.e. an iova) by more than the size of the type. On 32-bit ARM, this happens to give us zero, hence my testing didn't catch this earlier. This patch fixes the issue by using DIV_ROUND_UP and explicit case to to avoid the erroneous shifts. Reported-by: Fengguang Wu fengguang...@intel.com Reported-by: Huang Ying ying.hu...@intel.com Signed-off-by: Will Deacon will.dea...@arm.com --- Joerg -- please can you apply this as a fix for 3.20? Applied to my fixes branch, thanks Will. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
