Re: [PATCH] irqchip: gic-v3-its: fix entry size mask for GITS_BASER
On Mon, Oct 17, 2016 at 1:00 PM, Vladimir Murzinwrote: > Entry Size in GITS_BASER occupies 5 bits [52:48], but we mask out 8 > bits. > > Fixes: cc2d3216f53c ("irqchip: GICv3: ITS command queue") Looks like it needs the following tag then: Cc: # 3.19+
Re: [PATCH] irqchip: gic-v3-its: fix entry size mask for GITS_BASER
On Mon, Oct 17, 2016 at 1:00 PM, Vladimir Murzin wrote: > Entry Size in GITS_BASER occupies 5 bits [52:48], but we mask out 8 > bits. > > Fixes: cc2d3216f53c ("irqchip: GICv3: ITS command queue") Looks like it needs the following tag then: Cc: # 3.19+
Re: [PATCH] irqchip: gic-v3-its: fix entry size mask for GITS_BASER
On 17/10/16 16:00, Vladimir Murzin wrote: > Entry Size in GITS_BASER occupies 5 bits [52:48], but we mask out 8 > bits. > > Fixes: cc2d3216f53c ("irqchip: GICv3: ITS command queue") > > Signed-off-by: Vladimir Murzin> --- > include/linux/irqchip/arm-gic-v3.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/irqchip/arm-gic-v3.h > b/include/linux/irqchip/arm-gic-v3.h > index 7dec96f..5118d3a 100644 > --- a/include/linux/irqchip/arm-gic-v3.h > +++ b/include/linux/irqchip/arm-gic-v3.h > @@ -290,7 +290,7 @@ > #define GITS_BASER_TYPE_SHIFT(56) > #define GITS_BASER_TYPE(r) (((r) >> GITS_BASER_TYPE_SHIFT) & 7) > #define GITS_BASER_ENTRY_SIZE_SHIFT (48) > -#define GITS_BASER_ENTRY_SIZE(r) r) >> GITS_BASER_ENTRY_SIZE_SHIFT) > & 0xff) + 1) > +#define GITS_BASER_ENTRY_SIZE(r) r) >> GITS_BASER_ENTRY_SIZE_SHIFT) > & 0x1f) + 1) > #define GITS_BASER_SHAREABILITY_SHIFT(10) > #define GITS_BASER_InnerShareable\ > GIC_BASER_SHAREABILITY(GITS_BASER, InnerShareable) > Nice catch. I'll queue that in my fix branch (and add a Cc to stable, since this is a 2 year old bug...). Thanks, M. -- Jazz is not dead. It just smells funny...
Re: [PATCH] irqchip: gic-v3-its: fix entry size mask for GITS_BASER
On 17/10/16 16:00, Vladimir Murzin wrote: > Entry Size in GITS_BASER occupies 5 bits [52:48], but we mask out 8 > bits. > > Fixes: cc2d3216f53c ("irqchip: GICv3: ITS command queue") > > Signed-off-by: Vladimir Murzin > --- > include/linux/irqchip/arm-gic-v3.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/irqchip/arm-gic-v3.h > b/include/linux/irqchip/arm-gic-v3.h > index 7dec96f..5118d3a 100644 > --- a/include/linux/irqchip/arm-gic-v3.h > +++ b/include/linux/irqchip/arm-gic-v3.h > @@ -290,7 +290,7 @@ > #define GITS_BASER_TYPE_SHIFT(56) > #define GITS_BASER_TYPE(r) (((r) >> GITS_BASER_TYPE_SHIFT) & 7) > #define GITS_BASER_ENTRY_SIZE_SHIFT (48) > -#define GITS_BASER_ENTRY_SIZE(r) r) >> GITS_BASER_ENTRY_SIZE_SHIFT) > & 0xff) + 1) > +#define GITS_BASER_ENTRY_SIZE(r) r) >> GITS_BASER_ENTRY_SIZE_SHIFT) > & 0x1f) + 1) > #define GITS_BASER_SHAREABILITY_SHIFT(10) > #define GITS_BASER_InnerShareable\ > GIC_BASER_SHAREABILITY(GITS_BASER, InnerShareable) > Nice catch. I'll queue that in my fix branch (and add a Cc to stable, since this is a 2 year old bug...). Thanks, M. -- Jazz is not dead. It just smells funny...