Re: [PATCH] kgdb: Removed kmalloc returned value cast
On Sun, Mar 10, 2013 at 4:10 PM, Pekka Enberg wrote: > On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad wrote: >> Signed-off-by: Alex Grad >> --- >> arch/powerpc/kernel/kgdb.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c >> index 5ca82cd..c1eef24 100644 >> --- a/arch/powerpc/kernel/kgdb.c >> +++ b/arch/powerpc/kernel/kgdb.c >> @@ -159,7 +159,7 @@ static int kgdb_singlestep(struct pt_regs *regs) >> if (user_mode(regs)) >> return 0; >> >> - backup_current_thread_info = (struct thread_info >> *)kmalloc(sizeof(struct thread_info), GFP_KERNEL); >> + backup_current_thread_info = kmalloc(sizeof(struct thread_info), >> GFP_KERNEL); > > Looks good to me. > > There's two additional problems in the kgdb_singlestep() function: it > doesn't check if the kmalloc() call fails nor does it kfree() the > allocated memory. Hi Pekka, Indeed there is no check if kmalloc() fails. This should be fixed. Anyhow, commit fefd9e6f powerpc: kernel/kgdb.c: Fix memory leakage fixed the problem with kfree. thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] kgdb: Removed kmalloc returned value cast
On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad wrote: > Signed-off-by: Alex Grad > --- > arch/powerpc/kernel/kgdb.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c > index 5ca82cd..c1eef24 100644 > --- a/arch/powerpc/kernel/kgdb.c > +++ b/arch/powerpc/kernel/kgdb.c > @@ -159,7 +159,7 @@ static int kgdb_singlestep(struct pt_regs *regs) > if (user_mode(regs)) > return 0; > > - backup_current_thread_info = (struct thread_info > *)kmalloc(sizeof(struct thread_info), GFP_KERNEL); > + backup_current_thread_info = kmalloc(sizeof(struct thread_info), > GFP_KERNEL); Looks good to me. There's two additional problems in the kgdb_singlestep() function: it doesn't check if the kmalloc() call fails nor does it kfree() the allocated memory. Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] kgdb: Removed kmalloc returned value cast
On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad alex.g...@gmail.com wrote: Signed-off-by: Alex Grad alex.g...@gmail.com --- arch/powerpc/kernel/kgdb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c index 5ca82cd..c1eef24 100644 --- a/arch/powerpc/kernel/kgdb.c +++ b/arch/powerpc/kernel/kgdb.c @@ -159,7 +159,7 @@ static int kgdb_singlestep(struct pt_regs *regs) if (user_mode(regs)) return 0; - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL); + backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL); Looks good to me. There's two additional problems in the kgdb_singlestep() function: it doesn't check if the kmalloc() call fails nor does it kfree() the allocated memory. Pekka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] kgdb: Removed kmalloc returned value cast
On Sun, Mar 10, 2013 at 4:10 PM, Pekka Enberg penb...@kernel.org wrote: On Sun, Mar 10, 2013 at 3:06 PM, Alex Grad alex.g...@gmail.com wrote: Signed-off-by: Alex Grad alex.g...@gmail.com --- arch/powerpc/kernel/kgdb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/kgdb.c b/arch/powerpc/kernel/kgdb.c index 5ca82cd..c1eef24 100644 --- a/arch/powerpc/kernel/kgdb.c +++ b/arch/powerpc/kernel/kgdb.c @@ -159,7 +159,7 @@ static int kgdb_singlestep(struct pt_regs *regs) if (user_mode(regs)) return 0; - backup_current_thread_info = (struct thread_info *)kmalloc(sizeof(struct thread_info), GFP_KERNEL); + backup_current_thread_info = kmalloc(sizeof(struct thread_info), GFP_KERNEL); Looks good to me. There's two additional problems in the kgdb_singlestep() function: it doesn't check if the kmalloc() call fails nor does it kfree() the allocated memory. Hi Pekka, Indeed there is no check if kmalloc() fails. This should be fixed. Anyhow, commit fefd9e6f powerpc: kernel/kgdb.c: Fix memory leakage fixed the problem with kfree. thanks, Daniel. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
