Re: [PATCH] m68k: Fix ndelay() macro
On Fri, Oct 28, 2016 at 05:12:28PM +0200, Boris Brezillon wrote: > The current ndelay() macro definition has an extra semi-colon at the > end of the line thus leading to a compilation error when ndelay is used > in a conditional block with curly braces like this one: without curly braces > > if (cond) > ndelay(t); > else > ... > Philippe -- Philippe De Muyter +32 2 6101532 Macq SA rue de l'Aeronef 2 B-1140 Bruxelles
Re: [PATCH] m68k: Fix ndelay() macro
On Fri, Oct 28, 2016 at 05:12:28PM +0200, Boris Brezillon wrote: > The current ndelay() macro definition has an extra semi-colon at the > end of the line thus leading to a compilation error when ndelay is used > in a conditional block with curly braces like this one: without curly braces > > if (cond) > ndelay(t); > else > ... > Philippe -- Philippe De Muyter +32 2 6101532 Macq SA rue de l'Aeronef 2 B-1140 Bruxelles
Re: [PATCH] m68k: Fix ndelay() macro
Hi Philippe, On Fri, Oct 28, 2016 at 11:03 PM, Philippe De Muyterwrote: > On Fri, Oct 28, 2016 at 05:12:28PM +0200, Boris Brezillon wrote: >> The current ndelay() macro definition has an extra semi-colon at the >> end of the line thus leading to a compilation error when ndelay is used >> in a conditional block with curly braces like this one: > > without curly braces Thanks, I'm fixing that up. Boris: No need to resend. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] m68k: Fix ndelay() macro
Hi Philippe, On Fri, Oct 28, 2016 at 11:03 PM, Philippe De Muyter wrote: > On Fri, Oct 28, 2016 at 05:12:28PM +0200, Boris Brezillon wrote: >> The current ndelay() macro definition has an extra semi-colon at the >> end of the line thus leading to a compilation error when ndelay is used >> in a conditional block with curly braces like this one: > > without curly braces Thanks, I'm fixing that up. Boris: No need to resend. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] m68k: Fix ndelay() macro
Hi Boris, On Fri, Oct 28, 2016 at 5:12 PM, Boris Brezillonwrote: > The current ndelay() macro definition has an extra semi-colon at the > end of the line thus leading to a compilation error when ndelay is used > in a conditional block with curly braces like this one: > > if (cond) > ndelay(t); > else > ... > > which, after the preprocessor pass gives: > > if (cond) > m68k_ndelay(t);; > else > ... > > thus leading to the following gcc error: > > error: 'else' without a previous 'if' > > Remove this extra semi-colon. > > Signed-off-by: Boris Brezillon Thank you, will apply and queue for v4.9. > Fixes: c8ee038bd1488 ("m68k: Implement ndelay() based on the existing > udelay() logic") Wow, that's even a quite recent commit. Needs backporting only to v3.10+... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Re: [PATCH] m68k: Fix ndelay() macro
Hi Boris, On Fri, Oct 28, 2016 at 5:12 PM, Boris Brezillon wrote: > The current ndelay() macro definition has an extra semi-colon at the > end of the line thus leading to a compilation error when ndelay is used > in a conditional block with curly braces like this one: > > if (cond) > ndelay(t); > else > ... > > which, after the preprocessor pass gives: > > if (cond) > m68k_ndelay(t);; > else > ... > > thus leading to the following gcc error: > > error: 'else' without a previous 'if' > > Remove this extra semi-colon. > > Signed-off-by: Boris Brezillon Thank you, will apply and queue for v4.9. > Fixes: c8ee038bd1488 ("m68k: Implement ndelay() based on the existing > udelay() logic") Wow, that's even a quite recent commit. Needs backporting only to v3.10+... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds