Re: [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[]
> > To be frank, I've never known what the double const means. Care to > > enlighten? > > There's a nice table here: > > http://stackoverflow.com/questions/14562845/why-does-passing-char-as-const-char-generate-a-warning Okay, I get it. I think you're right, I'll make the change and see what else breaks and try to fix that too. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[]
To be frank, I've never known what the double const means. Care to enlighten? There's a nice table here: http://stackoverflow.com/questions/14562845/why-does-passing-char-as-const-char-generate-a-warning Okay, I get it. I think you're right, I'll make the change and see what else breaks and try to fix that too. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[]
On Thu, 2014-05-22 at 17:08 +0100, Lee Jones wrote: > To be frank, I've never known what the double const means. Care to > enlighten? There's a nice table here: http://stackoverflow.com/questions/14562845/why-does-passing-char-as-const-char-generate-a-warning -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[]
> > drivers/mfd/axp20x.c:159:3:
> > warning: initialization discards ‘const’ qualifier from pointer target
> > type
> >.parent_supplies = axp20x_supplies,
> []
> > diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> []
> > @@ -140,7 +140,7 @@ static const struct regmap_irq_chip
> > axp20x_regmap_irq_chip = {
> > .init_ack_masked= true,
> > };
> >
> > -static const char * const axp20x_supplies[] = {
> > +static const char * axp20x_supplies[] = {
> > "acin",
> > "vin2",
> > "vin3",
>
> Perhaps you're doing this the wrong way round.
> Maybe this definition should change.
>
> include/linux/mfd/core.h: const char **parent_supplies;
Are you asking me, or telling me? :)
To be frank, I've never known what the double const means. Care to
enlighten?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[]
On Thu, 2014-05-22 at 10:18 +0100, Lee Jones wrote:
> drivers/mfd/axp20x.c:159:3:
> warning: initialization discards ‘const’ qualifier from pointer target type
>.parent_supplies = axp20x_supplies,
[]
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
[]
> @@ -140,7 +140,7 @@ static const struct regmap_irq_chip
> axp20x_regmap_irq_chip = {
> .init_ack_masked= true,
> };
>
> -static const char * const axp20x_supplies[] = {
> +static const char * axp20x_supplies[] = {
> "acin",
> "vin2",
> "vin3",
Perhaps you're doing this the wrong way round.
Maybe this definition should change.
include/linux/mfd/core.h: const char **parent_supplies;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[]
On Thu, 2014-05-22 at 10:18 +0100, Lee Jones wrote:
drivers/mfd/axp20x.c:159:3:
warning: initialization discards ‘const’ qualifier from pointer target type
.parent_supplies = axp20x_supplies,
[]
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
[]
@@ -140,7 +140,7 @@ static const struct regmap_irq_chip
axp20x_regmap_irq_chip = {
.init_ack_masked= true,
};
-static const char * const axp20x_supplies[] = {
+static const char * axp20x_supplies[] = {
acin,
vin2,
vin3,
Perhaps you're doing this the wrong way round.
Maybe this definition should change.
include/linux/mfd/core.h: const char **parent_supplies;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[]
drivers/mfd/axp20x.c:159:3:
warning: initialization discards ‘const’ qualifier from pointer target
type
.parent_supplies = axp20x_supplies,
[]
diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
[]
@@ -140,7 +140,7 @@ static const struct regmap_irq_chip
axp20x_regmap_irq_chip = {
.init_ack_masked= true,
};
-static const char * const axp20x_supplies[] = {
+static const char * axp20x_supplies[] = {
acin,
vin2,
vin3,
Perhaps you're doing this the wrong way round.
Maybe this definition should change.
include/linux/mfd/core.h: const char **parent_supplies;
Are you asking me, or telling me? :)
To be frank, I've never known what the double const means. Care to
enlighten?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] mfd: axp20x: Remove unnecessary const qualifier from axp20x_supplies[]
On Thu, 2014-05-22 at 17:08 +0100, Lee Jones wrote: To be frank, I've never known what the double const means. Care to enlighten? There's a nice table here: http://stackoverflow.com/questions/14562845/why-does-passing-char-as-const-char-generate-a-warning -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
