Re: [PATCH] mt7601u: check memory allocation failure
Le 21/08/2017 à 23:41, Jakub Kicinski a écrit : On Mon, 21 Aug 2017 14:34:30 -0700, Jakub Kicinski wrote: On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote: Check memory allocation failure and return -ENOMEM in such a case, as already done a few lines below Signed-off-by: Christophe JAILLET Acked-by: Jakub Kicinski Wait, I take that back. This code is a bit weird. We would return an error, then mt7601u_dma_init() will call mt7601u_free_tx_queue() which doesn't check for tx_q == NULL condition. Looks like mt7601u_free_tx() has to check for dev->tx_q == NULL and return early if that's the case. Or mt7601u_alloc_tx() should really clean things up on it's own on failure. Ugh. You are right. Thanks for the review. I've sent a v2 which updates 'mt7601u_free_tx()'. Doing so sounds more in line with the spirit of this code. CJ
Re: [PATCH] mt7601u: check memory allocation failure
On Mon, 21 Aug 2017 14:34:30 -0700, Jakub Kicinski wrote: > On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote: > > Check memory allocation failure and return -ENOMEM in such a case, as > > already done a few lines below > > > > Signed-off-by: Christophe JAILLET > > Acked-by: Jakub Kicinski Wait, I take that back. This code is a bit weird. We would return an error, then mt7601u_dma_init() will call mt7601u_free_tx_queue() which doesn't check for tx_q == NULL condition. Looks like mt7601u_free_tx() has to check for dev->tx_q == NULL and return early if that's the case. Or mt7601u_alloc_tx() should really clean things up on it's own on failure. Ugh.
Re: [PATCH] mt7601u: check memory allocation failure
On Mon, 21 Aug 2017 22:59:56 +0200, Christophe JAILLET wrote: > Check memory allocation failure and return -ENOMEM in such a case, as > already done a few lines below > > Signed-off-by: Christophe JAILLET Acked-by: Jakub Kicinski Thanks!
