Re: [PATCH] net: hns: mark symbols static where possible
On Wednesday, October 26, 2016 5:48:32 PM CEST Baoyou Xie wrote: > In fact, last month I sent a similar patch to fix the warnings, but this > older patch is based on linux-next, not net git tree, so the patch didn't > apply. > > now, I rework the patch base on git:// > git.kernel.org/pub/scm/linux/kernel/git/davem/net.git. I think I see the mistake that led to the confusion before: you should base cleanups for network drivers on net-next.git, not net.git. The correct URL is git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git and it is usually very close to linux-next, except for patches that just got applied and have not made it into the latest linux-next. Only if you find a serious bug, use net.git instead so the fix can go into the mainline kernel. Arnd
Re: [PATCH] net: hns: mark symbols static where possible
From: Baoyou Xie Date: Sun, 25 Sep 2016 17:34:06 +0800 > We get a few warnings when building kernel with W=1: Patch does not apply to net-next.
Re: [PATCH] net: hns: mark symbols static where possible
From: Baoyou Xie Date: Sun, 18 Sep 2016 17:07:25 +0800 > We get a few warnings when building kernel with W=1: > drivers/net/ethernet/hisilicon/hisi_femac.c:943:5: warning: no previous > prototype for 'hisi_femac_drv_suspend' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hisi_femac.c:960:5: warning: no previous > prototype for 'hisi_femac_drv_resume' [-Wmissing-prototypes] > drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c:76:21: warning: no previous > prototype for 'hns_ae_get_handle' [-Wmissing-prototypes] > > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie Does not apply cleanly to net-next, please respin.
