Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device
> >> Move from i2c_new_dummy() to i2c_new_dummy_device(). So, we now get an > >> ERRPTR which we use in error handling. > >> > >> Signed-off-by: Wolfram Sang > > Subject & description are incomplete, you're also changing i2c_new_device() > to i2c_new_client_device(). Right, this was an anomaly with this patch to have both code paths returning an ERRPTR. The big conversion for i2c_new_device will come later in a seperate series. > Other than that, > Acked-by: Edward Cree Thanks! signature.asc Description: PGP signature
Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device
From: Wolfram Sang Date: Mon, 22 Jul 2019 19:26:35 +0200 > Move from i2c_new_dummy() to i2c_new_dummy_device(). So, we now get an > ERRPTR which we use in error handling. > > Signed-off-by: Wolfram Sang Applied.
Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device
On 24/07/2019 23:47, David Miller wrote: > From: Wolfram Sang > Date: Mon, 22 Jul 2019 19:26:35 +0200 > >> Move from i2c_new_dummy() to i2c_new_dummy_device(). So, we now get an >> ERRPTR which we use in error handling. >> >> Signed-off-by: Wolfram Sang Subject & description are incomplete, you're also changing i2c_new_device() to i2c_new_client_device(). Other than that, Acked-by: Edward Cree > Solarflare folks, please review/test. > > Thank you. Falcon isn't likely to get tested by us, I think we only have about three of them left in the building, two of which are in display cabinets ;-) We end-of-lifed this hardware a couple of years ago, maybe it should be downgraded from 'supported' to 'odd fixes'. Or even moved to staging, like that qlogic driver recently was.
Re: [PATCH] net: sfc: falcon: convert to i2c_new_dummy_device
From: Wolfram Sang Date: Mon, 22 Jul 2019 19:26:35 +0200 > Move from i2c_new_dummy() to i2c_new_dummy_device(). So, we now get an > ERRPTR which we use in error handling. > > Signed-off-by: Wolfram Sang Solarflare folks, please review/test. Thank you.
