Re: [PATCH] perf tools: Allow multiple cpus record for -p option
On Fri, 1 Nov 2013 16:52:45 +0100, Jiri Olsa wrote: > Currently we don't create default CPU map for task related > target, like: > > $ perf record -p > > This makes record command to disable inherited events. > which is not desired behaviour (we have special option > for that (-i) anyway). > > Fixing this by creating default CPU map for task related > processes. > > Signed-off-by: Jiri Olsa > Cc: Adrian Hunter > Cc: Corey Ashford > Cc: David Ahern > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc: Namhyung Kim > Cc: Paul Mackerras > Cc: Peter Zijlstra > Cc: Arnaldo Carvalho de Melo > --- > tools/perf/util/evlist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index 0582f67..52bb127 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -804,7 +804,7 @@ int perf_evlist__create_maps(struct perf_evlist *evlist, > return -1; > > if (perf_target__has_task(target)) > - evlist->cpus = cpu_map__dummy_new(); > + evlist->cpus = cpu_map__new(target->cpu_list); Just a side note, if the target has task, the cpu list should be NULL as task target has a precedence. Please see perf_target__validate(). But I'm fine with the change itself. :) Thanks, Namhyung > else if (!perf_target__has_cpu(target) && !target->uses_mmap) > evlist->cpus = cpu_map__dummy_new(); > else -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf tools: Allow multiple cpus record for -p option
On Fri, 1 Nov 2013 16:52:45 +0100, Jiri Olsa wrote: Currently we don't create default CPU map for task related target, like: $ perf record -p pid This makes record command to disable inherited events. which is not desired behaviour (we have special option for that (-i) anyway). Fixing this by creating default CPU map for task related processes. Signed-off-by: Jiri Olsa jo...@redhat.com Cc: Adrian Hunter adrian.hun...@intel.com Cc: Corey Ashford cjash...@linux.vnet.ibm.com Cc: David Ahern dsah...@gmail.com Cc: Frederic Weisbecker fweis...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Namhyung Kim namhy...@kernel.org Cc: Paul Mackerras pau...@samba.org Cc: Peter Zijlstra a.p.zijls...@chello.nl Cc: Arnaldo Carvalho de Melo a...@redhat.com --- tools/perf/util/evlist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 0582f67..52bb127 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -804,7 +804,7 @@ int perf_evlist__create_maps(struct perf_evlist *evlist, return -1; if (perf_target__has_task(target)) - evlist-cpus = cpu_map__dummy_new(); + evlist-cpus = cpu_map__new(target-cpu_list); Just a side note, if the target has task, the cpu list should be NULL as task target has a precedence. Please see perf_target__validate(). But I'm fine with the change itself. :) Thanks, Namhyung else if (!perf_target__has_cpu(target) !target-uses_mmap) evlist-cpus = cpu_map__dummy_new(); else -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
