Re: [PATCH] perf tools: arm-spe: Fix uninitialized record error variable
Em Mon, Aug 13, 2018 at 03:55:11PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Aug 10, 2018 at 05:45:12PM -0500, Kim Phillips escreveu:
> > The auxtrace init variable 'err' was not being initialized, leading
> > perf to abort early in an SPE record command when there was no explicit
> > error, rather only based whatever memory contents were on the stack.
> > Initialize it explicitly on getting an SPE successfully, the same way
> > cs-etm does.
> >
> > Signed-off-by: Kim Phillips
> > ---
> > Hi Arnaldo, please apply to perf/urgent / stable series if at all
> > possible. Thank you.
>
> In such cases the best thing is to have a "Fixes: ..." so that this gets
> automatically picked by the stabe trees, I'll try to find out what was
> the patch that introduced this problem.
This one was easy, there is just one cset for this file prior to this
fix, so:
Fixes: ffd3d18c20b8 ("perf tools: Add ARM Statistical Profiling Extensions
(SPE) support")
- Arnaldo
Re: [PATCH] perf tools: arm-spe: Fix uninitialized record error variable
Em Mon, Aug 13, 2018 at 03:55:11PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Aug 10, 2018 at 05:45:12PM -0500, Kim Phillips escreveu:
> > The auxtrace init variable 'err' was not being initialized, leading
> > perf to abort early in an SPE record command when there was no explicit
> > error, rather only based whatever memory contents were on the stack.
> > Initialize it explicitly on getting an SPE successfully, the same way
> > cs-etm does.
> >
> > Signed-off-by: Kim Phillips
> > ---
> > Hi Arnaldo, please apply to perf/urgent / stable series if at all
> > possible. Thank you.
>
> In such cases the best thing is to have a "Fixes: ..." so that this gets
> automatically picked by the stabe trees, I'll try to find out what was
> the patch that introduced this problem.
This one was easy, there is just one cset for this file prior to this
fix, so:
Fixes: ffd3d18c20b8 ("perf tools: Add ARM Statistical Profiling Extensions
(SPE) support")
- Arnaldo
Re: [PATCH] perf tools: arm-spe: Fix uninitialized record error variable
Em Fri, Aug 10, 2018 at 05:45:12PM -0500, Kim Phillips escreveu: > The auxtrace init variable 'err' was not being initialized, leading > perf to abort early in an SPE record command when there was no explicit > error, rather only based whatever memory contents were on the stack. > Initialize it explicitly on getting an SPE successfully, the same way > cs-etm does. > > Signed-off-by: Kim Phillips > --- > Hi Arnaldo, please apply to perf/urgent / stable series if at all > possible. Thank you. In such cases the best thing is to have a "Fixes: ..." so that this gets automatically picked by the stabe trees, I'll try to find out what was the patch that introduced this problem. - Arnaldo
Re: [PATCH] perf tools: arm-spe: Fix uninitialized record error variable
Em Fri, Aug 10, 2018 at 05:45:12PM -0500, Kim Phillips escreveu: > The auxtrace init variable 'err' was not being initialized, leading > perf to abort early in an SPE record command when there was no explicit > error, rather only based whatever memory contents were on the stack. > Initialize it explicitly on getting an SPE successfully, the same way > cs-etm does. > > Signed-off-by: Kim Phillips > --- > Hi Arnaldo, please apply to perf/urgent / stable series if at all > possible. Thank you. In such cases the best thing is to have a "Fixes: ..." so that this gets automatically picked by the stabe trees, I'll try to find out what was the patch that introduced this problem. - Arnaldo
