Re: [PATCH] perf trace: remove redundant ')'

[Du, Changbin]

On Tue, Apr 03, 2018 at 04:19:07PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 28, 2018 at 03:26:31PM +0800, Du, Changbin escreveu:
> > Hi Arnaldo,
> > Just a kind reminder. Hope you didn't forget this.
> 
> Ok, applied.
> 
> - Arnaldo
>  
Got it, thanks!

Re: [PATCH] perf trace: remove redundant ')'

[Du, Changbin]

On Tue, Apr 03, 2018 at 04:19:07PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Wed, Mar 28, 2018 at 03:26:31PM +0800, Du, Changbin escreveu:
> > Hi Arnaldo,
> > Just a kind reminder. Hope you didn't forget this.
> 
> Ok, applied.
> 
> - Arnaldo
>  
Got it, thanks!

Re: [PATCH] perf trace: remove redundant ')'

[Arnaldo Carvalho de Melo]

Em Wed, Mar 28, 2018 at 03:26:31PM +0800, Du, Changbin escreveu:
> Hi Arnaldo,
> Just a kind reminder. Hope you didn't forget this.

Ok, applied.

- Arnaldo
 
> On Fri, Mar 16, 2018 at 09:50:45AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> > > Hi Arnaldo, How about this simple one? Thanks.
> > > 
> > > On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin...@intel.com wrote:
> > > > From: Changbin Du 
> > > > 
> > > > There is a redundant ')' at the tail of each event. So remove it.
> > > > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > > >899.342 kmem:kfree:(vfs_writev+0xb9) call_site=9c453979 
> > > > ptr=(nil))
> > > >899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=9c9b8b88 
> > > > ptr=(nil))
> > > > 
> > > > Signed-off-by: Changbin Du 
> > > > ---
> > > >  tools/perf/builtin-trace.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > > > index e7f1b18..7273f5f 100644
> > > > --- a/tools/perf/builtin-trace.c
> > > > +++ b/tools/perf/builtin-trace.c
> > > > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace 
> > > > *trace, struct perf_evsel *evsel,
> > > >   trace->output);
> > > > }
> > > >  
> > > > -   fprintf(trace->output, ")\n");
> > > > +   fprintf(trace->output, "\n");
> > 
> > It looks simple on the surface, but I couldn't quickly recall why this
> > ')' was put there in the first place... So I left for later to do a 'git
> > blame' on this file, etc.
> > 
> > - Arnaldo
> > 
> > > > if (callchain_ret > 0)
> > > > trace__fprintf_callchain(trace, sample);
> > > > -- 
> > > > 2.7.4
> > > > 
> > > 
> > > -- 
> > > Thanks,
> > > Changbin Du
> 
> -- 
> Thanks,
> Changbin Du

Re: [PATCH] perf trace: remove redundant ')'

[Arnaldo Carvalho de Melo]

Em Wed, Mar 28, 2018 at 03:26:31PM +0800, Du, Changbin escreveu:
> Hi Arnaldo,
> Just a kind reminder. Hope you didn't forget this.

Ok, applied.

- Arnaldo
 
> On Fri, Mar 16, 2018 at 09:50:45AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> > > Hi Arnaldo, How about this simple one? Thanks.
> > > 
> > > On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin...@intel.com wrote:
> > > > From: Changbin Du 
> > > > 
> > > > There is a redundant ')' at the tail of each event. So remove it.
> > > > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > > >899.342 kmem:kfree:(vfs_writev+0xb9) call_site=9c453979 
> > > > ptr=(nil))
> > > >899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=9c9b8b88 
> > > > ptr=(nil))
> > > > 
> > > > Signed-off-by: Changbin Du 
> > > > ---
> > > >  tools/perf/builtin-trace.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > > > index e7f1b18..7273f5f 100644
> > > > --- a/tools/perf/builtin-trace.c
> > > > +++ b/tools/perf/builtin-trace.c
> > > > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace 
> > > > *trace, struct perf_evsel *evsel,
> > > >   trace->output);
> > > > }
> > > >  
> > > > -   fprintf(trace->output, ")\n");
> > > > +   fprintf(trace->output, "\n");
> > 
> > It looks simple on the surface, but I couldn't quickly recall why this
> > ')' was put there in the first place... So I left for later to do a 'git
> > blame' on this file, etc.
> > 
> > - Arnaldo
> > 
> > > > if (callchain_ret > 0)
> > > > trace__fprintf_callchain(trace, sample);
> > > > -- 
> > > > 2.7.4
> > > > 
> > > 
> > > -- 
> > > Thanks,
> > > Changbin Du
> 
> -- 
> Thanks,
> Changbin Du

Re: [PATCH] perf trace: remove redundant ')'

[Du, Changbin]

Hi Arnaldo,
Just a kind reminder. Hope you didn't forget this.

On Fri, Mar 16, 2018 at 09:50:45AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> > Hi Arnaldo, How about this simple one? Thanks.
> > 
> > On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin...@intel.com wrote:
> > > From: Changbin Du 
> > > 
> > > There is a redundant ')' at the tail of each event. So remove it.
> > > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > >899.342 kmem:kfree:(vfs_writev+0xb9) call_site=9c453979 
> > > ptr=(nil))
> > >899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=9c9b8b88 
> > > ptr=(nil))
> > > 
> > > Signed-off-by: Changbin Du 
> > > ---
> > >  tools/perf/builtin-trace.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > > index e7f1b18..7273f5f 100644
> > > --- a/tools/perf/builtin-trace.c
> > > +++ b/tools/perf/builtin-trace.c
> > > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace 
> > > *trace, struct perf_evsel *evsel,
> > > trace->output);
> > >   }
> > >  
> > > - fprintf(trace->output, ")\n");
> > > + fprintf(trace->output, "\n");
> 
> It looks simple on the surface, but I couldn't quickly recall why this
> ')' was put there in the first place... So I left for later to do a 'git
> blame' on this file, etc.
> 
> - Arnaldo
> 
> > >   if (callchain_ret > 0)
> > >   trace__fprintf_callchain(trace, sample);
> > > -- 
> > > 2.7.4
> > > 
> > 
> > -- 
> > Thanks,
> > Changbin Du

-- 
Thanks,
Changbin Du

Re: [PATCH] perf trace: remove redundant ')'

[Du, Changbin]

Hi Arnaldo,
Just a kind reminder. Hope you didn't forget this.

On Fri, Mar 16, 2018 at 09:50:45AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> > Hi Arnaldo, How about this simple one? Thanks.
> > 
> > On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin...@intel.com wrote:
> > > From: Changbin Du 
> > > 
> > > There is a redundant ')' at the tail of each event. So remove it.
> > > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> > >899.342 kmem:kfree:(vfs_writev+0xb9) call_site=9c453979 
> > > ptr=(nil))
> > >899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=9c9b8b88 
> > > ptr=(nil))
> > > 
> > > Signed-off-by: Changbin Du 
> > > ---
> > >  tools/perf/builtin-trace.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > > index e7f1b18..7273f5f 100644
> > > --- a/tools/perf/builtin-trace.c
> > > +++ b/tools/perf/builtin-trace.c
> > > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace 
> > > *trace, struct perf_evsel *evsel,
> > > trace->output);
> > >   }
> > >  
> > > - fprintf(trace->output, ")\n");
> > > + fprintf(trace->output, "\n");
> 
> It looks simple on the surface, but I couldn't quickly recall why this
> ')' was put there in the first place... So I left for later to do a 'git
> blame' on this file, etc.
> 
> - Arnaldo
> 
> > >   if (callchain_ret > 0)
> > >   trace__fprintf_callchain(trace, sample);
> > > -- 
> > > 2.7.4
> > > 
> > 
> > -- 
> > Thanks,
> > Changbin Du

-- 
Thanks,
Changbin Du

Re: [PATCH] perf trace: remove redundant ')'

[Arnaldo Carvalho de Melo]

Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> Hi Arnaldo, How about this simple one? Thanks.
> 
> On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin...@intel.com wrote:
> > From: Changbin Du 
> > 
> > There is a redundant ')' at the tail of each event. So remove it.
> > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> >899.342 kmem:kfree:(vfs_writev+0xb9) call_site=9c453979 
> > ptr=(nil))
> >899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=9c9b8b88 
> > ptr=(nil))
> > 
> > Signed-off-by: Changbin Du 
> > ---
> >  tools/perf/builtin-trace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > index e7f1b18..7273f5f 100644
> > --- a/tools/perf/builtin-trace.c
> > +++ b/tools/perf/builtin-trace.c
> > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, 
> > struct perf_evsel *evsel,
> >   trace->output);
> > }
> >  
> > -   fprintf(trace->output, ")\n");
> > +   fprintf(trace->output, "\n");

It looks simple on the surface, but I couldn't quickly recall why this
')' was put there in the first place... So I left for later to do a 'git
blame' on this file, etc.

- Arnaldo

> > if (callchain_ret > 0)
> > trace__fprintf_callchain(trace, sample);
> > -- 
> > 2.7.4
> > 
> 
> -- 
> Thanks,
> Changbin Du

Re: [PATCH] perf trace: remove redundant ')'

[Arnaldo Carvalho de Melo]

Em Fri, Mar 16, 2018 at 03:51:09PM +0800, Du, Changbin escreveu:
> Hi Arnaldo, How about this simple one? Thanks.
> 
> On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin...@intel.com wrote:
> > From: Changbin Du 
> > 
> > There is a redundant ')' at the tail of each event. So remove it.
> > $ sudo perf trace --no-syscalls -e 'kmem:*' -a
> >899.342 kmem:kfree:(vfs_writev+0xb9) call_site=9c453979 
> > ptr=(nil))
> >899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=9c9b8b88 
> > ptr=(nil))
> > 
> > Signed-off-by: Changbin Du 
> > ---
> >  tools/perf/builtin-trace.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> > index e7f1b18..7273f5f 100644
> > --- a/tools/perf/builtin-trace.c
> > +++ b/tools/perf/builtin-trace.c
> > @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, 
> > struct perf_evsel *evsel,
> >   trace->output);
> > }
> >  
> > -   fprintf(trace->output, ")\n");
> > +   fprintf(trace->output, "\n");

It looks simple on the surface, but I couldn't quickly recall why this
')' was put there in the first place... So I left for later to do a 'git
blame' on this file, etc.

- Arnaldo

> > if (callchain_ret > 0)
> > trace__fprintf_callchain(trace, sample);
> > -- 
> > 2.7.4
> > 
> 
> -- 
> Thanks,
> Changbin Du

Re: [PATCH] perf trace: remove redundant ')'

[Du, Changbin]

Hi Arnaldo, How about this simple one? Thanks.

On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin...@intel.com wrote:
> From: Changbin Du 
> 
> There is a redundant ')' at the tail of each event. So remove it.
> $ sudo perf trace --no-syscalls -e 'kmem:*' -a
>899.342 kmem:kfree:(vfs_writev+0xb9) call_site=9c453979 ptr=(nil))
>899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=9c9b8b88 
> ptr=(nil))
> 
> Signed-off-by: Changbin Du 
> ---
>  tools/perf/builtin-trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index e7f1b18..7273f5f 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, 
> struct perf_evsel *evsel,
> trace->output);
>   }
>  
> - fprintf(trace->output, ")\n");
> + fprintf(trace->output, "\n");
>  
>   if (callchain_ret > 0)
>   trace__fprintf_callchain(trace, sample);
> -- 
> 2.7.4
> 

-- 
Thanks,
Changbin Du

Re: [PATCH] perf trace: remove redundant ')'

[Du, Changbin]

Hi Arnaldo, How about this simple one? Thanks.

On Tue, Mar 13, 2018 at 06:40:01PM +0800, changbin...@intel.com wrote:
> From: Changbin Du 
> 
> There is a redundant ')' at the tail of each event. So remove it.
> $ sudo perf trace --no-syscalls -e 'kmem:*' -a
>899.342 kmem:kfree:(vfs_writev+0xb9) call_site=9c453979 ptr=(nil))
>899.344 kmem:kfree:(___sys_recvmsg+0x188) call_site=9c9b8b88 
> ptr=(nil))
> 
> Signed-off-by: Changbin Du 
> ---
>  tools/perf/builtin-trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index e7f1b18..7273f5f 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -1959,7 +1959,7 @@ static int trace__event_handler(struct trace *trace, 
> struct perf_evsel *evsel,
> trace->output);
>   }
>  
> - fprintf(trace->output, ")\n");
> + fprintf(trace->output, "\n");
>  
>   if (callchain_ret > 0)
>   trace__fprintf_callchain(trace, sample);
> -- 
> 2.7.4
> 

-- 
Thanks,
Changbin Du