Re: [PATCH] printk: Remove no longer used console_silent().

2019-03-20 Thread Petr Mladek 
On Mon 2019-03-18 23:34:21, Sergey Senozhatsky wrote:
> On (03/18/19 23:05), Tetsuo Handa wrote:
> > console_silent() is no longer used after the removal of
> > arch/mn10300/kernel/mn10300-watchdog.c in Linux 4.17-rc1.
> 
> [..]
> 
> > -static inline void console_silent(void)
> > -{
> > -   console_loglevel = CONSOLE_LOGLEVEL_SILENT;
> > -}
> 
> I would keep it, I guess, and would instead covert
> 
> kernel/debug/kdb/kdb_io.c:  console_loglevel = 
> CONSOLE_LOGLEVEL_SILENT
> 
> to use proper API (console_silent()).

I agree with Sergey.

Best Regards,
Petr

Re: [PATCH] printk: Remove no longer used console_silent().

2019-03-18 Thread Sergey Senozhatsky 
On (03/18/19 23:05), Tetsuo Handa wrote:
> console_silent() is no longer used after the removal of
> arch/mn10300/kernel/mn10300-watchdog.c in Linux 4.17-rc1.

[..]

> -static inline void console_silent(void)
> -{
> - console_loglevel = CONSOLE_LOGLEVEL_SILENT;
> -}

I would keep it, I guess, and would instead covert

kernel/debug/kdb/kdb_io.c:  console_loglevel = 
CONSOLE_LOGLEVEL_SILENT

to use proper API (console_silent()).

-ss