Re: [PATCH] pwm: fix semicolon.cocci warnings
On 1/28/21 10:57 PM, Uwe Kleine-König wrote:
Hello,
On Thu, Jan 28, 2021 at 09:45:37PM +0800, kernel test robot wrote:
From: kernel test robot
drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: e96c0ff4b1e0 ("pwm: Enable compile testing for some of drivers")
This looks wrong. e96c0ff4b1e0 only touches drivers/pwm/Kconfig.
The ; was introduced by commit 841e6f90bb78 ("pwm: NXP LPC18xx PWM/SCT
driver")
Right, thank you for the correction, Uwe.
Since the patch has been composed by the robot, it has to be fixed
in the first place.
And regarding this particular change and in general fixes to this type
of issues detected by the robot, I don't think that it earns a Fixes tag.
CC: Krzysztof Kozlowski
Reported-by: kernel test robot
Signed-off-by: kernel test robot
--
Best wishes,
Vladimir
Re: [PATCH] pwm: fix semicolon.cocci warnings
Hello,
On Thu, Jan 28, 2021 at 09:45:37PM +0800, kernel test robot wrote:
> From: kernel test robot
>
> drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: e96c0ff4b1e0 ("pwm: Enable compile testing for some of drivers")
This looks wrong. e96c0ff4b1e0 only touches drivers/pwm/Kconfig.
The ; was introduced by commit 841e6f90bb78 ("pwm: NXP LPC18xx PWM/SCT
driver")
Best regards
Uwe
> CC: Krzysztof Kozlowski
> Reported-by: kernel test robot
> Signed-off-by: kernel test robot
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> master
> head: 76c057c84d286140c6c416c3b4ba832cd1d8984e
> commit: e96c0ff4b1e013a4e9174344b0fcda0d566d3689 pwm: Enable compile testing
> for some of drivers
>
> pwm-lpc18xx-sct.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/pwm/pwm-lpc18xx-sct.c
> +++ b/drivers/pwm/pwm-lpc18xx-sct.c
> @@ -289,7 +289,7 @@ static int lpc18xx_pwm_request(struct pw
> dev_err(lpc18xx_pwm->dev,
> "maximum number of simultaneous channels reached\n");
> return -EBUSY;
> - };
> + }
>
> set_bit(event, _pwm->event_map);
> lpc18xx_data->duty_event = event;
>
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
Re: [PATCH] pwm: fix semicolon.cocci warnings
On 1/28/21 3:45 PM, kernel test robot wrote:
From: kernel test robot
drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: e96c0ff4b1e0 ("pwm: Enable compile testing for some of drivers")
CC: Krzysztof Kozlowski
Reported-by: kernel test robot
Signed-off-by: kernel test robot
Acked-by: Vladimir Zapolskiy
--
Best wishes,
Vladimir
