Re: [PATCH] regulator: s5m8767: Disable OVCB in probe
On Wed, Nov 13, 2013 at 10:50 PM, Mark Brown wrote: > On Tue, Nov 12, 2013 at 02:41:55PM +0100, Krzysztof Kozlowski wrote: >> According to SW Guide the Over-Voltage Clamp may malfunction at VBatt >> 5.25V and 110'C temperature. This may result in overshooting or >> undershooting LDO's voltage outputs. >> Disable the Over-Voltage Clamp in probe by updating proper bit in all >> LDO registers. > > Is there no way to detect these conditions at runtime? The temperature > condition in particular seems very high and hence relatively unlikely to > hold most of the time, disabling the overvoltage protection all the time > seems like an uncertain tradeoff. It's hard to do at runtime. right it's rare case. but some condition (as above) is meet, and no code as workaround. it's mal-function. that's the guide to avoid this mal-functions. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] regulator: s5m8767: Disable OVCB in probe
On Tue, Nov 12, 2013 at 02:41:55PM +0100, Krzysztof Kozlowski wrote: > According to SW Guide the Over-Voltage Clamp may malfunction at VBatt > 5.25V and 110'C temperature. This may result in overshooting or > undershooting LDO's voltage outputs. > Disable the Over-Voltage Clamp in probe by updating proper bit in all > LDO registers. Is there no way to detect these conditions at runtime? The temperature condition in particular seems very high and hence relatively unlikely to hold most of the time, disabling the overvoltage protection all the time seems like an uncertain tradeoff. signature.asc Description: Digital signature
Re: [PATCH] regulator: s5m8767: Disable OVCB in probe
On Tue, Nov 12, 2013 at 02:41:55PM +0100, Krzysztof Kozlowski wrote: According to SW Guide the Over-Voltage Clamp may malfunction at VBatt 5.25V and 110'C temperature. This may result in overshooting or undershooting LDO's voltage outputs. Disable the Over-Voltage Clamp in probe by updating proper bit in all LDO registers. Is there no way to detect these conditions at runtime? The temperature condition in particular seems very high and hence relatively unlikely to hold most of the time, disabling the overvoltage protection all the time seems like an uncertain tradeoff. signature.asc Description: Digital signature
Re: [PATCH] regulator: s5m8767: Disable OVCB in probe
On Wed, Nov 13, 2013 at 10:50 PM, Mark Brown broo...@kernel.org wrote: On Tue, Nov 12, 2013 at 02:41:55PM +0100, Krzysztof Kozlowski wrote: According to SW Guide the Over-Voltage Clamp may malfunction at VBatt 5.25V and 110'C temperature. This may result in overshooting or undershooting LDO's voltage outputs. Disable the Over-Voltage Clamp in probe by updating proper bit in all LDO registers. Is there no way to detect these conditions at runtime? The temperature condition in particular seems very high and hence relatively unlikely to hold most of the time, disabling the overvoltage protection all the time seems like an uncertain tradeoff. It's hard to do at runtime. right it's rare case. but some condition (as above) is meet, and no code as workaround. it's mal-function. that's the guide to avoid this mal-functions. Thank you, Kyungmin Park -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] regulator: s5m8767: Disable OVCB in probe
On Tue, 12 Nov 2013, Krzysztof Kozlowski wrote: > According to SW Guide the Over-Voltage Clamp may malfunction at VBatt > 5.25V and 110'C temperature. This may result in overshooting or > undershooting LDO's voltage outputs. > Disable the Over-Voltage Clamp in probe by updating proper bit in all > LDO registers. > > The patch uses sec_bulk_read/write() API with reordered buf and count > parameters so it depends on: > "mfd: sec: reorder params in API for regmap consistency" > http://www.spinics.net/lists/kernel/msg1632519.html > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kyungmin Park > --- > drivers/regulator/s5m8767.c | 26 ++ > include/linux/mfd/samsung/s5m8767.h |1 + > 2 files changed, 27 insertions(+) For the MFD change: Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] regulator: s5m8767: Disable OVCB in probe
On Tue, 12 Nov 2013, Krzysztof Kozlowski wrote: According to SW Guide the Over-Voltage Clamp may malfunction at VBatt 5.25V and 110'C temperature. This may result in overshooting or undershooting LDO's voltage outputs. Disable the Over-Voltage Clamp in probe by updating proper bit in all LDO registers. The patch uses sec_bulk_read/write() API with reordered buf and count parameters so it depends on: mfd: sec: reorder params in API for regmap consistency http://www.spinics.net/lists/kernel/msg1632519.html Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/regulator/s5m8767.c | 26 ++ include/linux/mfd/samsung/s5m8767.h |1 + 2 files changed, 27 insertions(+) For the MFD change: Acked-by: Lee Jones lee.jo...@linaro.org -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
