Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On 2015-05-06 15:54, sylvain.bertr...@gmail.com wrote: > On Mon, Apr 27, 2015 at 03:25:25PM +, sylvain.bertr...@gmail.com wrote: >> On Tue, Mar 17, 2015 at 09:59:13PM +0100, Michal Marek wrote: >>> Sorry if I wasn't clear. The changelog should contain the actual error >>> message or description of wrong behavior when ran under dash. >> >> While building linux with dash shell: >> LINKvmlinux >> trap: SIGHUP: bad trap >> /src/linux-4.0/Makefile:933: recipe for target 'vmlinux' failed >> make[1]: *** [vmlinux] Error 1 > > Hi, what's up with this? Please post a v2 with a complete changelog. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On Mon, Apr 27, 2015 at 03:25:25PM +, sylvain.bertr...@gmail.com wrote: > On Tue, Mar 17, 2015 at 09:59:13PM +0100, Michal Marek wrote: > > Sorry if I wasn't clear. The changelog should contain the actual error > > message or description of wrong behavior when ran under dash. > > While building linux with dash shell: > LINKvmlinux > trap: SIGHUP: bad trap > /src/linux-4.0/Makefile:933: recipe for target 'vmlinux' failed > make[1]: *** [vmlinux] Error 1 Hi, what's up with this? regards, -- Sylvain -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On Mon, Apr 27, 2015 at 03:25:25PM +, sylvain.bertr...@gmail.com wrote: On Tue, Mar 17, 2015 at 09:59:13PM +0100, Michal Marek wrote: Sorry if I wasn't clear. The changelog should contain the actual error message or description of wrong behavior when ran under dash. While building linux with dash shell: LINKvmlinux trap: SIGHUP: bad trap /src/linux-4.0/Makefile:933: recipe for target 'vmlinux' failed make[1]: *** [vmlinux] Error 1 Hi, what's up with this? regards, -- Sylvain -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On 2015-05-06 15:54, sylvain.bertr...@gmail.com wrote: On Mon, Apr 27, 2015 at 03:25:25PM +, sylvain.bertr...@gmail.com wrote: On Tue, Mar 17, 2015 at 09:59:13PM +0100, Michal Marek wrote: Sorry if I wasn't clear. The changelog should contain the actual error message or description of wrong behavior when ran under dash. While building linux with dash shell: LINKvmlinux trap: SIGHUP: bad trap /src/linux-4.0/Makefile:933: recipe for target 'vmlinux' failed make[1]: *** [vmlinux] Error 1 Hi, what's up with this? Please post a v2 with a complete changelog. Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On Tue, Mar 17, 2015 at 09:59:13PM +0100, Michal Marek wrote: > Sorry if I wasn't clear. The changelog should contain the actual error > message or description of wrong behavior when ran under dash. While building linux with dash shell: LINKvmlinux trap: SIGHUP: bad trap /src/linux-4.0/Makefile:933: recipe for target 'vmlinux' failed make[1]: *** [vmlinux] Error 1 -- Sylvain -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On Tue, Mar 17, 2015 at 09:59:13PM +0100, Michal Marek wrote: Sorry if I wasn't clear. The changelog should contain the actual error message or description of wrong behavior when ran under dash. While building linux with dash shell: LINKvmlinux trap: SIGHUP: bad trap /src/linux-4.0/Makefile:933: recipe for target 'vmlinux' failed make[1]: *** [vmlinux] Error 1 -- Sylvain -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
Dne 3.3.2015 v 17:34 Sylvain BERTRAND napsal(a): > On Fri, Jan 02, 2015 at 04:55:42PM +0100, Michal Marek wrote: >> On 2014-12-29 17:34, Sylvain BERTRAND wrote: >>> Chocked while compiling linux with dash shell instead of bash shell. >>> See: >>> http://pubs.opengroup.org/onlinepubs/95399/utilities/trap.html >> >> Please describe the actual problem in the changelog. I guess it's >> because of the 'ERR' trap? > > Indeed: > - ERR is specific to bash > - signal names in a trap built-in instruction should be without the SIG > prefix > > Shall I repost a v2 with the above lines? Sorry if I wasn't clear. The changelog should contain the actual error message or description of wrong behavior when ran under dash. Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
Dne 3.3.2015 v 17:34 Sylvain BERTRAND napsal(a): On Fri, Jan 02, 2015 at 04:55:42PM +0100, Michal Marek wrote: On 2014-12-29 17:34, Sylvain BERTRAND wrote: Chocked while compiling linux with dash shell instead of bash shell. See: http://pubs.opengroup.org/onlinepubs/95399/utilities/trap.html Please describe the actual problem in the changelog. I guess it's because of the 'ERR' trap? Indeed: - ERR is specific to bash - signal names in a trap built-in instruction should be without the SIG prefix Shall I repost a v2 with the above lines? Sorry if I wasn't clear. The changelog should contain the actual error message or description of wrong behavior when ran under dash. Michal -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On Fri, Jan 02, 2015 at 04:55:42PM +0100, Michal Marek wrote: > On 2014-12-29 17:34, Sylvain BERTRAND wrote: > > Chocked while compiling linux with dash shell instead of bash shell. > > See: > > http://pubs.opengroup.org/onlinepubs/95399/utilities/trap.html > > Please describe the actual problem in the changelog. I guess it's > because of the 'ERR' trap? Indeed: - ERR is specific to bash - signal names in a trap built-in instruction should be without the SIG prefix Shall I repost a v2 with the above lines? -- Sylvain -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On Fri, Jan 02, 2015 at 04:55:42PM +0100, Michal Marek wrote: On 2014-12-29 17:34, Sylvain BERTRAND wrote: Chocked while compiling linux with dash shell instead of bash shell. See: http://pubs.opengroup.org/onlinepubs/95399/utilities/trap.html Please describe the actual problem in the changelog. I guess it's because of the 'ERR' trap? Indeed: - ERR is specific to bash - signal names in a trap built-in instruction should be without the SIG prefix Shall I repost a v2 with the above lines? -- Sylvain -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On 2014-12-29 17:34, Sylvain BERTRAND wrote:
> Chocked while compiling linux with dash shell instead of bash shell.
> See:
> http://pubs.opengroup.org/onlinepubs/95399/utilities/trap.html
Please describe the actual problem in the changelog. I guess it's
because of the 'ERR' trap?
> Cc: Ingo Molnar
> Signed-off-by: Sylvain BERTRAND
> ---
> --- a/scripts/link-vmlinux.sh 2014-12-29 15:10:29.436431249 +
> +++ b/scripts/link-vmlinux.sh 2014-12-29 16:23:06.010853608 +
> @@ -111,7 +111,6 @@
> }
>
> # Delete output files in case of error
> -trap cleanup SIGHUP SIGINT SIGQUIT SIGTERM ERR
> cleanup()
> {
> rm -f .old_version
> @@ -124,6 +123,20 @@
> rm -f vmlinux.o
> }
>
> +on_exit()
> +{
> + if [ $? -ne 0 ]; then
> + cleanup
> + fi
> +}
> +trap on_exit EXIT
> +
> +on_signals()
> +{
> + exit 1
> +}
> +trap on_signals HUP INT QUIT TERM
Why not use 'cleanup' directly as a handler?
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts: fix link-vmlinux.sh bash-ism
On 2014-12-29 17:34, Sylvain BERTRAND wrote:
Chocked while compiling linux with dash shell instead of bash shell.
See:
http://pubs.opengroup.org/onlinepubs/95399/utilities/trap.html
Please describe the actual problem in the changelog. I guess it's
because of the 'ERR' trap?
Cc: Ingo Molnar mi...@kernel.org
Signed-off-by: Sylvain BERTRAND sylvain.bertr...@gmail.com
---
--- a/scripts/link-vmlinux.sh 2014-12-29 15:10:29.436431249 +
+++ b/scripts/link-vmlinux.sh 2014-12-29 16:23:06.010853608 +
@@ -111,7 +111,6 @@
}
# Delete output files in case of error
-trap cleanup SIGHUP SIGINT SIGQUIT SIGTERM ERR
cleanup()
{
rm -f .old_version
@@ -124,6 +123,20 @@
rm -f vmlinux.o
}
+on_exit()
+{
+ if [ $? -ne 0 ]; then
+ cleanup
+ fi
+}
+trap on_exit EXIT
+
+on_signals()
+{
+ exit 1
+}
+trap on_signals HUP INT QUIT TERM
Why not use 'cleanup' directly as a handler?
Michal
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
