Re: [PATCH] sh: Fix build error caused by missing dependencies
Hi Pranith,
On Tue, Sep 2, 2014 at 4:39 PM, Pranith Kumar wrote:
> Fix a sh4-randconfig build failure which has the following splat:
>
> arch/sh/mm/cache-sh4.c:99:17: error: 'cached_to_uncached' undeclared (first
> use in this function)
> arch/sh/mm/cache-sh4.c:192:2: error: implicit declaration of function
> 'cpu_context' [-Werror=implicit-function-declaration]
>
> These errors are caused by missing dependencies on UNCACHED_MAPPING and MMU.
>
> Reported-by: Geert Uytterhoeven
> Signed-off-by: Pranith Kumar
> ---
> arch/sh/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 244fb4c..619d5eb 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -194,6 +194,8 @@ config CPU_SH4
> select SH_INTC
> select SYS_SUPPORTS_SH_TMU
> select SYS_SUPPORTS_HUGETLBFS if MMU
> + select UNCACHED_MAPPING
> + select MMU
Selecting MMU is never the correct solution, as it's a platform feature.
Making something depend on MMU is something different, but I doubt
SH4 can only work with a MMU, cfr. the "if MMU" in the line above.
Back to the drawing board...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] sh: Fix build error caused by missing dependencies
Hi Pranith,
On Tue, Sep 2, 2014 at 4:39 PM, Pranith Kumar bobby.pr...@gmail.com wrote:
Fix a sh4-randconfig build failure which has the following splat:
arch/sh/mm/cache-sh4.c:99:17: error: 'cached_to_uncached' undeclared (first
use in this function)
arch/sh/mm/cache-sh4.c:192:2: error: implicit declaration of function
'cpu_context' [-Werror=implicit-function-declaration]
These errors are caused by missing dependencies on UNCACHED_MAPPING and MMU.
Reported-by: Geert Uytterhoeven ge...@linux-m68k.org
Signed-off-by: Pranith Kumar bobby.pr...@gmail.com
---
arch/sh/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
index 244fb4c..619d5eb 100644
--- a/arch/sh/Kconfig
+++ b/arch/sh/Kconfig
@@ -194,6 +194,8 @@ config CPU_SH4
select SH_INTC
select SYS_SUPPORTS_SH_TMU
select SYS_SUPPORTS_HUGETLBFS if MMU
+ select UNCACHED_MAPPING
+ select MMU
Selecting MMU is never the correct solution, as it's a platform feature.
Making something depend on MMU is something different, but I doubt
SH4 can only work with a MMU, cfr. the if MMU in the line above.
Back to the drawing board...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say programmer or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
