Re: [PATCH] tty: 8250_of: Use software emulated RS485 direction control
On Fri, Sep 13, 2019 at 04:51:30PM +0200, Heiko Schocher wrote: > Am 13.09.2019 um 12:24 schrieb Andy Shevchenko: > > On Fri, Sep 13, 2019 at 07:01:05AM +0200, Heiko Schocher wrote: > > > Patch is based on: > > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > > commit: > > > 505a8ec7e11a - Revert "drm/i915/userptr: Acquire the page lock around > > > set_page_dirty()" > > > > More reliably is to base on corresponding subsystem tree, i.e. tty-next for > > this case. > > Ok, should I send a rebased v2 (I tend to wait for other comments)? I didn't give any comments WRT patch itself, so, I don't see any needs to send v2 right now. -- With Best Regards, Andy Shevchenko
Re: [PATCH] tty: 8250_of: Use software emulated RS485 direction control
Hello Andy, Am 13.09.2019 um 12:24 schrieb Andy Shevchenko: On Fri, Sep 13, 2019 at 07:01:05AM +0200, Heiko Schocher wrote: Use software emulated RS485 direction control to provide RS485 API Currently it is not possible to use rs485 as pointer to rs485_config struct in struct uart_port is NULL in case we configure the port through device tree. Thank you for the patch, few recommendations for the future submissions. Patch is based on: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit: 505a8ec7e11a - Revert "drm/i915/userptr: Acquire the page lock around set_page_dirty()" More reliably is to base on corresponding subsystem tree, i.e. tty-next for this case. Ok, should I send a rebased v2 (I tend to wait for other comments)? checkpatch output: $ ./scripts/checkpatch.pl 0001-tty-8250_of-Use-software-emulated-RS485-direction-co.patch total: 0 errors, 0 warnings, 43 lines checked 0001-tty-8250_of-Use-software-emulated-RS485-direction-co.patch has no obvious style problems and is ready for submission. There is no need to mention this. It's supposed that submitter did that themselves. Hmm... ok. When you gather people to send the patch to, I recommend to use some threshold, e.g. `scripts/get_maintainer.pl --git --git-min-percent=67 ...` Ah, good tip, thanks! bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
Re: [PATCH] tty: 8250_of: Use software emulated RS485 direction control
On Fri, Sep 13, 2019 at 07:01:05AM +0200, Heiko Schocher wrote: > Use software emulated RS485 direction control to provide RS485 API > > Currently it is not possible to use rs485 as pointer to > rs485_config struct in struct uart_port is NULL in case we > configure the port through device tree. Thank you for the patch, few recommendations for the future submissions. > Patch is based on: > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > commit: > 505a8ec7e11a - Revert "drm/i915/userptr: Acquire the page lock around > set_page_dirty()" More reliably is to base on corresponding subsystem tree, i.e. tty-next for this case. > checkpatch output: > $ ./scripts/checkpatch.pl > 0001-tty-8250_of-Use-software-emulated-RS485-direction-co.patch > total: 0 errors, 0 warnings, 43 lines checked > > 0001-tty-8250_of-Use-software-emulated-RS485-direction-co.patch has no > obvious style problems and is ready for submission. There is no need to mention this. It's supposed that submitter did that themselves. When you gather people to send the patch to, I recommend to use some threshold, e.g. `scripts/get_maintainer.pl --git --git-min-percent=67 ...` -- With Best Regards, Andy Shevchenko
