Re: [PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths
On Sun, Oct 12, 2014 at 11:59:58AM -0500, Eric Biggers wrote: > The following pairs of system calls dealing with extended attributes only > differ in their behavior on whether the symbolic link is followed (when > the named file is a symbolic link): > > - setxattr() and lsetxattr() > - getxattr() and lgetxattr() > - listxattr() and llistxattr() > - removexattr() and lremovexattr() > > Despite this, the implementations all had duplicated code, so this commit > redirects each of the above pairs of system calls to a corresponding > function to which different lookup flags (LOOKUP_FOLLOW or 0) are passed. > > For me this reduced the stripped size of xattr.o from 8824 to 8248 bytes. Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths
On Sun, Oct 12, 2014 at 11:59:58AM -0500, Eric Biggers wrote: The following pairs of system calls dealing with extended attributes only differ in their behavior on whether the symbolic link is followed (when the named file is a symbolic link): - setxattr() and lsetxattr() - getxattr() and lgetxattr() - listxattr() and llistxattr() - removexattr() and lremovexattr() Despite this, the implementations all had duplicated code, so this commit redirects each of the above pairs of system calls to a corresponding function to which different lookup flags (LOOKUP_FOLLOW or 0) are passed. For me this reduced the stripped size of xattr.o from 8824 to 8248 bytes. Looks good, Reviewed-by: Christoph Hellwig h...@lst.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] vfs: Deduplicate code shared by xattr system calls operating on paths
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/