Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
On Sat, Feb 16, 2019 at 04:15:28PM +0100, Aurelien Jarno wrote: > On 2019-01-12 20:07, Aurelien Jarno wrote: > > On 2018-12-06 20:05, Aurelien Jarno wrote: > > > The preadv2 and pwritev2 syscalls are supposed to emulate the readv and > > > writev syscalls when offset == -1. Therefore the compat code should > > > check for offset before calling do_compat_preadv64 and > > > do_compat_pwritev64. This is the case for the preadv2 and pwritev2 > > > syscalls, but handling of offset == -1 is missing in their 64-bit > > > equivalent. > > > > > > This patch fixes that, calling do_compat_readv and do_compat_writev when > > > offset == -1. This fixes the following glibc tests on x32: > > > - misc/tst-preadvwritev2 > > > - misc/tst-preadvwritev64v2 > > > > > > Cc: Alexander Viro > > > Cc: H.J. Lu > > > Signed-off-by: Aurelien Jarno > > > --- > > > fs/read_write.c | 6 ++ > > > 1 file changed, 6 insertions(+) > > > > Any news about this patch? > > > > Ping. Applied
Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
On 2019-01-12 20:07, Aurelien Jarno wrote: > On 2018-12-06 20:05, Aurelien Jarno wrote: > > The preadv2 and pwritev2 syscalls are supposed to emulate the readv and > > writev syscalls when offset == -1. Therefore the compat code should > > check for offset before calling do_compat_preadv64 and > > do_compat_pwritev64. This is the case for the preadv2 and pwritev2 > > syscalls, but handling of offset == -1 is missing in their 64-bit > > equivalent. > > > > This patch fixes that, calling do_compat_readv and do_compat_writev when > > offset == -1. This fixes the following glibc tests on x32: > > - misc/tst-preadvwritev2 > > - misc/tst-preadvwritev64v2 > > > > Cc: Alexander Viro > > Cc: H.J. Lu > > Signed-off-by: Aurelien Jarno > > --- > > fs/read_write.c | 6 ++ > > 1 file changed, 6 insertions(+) > > Any news about this patch? > Ping. Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
Re: [PATCH] vfs: fix preadv64v2 and pwritev64v2 compat syscalls with offset == -1
On 2018-12-06 20:05, Aurelien Jarno wrote: > The preadv2 and pwritev2 syscalls are supposed to emulate the readv and > writev syscalls when offset == -1. Therefore the compat code should > check for offset before calling do_compat_preadv64 and > do_compat_pwritev64. This is the case for the preadv2 and pwritev2 > syscalls, but handling of offset == -1 is missing in their 64-bit > equivalent. > > This patch fixes that, calling do_compat_readv and do_compat_writev when > offset == -1. This fixes the following glibc tests on x32: > - misc/tst-preadvwritev2 > - misc/tst-preadvwritev64v2 > > Cc: Alexander Viro > Cc: H.J. Lu > Signed-off-by: Aurelien Jarno > --- > fs/read_write.c | 6 ++ > 1 file changed, 6 insertions(+) Any news about this patch? Thanks, Aurelien -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
