Re: [PATCH] x86: include: asm: Fix build warning

[Borislav Petkov]

On Tue, Sep 29, 2015 at 07:19:32PM +0200, Ksenija Stanojević wrote:
> On Tue, Sep 29, 2015 at 7:16 PM, Borislav Petkov  wrote:
> > On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote:
> >> when building with:
> >> make drivers/staging/oplc_dcon/olpc_dcon.o
> >> I get this warnings.
> >
> > Yeah, you can't pick out single files from the source tree and try to
> > build them and expect that to always work. That olpc_dcon think depends
> > on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have
> > enabled CONFIG_OLPC first.
> >
> Ok, thanks!

Sure, no probs.

Btw, if you really want to try to fix some bugs, you could try to build
the kernel with

make -j W=n 2>build-warnings.log

where n is 1, 2 or 3 (or any subset of those) and try to analyze them.

Look at the output in build-warnings.log and try to understand why the
compiler is complaining and whether it makes sense.

Some of them might be worth fixing. Most of them are bogus and/or fixing
them would require just too much code changes for no real gain but some
of the warnings do make sense.

Also, you could do

make allmodconfig

before that so that you can build *everything* and catch all warnings.

HTH.

-- 
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[Ksenija Stanojević]

On Tue, Sep 29, 2015 at 7:16 PM, Borislav Petkov  wrote:
> On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote:
>> when building with:
>> make drivers/staging/oplc_dcon/olpc_dcon.o
>> I get this warnings.
>
> Yeah, you can't pick out single files from the source tree and try to
> build them and expect that to always work. That olpc_dcon think depends
> on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have
> enabled CONFIG_OLPC first.
>
Ok, thanks!

Ksenija
> --
> Regards/Gruss,
> Boris.
>
> ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[Borislav Petkov]

On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote:
> when building with:
> make drivers/staging/oplc_dcon/olpc_dcon.o
> I get this warnings.

Yeah, you can't pick out single files from the source tree and try to
build them and expect that to always work. That olpc_dcon think depends
on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have
enabled CONFIG_OLPC first.

-- 
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[Ksenija Stanojević]

Hi,

On Tue, Sep 29, 2015 at 7:08 PM, H. Peter Anvin  wrote:
> On 09/29/2015 10:06 AM, Borislav Petkov wrote:
>> On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
>>> Fix build warnings:
>>>
>>> error: implicit declaration of function ‘olpc_board_at_least’
>>> [-Werror=implicit-function-declaration]
>>>
>>>  error: implicit declaration of function ‘olpc_board’
>>> [-Werror=implicit-function-declaration]
>>
>> How exactly do you trigger that?

when building with:
make drivers/staging/oplc_dcon/olpc_dcon.o
I get this warnings.

>>
>>> in files:
>>> drivers/power/olpc_battery.c
>>> drivers/input/mouse/hgpk.c
>>> drivers/staging/olpc_dcon/olpc_dcon.c
>>> arch/x86/platform/olpc/olpc.c
>>> sound/pci/cs5535audio/cs5535audio_olpc.c
>>
>> AFAICT, those should all depend on CONFIG_OLPC which defines those
>> functions...
>>
>
> It wouldn't be entirely impossible if OLPC has bitrotted.  This is one
> of the many problems with nonstandard hardware.
>
> -hpa
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[H. Peter Anvin]

On 09/29/2015 10:06 AM, Borislav Petkov wrote:
> On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
>> Fix build warnings:
>>
>> error: implicit declaration of function ‘olpc_board_at_least’
>> [-Werror=implicit-function-declaration]
>>
>>  error: implicit declaration of function ‘olpc_board’
>> [-Werror=implicit-function-declaration]
> 
> How exactly do you trigger that?
> 
>> in files:
>> drivers/power/olpc_battery.c
>> drivers/input/mouse/hgpk.c
>> drivers/staging/olpc_dcon/olpc_dcon.c
>> arch/x86/platform/olpc/olpc.c
>> sound/pci/cs5535audio/cs5535audio_olpc.c
> 
> AFAICT, those should all depend on CONFIG_OLPC which defines those
> functions...
> 

It wouldn't be entirely impossible if OLPC has bitrotted.  This is one
of the many problems with nonstandard hardware.

-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[Borislav Petkov]

On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
> Fix build warnings:
> 
> error: implicit declaration of function ‘olpc_board_at_least’
> [-Werror=implicit-function-declaration]
> 
>  error: implicit declaration of function ‘olpc_board’
> [-Werror=implicit-function-declaration]

How exactly do you trigger that?

> in files:
> drivers/power/olpc_battery.c
> drivers/input/mouse/hgpk.c
> drivers/staging/olpc_dcon/olpc_dcon.c
> arch/x86/platform/olpc/olpc.c
> sound/pci/cs5535audio/cs5535audio_olpc.c

AFAICT, those should all depend on CONFIG_OLPC which defines those
functions...

Thanks.

-- 
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[H. Peter Anvin]

On 09/29/2015 10:06 AM, Borislav Petkov wrote:
> On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
>> Fix build warnings:
>>
>> error: implicit declaration of function ‘olpc_board_at_least’
>> [-Werror=implicit-function-declaration]
>>
>>  error: implicit declaration of function ‘olpc_board’
>> [-Werror=implicit-function-declaration]
> 
> How exactly do you trigger that?
> 
>> in files:
>> drivers/power/olpc_battery.c
>> drivers/input/mouse/hgpk.c
>> drivers/staging/olpc_dcon/olpc_dcon.c
>> arch/x86/platform/olpc/olpc.c
>> sound/pci/cs5535audio/cs5535audio_olpc.c
> 
> AFAICT, those should all depend on CONFIG_OLPC which defines those
> functions...
> 

It wouldn't be entirely impossible if OLPC has bitrotted.  This is one
of the many problems with nonstandard hardware.

-hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[Borislav Petkov]

On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
> Fix build warnings:
> 
> error: implicit declaration of function ‘olpc_board_at_least’
> [-Werror=implicit-function-declaration]
> 
>  error: implicit declaration of function ‘olpc_board’
> [-Werror=implicit-function-declaration]

How exactly do you trigger that?

> in files:
> drivers/power/olpc_battery.c
> drivers/input/mouse/hgpk.c
> drivers/staging/olpc_dcon/olpc_dcon.c
> arch/x86/platform/olpc/olpc.c
> sound/pci/cs5535audio/cs5535audio_olpc.c

AFAICT, those should all depend on CONFIG_OLPC which defines those
functions...

Thanks.

-- 
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[Ksenija Stanojević]

On Tue, Sep 29, 2015 at 7:16 PM, Borislav Petkov  wrote:
> On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote:
>> when building with:
>> make drivers/staging/oplc_dcon/olpc_dcon.o
>> I get this warnings.
>
> Yeah, you can't pick out single files from the source tree and try to
> build them and expect that to always work. That olpc_dcon think depends
> on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have
> enabled CONFIG_OLPC first.
>
Ok, thanks!

Ksenija
> --
> Regards/Gruss,
> Boris.
>
> ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[Borislav Petkov]

On Tue, Sep 29, 2015 at 07:19:32PM +0200, Ksenija Stanojević wrote:
> On Tue, Sep 29, 2015 at 7:16 PM, Borislav Petkov  wrote:
> > On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote:
> >> when building with:
> >> make drivers/staging/oplc_dcon/olpc_dcon.o
> >> I get this warnings.
> >
> > Yeah, you can't pick out single files from the source tree and try to
> > build them and expect that to always work. That olpc_dcon think depends
> > on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have
> > enabled CONFIG_OLPC first.
> >
> Ok, thanks!

Sure, no probs.

Btw, if you really want to try to fix some bugs, you could try to build
the kernel with

make -j W=n 2>build-warnings.log

where n is 1, 2 or 3 (or any subset of those) and try to analyze them.

Look at the output in build-warnings.log and try to understand why the
compiler is complaining and whether it makes sense.

Some of them might be worth fixing. Most of them are bogus and/or fixing
them would require just too much code changes for no real gain but some
of the warnings do make sense.

Also, you could do

make allmodconfig

before that so that you can build *everything* and catch all warnings.

HTH.

-- 
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[Ksenija Stanojević]

Hi,

On Tue, Sep 29, 2015 at 7:08 PM, H. Peter Anvin  wrote:
> On 09/29/2015 10:06 AM, Borislav Petkov wrote:
>> On Tue, Sep 29, 2015 at 06:25:46PM +0200, Ksenija Stanojevic wrote:
>>> Fix build warnings:
>>>
>>> error: implicit declaration of function ‘olpc_board_at_least’
>>> [-Werror=implicit-function-declaration]
>>>
>>>  error: implicit declaration of function ‘olpc_board’
>>> [-Werror=implicit-function-declaration]
>>
>> How exactly do you trigger that?

when building with:
make drivers/staging/oplc_dcon/olpc_dcon.o
I get this warnings.

>>
>>> in files:
>>> drivers/power/olpc_battery.c
>>> drivers/input/mouse/hgpk.c
>>> drivers/staging/olpc_dcon/olpc_dcon.c
>>> arch/x86/platform/olpc/olpc.c
>>> sound/pci/cs5535audio/cs5535audio_olpc.c
>>
>> AFAICT, those should all depend on CONFIG_OLPC which defines those
>> functions...
>>
>
> It wouldn't be entirely impossible if OLPC has bitrotted.  This is one
> of the many problems with nonstandard hardware.
>
> -hpa
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] x86: include: asm: Fix build warning

[Borislav Petkov]

On Tue, Sep 29, 2015 at 07:12:07PM +0200, Ksenija Stanojević wrote:
> when building with:
> make drivers/staging/oplc_dcon/olpc_dcon.o
> I get this warnings.

Yeah, you can't pick out single files from the source tree and try to
build them and expect that to always work. That olpc_dcon think depends
on CONFIG_OLPC so if you go enable it in Kconfig, you would have to have
enabled CONFIG_OLPC first.

-- 
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/