Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized

2020-10-06 Thread Martin K. Petersen 
On Wed, 23 Sep 2020 17:19:20 -0700, john.p.donne...@oracle.com wrote:

> corrects: drivers/target/target_core_user.c:688:6: warning: 'page' may be used
> uninitialized
> 
> Fixes: 3c58f737231e ("scsi: target: tcmu: Optimize use of
> flush_dcache_page")

Applied to 5.10/scsi-queue, thanks!

[1/1] scsi: target: tcmu: Fix warning: 'page' may be used uninitialized
  https://git.kernel.org/mkp/scsi/c/61741d8699e1

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized

2020-10-02 Thread Martin K. Petersen 


John,

> corrects: drivers/target/target_core_user.c:688:6: warning: 'page' may be used
> uninitialized

Applied to 5.10/scsi-staging, thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized

2020-10-02 Thread John Donnelly 



> On Oct 2, 2020, at 1:01 PM, Mike Christie  wrote:
> 
> On 9/23/20 7:19 PM, john.p.donne...@oracle.com wrote:
>> From: John Donnelly 
>> 
>> corrects: drivers/target/target_core_user.c:688:6: warning: 'page' may be 
>> used
>> uninitialized
>> 
>> Fixes: 3c58f737231e ("scsi: target: tcmu: Optimize use of
>> flush_dcache_page")
>> 
>> To: linux-s...@vger.kernel.org
>> Cc: Mike Christie 
>> Signed-off-by: John Donnelly 
>> ---
>> drivers/target/target_core_user.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/target/target_core_user.c 
>> b/drivers/target/target_core_user.c
>> index 9b7592350502..86b28117787e 100644
>> --- a/drivers/target/target_core_user.c
>> +++ b/drivers/target/target_core_user.c
>> @@ -681,7 +681,7 @@ static void scatter_data_area(struct tcmu_dev *udev,
>>  void *from, *to = NULL;
>>  size_t copy_bytes, to_offset, offset;
>>  struct scatterlist *sg;
>> -struct page *page;
>> +struct page *page = NULL;
>> 
>>  for_each_sg(data_sg, sg, data_nents, i) {
>>  int sg_remaining = sg->length;
>> 
> 
> Looks ok for now. In the next kernel we can do the more invasive approach and
> add a new struct/helpers to make the code cleaner and fix it properly.
> 
> Acked-by: Mike Christie 


Hi 

Thank you.

I am not always on the email dlists .. Please do the right thing .

Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized

2020-10-02 Thread Mike Christie 
On 9/23/20 7:19 PM, john.p.donne...@oracle.com wrote:
> From: John Donnelly 
> 
> corrects: drivers/target/target_core_user.c:688:6: warning: 'page' may be used
> uninitialized
> 
> Fixes: 3c58f737231e ("scsi: target: tcmu: Optimize use of
> flush_dcache_page")
> 
> To: linux-s...@vger.kernel.org
> Cc: Mike Christie 
> Signed-off-by: John Donnelly 
> ---
>  drivers/target/target_core_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/target/target_core_user.c 
> b/drivers/target/target_core_user.c
> index 9b7592350502..86b28117787e 100644
> --- a/drivers/target/target_core_user.c
> +++ b/drivers/target/target_core_user.c
> @@ -681,7 +681,7 @@ static void scatter_data_area(struct tcmu_dev *udev,
>   void *from, *to = NULL;
>   size_t copy_bytes, to_offset, offset;
>   struct scatterlist *sg;
> - struct page *page;
> + struct page *page = NULL;
>  
>   for_each_sg(data_sg, sg, data_nents, i) {
>   int sg_remaining = sg->length;
> 

Looks ok for now. In the next kernel we can do the more invasive approach and
add a new struct/helpers to make the code cleaner and fix it properly.

Acked-by: Mike Christie