Re: [PATCH -next] soc: bcm: bcm2835-pm: Make local symbol static

[Florian Fainelli]

On Wed, 16 Jan 2019 05:44:17 +, Wei Yongjun  wrote:
> Fixes the following sparse warning:
> 
> drivers/soc/bcm/bcm2835-power.c:556:32: warning:
>  symbol 'bcm2835_reset_ops' was not declared. Should it be static?
> 
> Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains 
> under a new binding.")
> Signed-off-by: Wei Yongjun 
> ---

Applied to drivers/next, thanks!
--
Florian

Re: [PATCH -next] soc: bcm: bcm2835-pm: Make local symbol static

[Scott Branden]

Looks good.

On 2019-01-15 9:44 p.m., Wei Yongjun wrote:

Fixes the following sparse warning:

drivers/soc/bcm/bcm2835-power.c:556:32: warning:
  symbol 'bcm2835_reset_ops' was not declared. Should it be static?

Fixes: 670c672608a1 ("soc: bcm: bcm2835-pm: Add support for power domains under a 
new binding.")
Signed-off-by: Wei Yongjun 

Acked-by: Scott Branden 

---
  drivers/soc/bcm/bcm2835-power.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c
index 4841295..9351349 100644
--- a/drivers/soc/bcm/bcm2835-power.c
+++ b/drivers/soc/bcm/bcm2835-power.c
@@ -553,7 +553,7 @@ static int bcm2835_reset_status(struct reset_controller_dev 
*rcdev,
}
  }
  
-const struct reset_control_ops bcm2835_reset_ops = {

+static const struct reset_control_ops bcm2835_reset_ops = {
.reset = bcm2835_reset_reset,
.status = bcm2835_reset_status,
  };