Re: [PATCH 0/5] Updates to staging driver: kpc_i2c
On Tue, May 21, 2019 at 08:15:52AM +, Geordan Neukum wrote: > On Mon, May 20, 2019 at 10:30:26AM +0200, Greg Kroah-Hartman wrote: > > On Sat, May 18, 2019 at 02:29:55AM +, Geordan Neukum wrote: > > > Attached are an assortment of updates to the kpc_i2c driver in the > > > staging subtree. > > > > All now queued up. I'll rebase my patches that move this file on top of > > yours, as kbuild found some problems with mine, and I'll resend them to > > the list. > > > Thanks. > > Additionally, I plan on trying to clean up that driver a bit more. Should I > base my future patches off of the staging tree so that I'll have the > "latest" driver as my basepoint? I don't want to cause any headaches > for anyone in the future. Yes, please do so. Please work off of either the staging-next or even better, staging-testing as that contains the latest patches. I apply patches to the -testing branch first, and if that passes the 0-day bot, I then merge them to -next. Given that there are a lot of people working on this codebase right now (as it needs so much obvious work), I would recommend using -next and getting used to rebasing your changes :) I take patches as they are submitted, so sometimes people do step on each other's toes, that's normal. But I think you are the only one touching the i2c driver at the moment so it shouldn't be that bad. > Apologies, if I missed something obvious on the newbies wiki. > Assuming that I did not, I will certainly go ahead and try to document > this case either on or as a link from the "sending your first patch" > page. This is beyond the "first patch" work, this is now in the "being an active developer" workflow :) thanks, greg k-h
Re: [PATCH 0/5] Updates to staging driver: kpc_i2c
> On Mon, May 20, 2019 at 10:30:26AM +0200, Greg Kroah-Hartman wrote: > > All now queued up. I'll rebase my patches that move this file on top of > yours, as kbuild found some problems with mine, and I'll resend them to > the list. > > Thanks. ** Same content as last reply, just realized that I had configured my ** email client to do something wrong. Resend for readability's sake. Additionally, I plan on trying to clean up that driver a bit more. Should I base my future patches off of the staging tree so that I'll have the "latest" driver as my basepoint? I don't want to cause any headaches for anyone in the future. Apologies, if I missed something obvious on the newbies wiki. Assuming that I did not, I will certainly go ahead and try to document this case either on or as a link from the "sending your first patch" page. Cheers, Geordan
Re: [PATCH 0/5] Updates to staging driver: kpc_i2c
On Mon, May 20, 2019 at 10:30:26AM +0200, Greg Kroah-Hartman wrote: > On Sat, May 18, 2019 at 02:29:55AM +, Geordan Neukum wrote: > > Attached are an assortment of updates to the kpc_i2c driver in the > > staging subtree. > > All now queued up. I'll rebase my patches that move this file on top of > yours, as kbuild found some problems with mine, and I'll resend them to > the list. > Thanks. Additionally, I plan on trying to clean up that driver a bit more. Should I base my future patches off of the staging tree so that I'll have the "latest" driver as my basepoint? I don't want to cause any headaches for anyone in the future. Apologies, if I missed something obvious on the newbies wiki. Assuming that I did not, I will certainly go ahead and try to document this case either on or as a link from the "sending your first patch" page. Cheers, Geordan On Mon, May 20, 2019 at 8:30 AM Greg Kroah-Hartman wrote: > > On Sat, May 18, 2019 at 02:29:55AM +, Geordan Neukum wrote: > > Attached are an assortment of updates to the kpc_i2c driver in the > > staging subtree. > > All now queued up. I'll rebase my patches that move this file on top of > yours, as kbuild found some problems with mine, and I'll resend them to > the list. > > thanks, > > greg k-h
Re: [PATCH 0/5] Updates to staging driver: kpc_i2c
On Sat, May 18, 2019 at 02:29:55AM +, Geordan Neukum wrote: > Attached are an assortment of updates to the kpc_i2c driver in the > staging subtree. All now queued up. I'll rebase my patches that move this file on top of yours, as kbuild found some problems with mine, and I'll resend them to the list. thanks, greg k-h
