Re: [PATCH 03/31] perf, x86: Basic Haswell PEBS support

2012-09-28 Thread Peter Zijlstra
On Thu, 2012-09-27 at 21:31 -0700, Andi Kleen wrote:
> +   INTEL_UEVENT_CONSTRAINT(0x11d0, 0xf), /* 
> MEM_UOPS_RETIRED.STLB_MISS_LOADS */
> +   INTEL_UEVENT_CONSTRAINT(0x12d0, 0xf), /* 
> MEM_UOPS_RETIRED.STLB_MISS_STORES */
> +   INTEL_UEVENT_CONSTRAINT(0x21d0, 0xf), /* MEM_UOPS_RETIRED.LOCK_LOADS 
> */

Did you miss umask 22, LOCK_STORES ? (I haven't looked at the SDM yet,
just seeing a glitch in the pattern).

> +   INTEL_UEVENT_CONSTRAINT(0x41d0, 0xf), /* MEM_UOPS_RETIRED.SPLIT_LOADS 
> */
> +   INTEL_UEVENT_CONSTRAINT(0x42d0, 0xf), /* 
> MEM_UOPS_RETIRED.SPLIT_STORES */
> +   INTEL_UEVENT_CONSTRAINT(0x81d0, 0xf), /* MEM_UOPS_RETIRED.ALL_LOADS */
> +   INTEL_UEVENT_CONSTRAINT(0x82d0, 0xf), /* MEM_UOPS_RETIRED.ALL_STORES 
> */ 

Just wondering, are there all d0 events? Or is this a specific subset?
That is, why not use:

INTEL_EVENT_CONSTRAINT(0xd0, 0xf), /* MEM_UOPS_RETIRED.* */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 03/31] perf, x86: Basic Haswell PEBS support

2012-09-28 Thread Peter Zijlstra
On Thu, 2012-09-27 at 21:31 -0700, Andi Kleen wrote:
 +   INTEL_UEVENT_CONSTRAINT(0x11d0, 0xf), /* 
 MEM_UOPS_RETIRED.STLB_MISS_LOADS */
 +   INTEL_UEVENT_CONSTRAINT(0x12d0, 0xf), /* 
 MEM_UOPS_RETIRED.STLB_MISS_STORES */
 +   INTEL_UEVENT_CONSTRAINT(0x21d0, 0xf), /* MEM_UOPS_RETIRED.LOCK_LOADS 
 */

Did you miss umask 22, LOCK_STORES ? (I haven't looked at the SDM yet,
just seeing a glitch in the pattern).

 +   INTEL_UEVENT_CONSTRAINT(0x41d0, 0xf), /* MEM_UOPS_RETIRED.SPLIT_LOADS 
 */
 +   INTEL_UEVENT_CONSTRAINT(0x42d0, 0xf), /* 
 MEM_UOPS_RETIRED.SPLIT_STORES */
 +   INTEL_UEVENT_CONSTRAINT(0x81d0, 0xf), /* MEM_UOPS_RETIRED.ALL_LOADS */
 +   INTEL_UEVENT_CONSTRAINT(0x82d0, 0xf), /* MEM_UOPS_RETIRED.ALL_STORES 
 */ 

Just wondering, are there all d0 events? Or is this a specific subset?
That is, why not use:

INTEL_EVENT_CONSTRAINT(0xd0, 0xf), /* MEM_UOPS_RETIRED.* */

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/