Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wed, Feb 06, 2013 at 04:30:41PM +, Russell King - ARM Linux wrote: > On Tue, Feb 05, 2013 at 09:41:48PM +0100, Thierry Reding wrote: > > On Wed, Jan 09, 2013 at 09:43:06PM +0100, Thierry Reding wrote: > > > When using deferred driver probing, PCI host controller drivers may > > > actually require this function after the init stage. > > > > > > Signed-off-by: Thierry Reding > > > --- > > > arch/arm/kernel/bios32.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > Russell, > > > > Can this patch and patch 7 (ARM: pci: Allow passing per-controller > > private data) of this series be applied for 3.9? Thomas uses them in his > > Marvell PCIe series as well and it would allow to reduce the complexity > > of the dependencies. > > It'll need to go into the patch system in that case... Alright, I'll submit them to the patch system. Thanks. Thierry pgp2rgrsLCqWg.pgp Description: PGP signature
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wednesday 06 February 2013 18:07:53 Linus Walleij wrote: > However it leaves the question of how much __init, __initdata > and __initconst we have littering around. Oh, well, we'll see > I guess. Actually, kbuild is pretty good at warning around the bugs there. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Thu, Feb 7, 2013 at 1:54 AM, Arnd Bergmann wrote: > On Wednesday 06 February 2013 17:38:20 Linus Walleij wrote: >> On Wed, Jan 9, 2013 at 9:43 PM, Thierry Reding >> wrote: >> >> > When using deferred driver probing, PCI host controller drivers may >> > actually require this function after the init stage. >> > >> > Signed-off-by: Thierry Reding >> >> There seem to be a proliferation of these patches now. >> >> Isn't this just papering over the real problem? The discarding >> of __init sections need to happen *after* all deferred probes >> are complete, lest we have to remove *all* __init sections from >> *all* drivers in the kernel, don't we? > > No, I think it's not quite that bad. I think the rule is still > just that .probe() functions and anything called from them must > not be __init. They used to be __devinit, which would cause > problems with deferred probing on !HOTPLUG systems but that's > gone in 3.9. > > Thierry's patch is just necessary because pci_common_init used > to be called only from actual __init functions, and not it > gets called from a .probe() function for the first time. Aha OK, then it feels much better now. However it leaves the question of how much __init, __initdata and __initconst we have littering around. Oh, well, we'll see I guess. Thanks, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wednesday 06 February 2013 17:38:20 Linus Walleij wrote: > On Wed, Jan 9, 2013 at 9:43 PM, Thierry Reding > wrote: > > > When using deferred driver probing, PCI host controller drivers may > > actually require this function after the init stage. > > > > Signed-off-by: Thierry Reding > > There seem to be a proliferation of these patches now. > > Isn't this just papering over the real problem? The discarding > of __init sections need to happen *after* all deferred probes > are complete, lest we have to remove *all* __init sections from > *all* drivers in the kernel, don't we? No, I think it's not quite that bad. I think the rule is still just that .probe() functions and anything called from them must not be __init. They used to be __devinit, which would cause problems with deferred probing on !HOTPLUG systems but that's gone in 3.9. Thierry's patch is just necessary because pci_common_init used to be called only from actual __init functions, and not it gets called from a .probe() function for the first time. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wed, Jan 9, 2013 at 9:43 PM, Thierry Reding wrote: > When using deferred driver probing, PCI host controller drivers may > actually require this function after the init stage. > > Signed-off-by: Thierry Reding There seem to be a proliferation of these patches now. Isn't this just papering over the real problem? The discarding of __init sections need to happen *after* all deferred probes are complete, lest we have to remove *all* __init sections from *all* drivers in the kernel, don't we? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Tue, Feb 05, 2013 at 09:41:48PM +0100, Thierry Reding wrote: > On Wed, Jan 09, 2013 at 09:43:06PM +0100, Thierry Reding wrote: > > When using deferred driver probing, PCI host controller drivers may > > actually require this function after the init stage. > > > > Signed-off-by: Thierry Reding > > --- > > arch/arm/kernel/bios32.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Russell, > > Can this patch and patch 7 (ARM: pci: Allow passing per-controller > private data) of this series be applied for 3.9? Thomas uses them in his > Marvell PCIe series as well and it would allow to reduce the complexity > of the dependencies. It'll need to go into the patch system in that case... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
Dear Thierry Reding, On Wed, 9 Jan 2013 21:43:06 +0100, Thierry Reding wrote: > When using deferred driver probing, PCI host controller drivers may > actually require this function after the init stage. > > Signed-off-by: Thierry Reding Tested-by: Thomas Petazzoni -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
Dear Thierry Reding, On Wed, 9 Jan 2013 21:43:06 +0100, Thierry Reding wrote: When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de Tested-by: Thomas Petazzoni thomas.petazz...@free-electrons.com -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Tue, Feb 05, 2013 at 09:41:48PM +0100, Thierry Reding wrote: On Wed, Jan 09, 2013 at 09:43:06PM +0100, Thierry Reding wrote: When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de --- arch/arm/kernel/bios32.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Russell, Can this patch and patch 7 (ARM: pci: Allow passing per-controller private data) of this series be applied for 3.9? Thomas uses them in his Marvell PCIe series as well and it would allow to reduce the complexity of the dependencies. It'll need to go into the patch system in that case... -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wed, Jan 9, 2013 at 9:43 PM, Thierry Reding thierry.red...@avionic-design.de wrote: When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de There seem to be a proliferation of these patches now. Isn't this just papering over the real problem? The discarding of __init sections need to happen *after* all deferred probes are complete, lest we have to remove *all* __init sections from *all* drivers in the kernel, don't we? Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wednesday 06 February 2013 17:38:20 Linus Walleij wrote: On Wed, Jan 9, 2013 at 9:43 PM, Thierry Reding thierry.red...@avionic-design.de wrote: When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de There seem to be a proliferation of these patches now. Isn't this just papering over the real problem? The discarding of __init sections need to happen *after* all deferred probes are complete, lest we have to remove *all* __init sections from *all* drivers in the kernel, don't we? No, I think it's not quite that bad. I think the rule is still just that .probe() functions and anything called from them must not be __init. They used to be __devinit, which would cause problems with deferred probing on !HOTPLUG systems but that's gone in 3.9. Thierry's patch is just necessary because pci_common_init used to be called only from actual __init functions, and not it gets called from a .probe() function for the first time. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Thu, Feb 7, 2013 at 1:54 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 06 February 2013 17:38:20 Linus Walleij wrote: On Wed, Jan 9, 2013 at 9:43 PM, Thierry Reding thierry.red...@avionic-design.de wrote: When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de There seem to be a proliferation of these patches now. Isn't this just papering over the real problem? The discarding of __init sections need to happen *after* all deferred probes are complete, lest we have to remove *all* __init sections from *all* drivers in the kernel, don't we? No, I think it's not quite that bad. I think the rule is still just that .probe() functions and anything called from them must not be __init. They used to be __devinit, which would cause problems with deferred probing on !HOTPLUG systems but that's gone in 3.9. Thierry's patch is just necessary because pci_common_init used to be called only from actual __init functions, and not it gets called from a .probe() function for the first time. Aha OK, then it feels much better now. However it leaves the question of how much __init, __initdata and __initconst we have littering around. Oh, well, we'll see I guess. Thanks, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wednesday 06 February 2013 18:07:53 Linus Walleij wrote: However it leaves the question of how much __init, __initdata and __initconst we have littering around. Oh, well, we'll see I guess. Actually, kbuild is pretty good at warning around the bugs there. Arnd -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wed, Feb 06, 2013 at 04:30:41PM +, Russell King - ARM Linux wrote: On Tue, Feb 05, 2013 at 09:41:48PM +0100, Thierry Reding wrote: On Wed, Jan 09, 2013 at 09:43:06PM +0100, Thierry Reding wrote: When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de --- arch/arm/kernel/bios32.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Russell, Can this patch and patch 7 (ARM: pci: Allow passing per-controller private data) of this series be applied for 3.9? Thomas uses them in his Marvell PCIe series as well and it would allow to reduce the complexity of the dependencies. It'll need to go into the patch system in that case... Alright, I'll submit them to the patch system. Thanks. Thierry pgp2rgrsLCqWg.pgp Description: PGP signature
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wed, Jan 09, 2013 at 09:43:06PM +0100, Thierry Reding wrote: > When using deferred driver probing, PCI host controller drivers may > actually require this function after the init stage. > > Signed-off-by: Thierry Reding > --- > arch/arm/kernel/bios32.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Russell, Can this patch and patch 7 (ARM: pci: Allow passing per-controller private data) of this series be applied for 3.9? Thomas uses them in his Marvell PCIe series as well and it would allow to reduce the complexity of the dependencies. Thierry pgpkfFT5w69ar.pgp Description: PGP signature
Re: [PATCH 06/14] ARM: pci: Keep pci_common_init() around after init
On Wed, Jan 09, 2013 at 09:43:06PM +0100, Thierry Reding wrote: When using deferred driver probing, PCI host controller drivers may actually require this function after the init stage. Signed-off-by: Thierry Reding thierry.red...@avionic-design.de --- arch/arm/kernel/bios32.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Russell, Can this patch and patch 7 (ARM: pci: Allow passing per-controller private data) of this series be applied for 3.9? Thomas uses them in his Marvell PCIe series as well and it would allow to reduce the complexity of the dependencies. Thierry pgpkfFT5w69ar.pgp Description: PGP signature
