Re: [PATCH 1/1] drivers/mfd/ab8500-debugfs.c: remove unnecessary null test before debugfs_remove_recursive
On Sat, 28 Jun 2014, Fabian Frederick wrote: > Fix checkpatch warning: > WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not > required > > Cc: Linus Walleij > Cc: Samuel Ortiz > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Fabian Frederick > --- > drivers/mfd/ab8500-debugfs.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c > index d1a22aa..7ca8713 100644 > --- a/drivers/mfd/ab8500-debugfs.c > +++ b/drivers/mfd/ab8500-debugfs.c > @@ -3192,8 +3192,7 @@ static int ab8500_debug_probe(struct platform_device > *plf) > return 0; > > err: > - if (ab8500_dir) > - debugfs_remove_recursive(ab8500_dir); > + debugfs_remove_recursive(ab8500_dir); > dev_err(>dev, "failed to create debugfs entries.\n"); > > return -ENOMEM; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] drivers/mfd/ab8500-debugfs.c: remove unnecessary null test before debugfs_remove_recursive
On Sat, 28 Jun 2014, Fabian Frederick wrote: Fix checkpatch warning: WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required Cc: Linus Walleij linus.wall...@linaro.org Cc: Samuel Ortiz sa...@linux.intel.com Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/mfd/ab8500-debugfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks. diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index d1a22aa..7ca8713 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -3192,8 +3192,7 @@ static int ab8500_debug_probe(struct platform_device *plf) return 0; err: - if (ab8500_dir) - debugfs_remove_recursive(ab8500_dir); + debugfs_remove_recursive(ab8500_dir); dev_err(plf-dev, failed to create debugfs entries.\n); return -ENOMEM; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
