Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures

2017-08-10 Thread Mark Brown 
On Thu, Aug 10, 2017 at 08:56:35PM +0530, Bhumika Goyal wrote:
> On Thu, Aug 10, 2017 at 8:50 PM, Mark Brown  wrote:

> > This is difficult to apply against current code as it is a single commit
> > over lots of files but the ASoC tree has lots of branches.  I've figured
> > out the dependencies but it's easier to split things up (and avoids
> > collisions with other changes causing the whole thing to not apply).

> Thanks for the response.
> Should I make separate patches for each file or is there another way
> to split this patch?

Splitting per driver would've been easier, or saying exactly where it
applies if you don't split it.  Like I say I figured it out for this one.


signature.asc
Description: PGP signature

Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures

2017-08-10 Thread Mark Brown 
On Thu, Aug 10, 2017 at 08:56:35PM +0530, Bhumika Goyal wrote:
> On Thu, Aug 10, 2017 at 8:50 PM, Mark Brown  wrote:

> > This is difficult to apply against current code as it is a single commit
> > over lots of files but the ASoC tree has lots of branches.  I've figured
> > out the dependencies but it's easier to split things up (and avoids
> > collisions with other changes causing the whole thing to not apply).

> Thanks for the response.
> Should I make separate patches for each file or is there another way
> to split this patch?

Splitting per driver would've been easier, or saying exactly where it
applies if you don't split it.  Like I say I figured it out for this one.


signature.asc
Description: PGP signature

Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures

2017-08-10 Thread Bhumika Goyal 
On Thu, Aug 10, 2017 at 8:50 PM, Mark Brown  wrote:
> On Thu, Aug 03, 2017 at 09:30:19PM +0530, Bhumika Goyal wrote:
>
>>  sound/soc/codecs/88pm860x-codec.c  | 2 +-
>>  sound/soc/codecs/ab8500-codec.c| 2 +-
>>  sound/soc/codecs/ac97.c| 2 +-
>>  sound/soc/codecs/ad1836.c  | 2 +-
>>  sound/soc/codecs/ad193x.c  | 2 +-
>>  sound/soc/codecs/ad1980.c  | 2 +-
>>  sound/soc/codecs/ad73311.c | 2 +-
>>  sound/soc/codecs/adau1373.c| 2 +-
>>  sound/soc/codecs/adau1701.c| 2 +-
>
> This is difficult to apply against current code as it is a single commit
> over lots of files but the ASoC tree has lots of branches.  I've figured
> out the dependencies but it's easier to split things up (and avoids
> collisions with other changes causing the whole thing to not apply).

Thanks for the response.
Should I make separate patches for each file or is there another way
to split this patch?

Thanks,
Bhumika

Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures

2017-08-10 Thread Bhumika Goyal 
On Thu, Aug 10, 2017 at 8:50 PM, Mark Brown  wrote:
> On Thu, Aug 03, 2017 at 09:30:19PM +0530, Bhumika Goyal wrote:
>
>>  sound/soc/codecs/88pm860x-codec.c  | 2 +-
>>  sound/soc/codecs/ab8500-codec.c| 2 +-
>>  sound/soc/codecs/ac97.c| 2 +-
>>  sound/soc/codecs/ad1836.c  | 2 +-
>>  sound/soc/codecs/ad193x.c  | 2 +-
>>  sound/soc/codecs/ad1980.c  | 2 +-
>>  sound/soc/codecs/ad73311.c | 2 +-
>>  sound/soc/codecs/adau1373.c| 2 +-
>>  sound/soc/codecs/adau1701.c| 2 +-
>
> This is difficult to apply against current code as it is a single commit
> over lots of files but the ASoC tree has lots of branches.  I've figured
> out the dependencies but it's easier to split things up (and avoids
> collisions with other changes causing the whole thing to not apply).

Thanks for the response.
Should I make separate patches for each file or is there another way
to split this patch?

Thanks,
Bhumika

Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures

2017-08-10 Thread Mark Brown 
On Thu, Aug 03, 2017 at 09:30:19PM +0530, Bhumika Goyal wrote:

>  sound/soc/codecs/88pm860x-codec.c  | 2 +-
>  sound/soc/codecs/ab8500-codec.c| 2 +-
>  sound/soc/codecs/ac97.c| 2 +-
>  sound/soc/codecs/ad1836.c  | 2 +-
>  sound/soc/codecs/ad193x.c  | 2 +-
>  sound/soc/codecs/ad1980.c  | 2 +-
>  sound/soc/codecs/ad73311.c | 2 +-
>  sound/soc/codecs/adau1373.c| 2 +-
>  sound/soc/codecs/adau1701.c| 2 +-

This is difficult to apply against current code as it is a single commit
over lots of files but the ASoC tree has lots of branches.  I've figured
out the dependencies but it's easier to split things up (and avoids
collisions with other changes causing the whole thing to not apply).


signature.asc
Description: PGP signature

Re: [PATCH 1/2] ASoC: codecs: add const to snd_soc_codec_driver structures

2017-08-10 Thread Mark Brown 
On Thu, Aug 03, 2017 at 09:30:19PM +0530, Bhumika Goyal wrote:

>  sound/soc/codecs/88pm860x-codec.c  | 2 +-
>  sound/soc/codecs/ab8500-codec.c| 2 +-
>  sound/soc/codecs/ac97.c| 2 +-
>  sound/soc/codecs/ad1836.c  | 2 +-
>  sound/soc/codecs/ad193x.c  | 2 +-
>  sound/soc/codecs/ad1980.c  | 2 +-
>  sound/soc/codecs/ad73311.c | 2 +-
>  sound/soc/codecs/adau1373.c| 2 +-
>  sound/soc/codecs/adau1701.c| 2 +-

This is difficult to apply against current code as it is a single commit
over lots of files but the ASoC tree has lots of branches.  I've figured
out the dependencies but it's easier to split things up (and avoids
collisions with other changes causing the whole thing to not apply).


signature.asc
Description: PGP signature