Re: [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset
On Mon, 16 Apr 2018, James Hogan wrote:
> > @@ -260,6 +260,11 @@
> > jr ra
> > andiv1, a2, STORMASK
>
> This patch looks good, well spotted!
>
> But whats that v1 write about? Any ideas? Seems to go back to the git
> epoch, and $3 isn't in the clobber lists when __bzero* is called.
You need to dive deeper, that is beyond the secret commit 66f0a432564b
("Add resource managment."), to find what's happened before the epoch. ;)
Anyway, there isn't anything special here, the thing has been here since
the inception of memset.S with commit 2e0f55e79c49 (no shortlog available
for that one). And it is clearly a bug, possibly just a leftover from a
WIP implementation or whatever.
And I can see Matt has already fixed that, thanks!
Maciej
Re: [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset
On Mon, 16 Apr 2018, James Hogan wrote:
> > @@ -260,6 +260,11 @@
> > jr ra
> > andiv1, a2, STORMASK
>
> This patch looks good, well spotted!
>
> But whats that v1 write about? Any ideas? Seems to go back to the git
> epoch, and $3 isn't in the clobber lists when __bzero* is called.
You need to dive deeper, that is beyond the secret commit 66f0a432564b
("Add resource managment."), to find what's happened before the epoch. ;)
Anyway, there isn't anything special here, the thing has been here since
the inception of memset.S with commit 2e0f55e79c49 (no shortlog available
for that one). And it is clearly a bug, possibly just a leftover from a
WIP implementation or whatever.
And I can see Matt has already fixed that, thanks!
Maciej
Re: [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset
Hi James, On 16/04/18 21:22, James Hogan wrote: On Thu, Mar 29, 2018 at 10:28:23AM +0100, Matt Redfearn wrote: @@ -260,6 +260,11 @@ jr ra andiv1, a2, STORMASK This patch looks good, well spotted! But whats that v1 write about? Any ideas? Seems to go back to the git epoch, and $3 isn't in the clobber lists when __bzero* is called. No idea what the original intent was, but I've verified that v1 does indeed get clobbered if this path is hit. Patch incoming! Thanks, Matt Cheers James +.Lsmall_fixup\@: + PTR_SUBUa2, t1, a0 + jr ra +PTR_ADDIU a2, 1 +
Re: [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset
Hi James, On 16/04/18 21:22, James Hogan wrote: On Thu, Mar 29, 2018 at 10:28:23AM +0100, Matt Redfearn wrote: @@ -260,6 +260,11 @@ jr ra andiv1, a2, STORMASK This patch looks good, well spotted! But whats that v1 write about? Any ideas? Seems to go back to the git epoch, and $3 isn't in the clobber lists when __bzero* is called. No idea what the original intent was, but I've verified that v1 does indeed get clobbered if this path is hit. Patch incoming! Thanks, Matt Cheers James +.Lsmall_fixup\@: + PTR_SUBUa2, t1, a0 + jr ra +PTR_ADDIU a2, 1 +
Re: [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset
On Thu, Mar 29, 2018 at 10:28:23AM +0100, Matt Redfearn wrote: > @@ -260,6 +260,11 @@ > jr ra > andiv1, a2, STORMASK This patch looks good, well spotted! But whats that v1 write about? Any ideas? Seems to go back to the git epoch, and $3 isn't in the clobber lists when __bzero* is called. Cheers James > > +.Lsmall_fixup\@: > + PTR_SUBUa2, t1, a0 > + jr ra > + PTR_ADDIU a2, 1 > + signature.asc Description: Digital signature
Re: [PATCH 1/2] MIPS: memset.S: EVA & fault support for small_memset
On Thu, Mar 29, 2018 at 10:28:23AM +0100, Matt Redfearn wrote: > @@ -260,6 +260,11 @@ > jr ra > andiv1, a2, STORMASK This patch looks good, well spotted! But whats that v1 write about? Any ideas? Seems to go back to the git epoch, and $3 isn't in the clobber lists when __bzero* is called. Cheers James > > +.Lsmall_fixup\@: > + PTR_SUBUa2, t1, a0 > + jr ra > + PTR_ADDIU a2, 1 > + signature.asc Description: Digital signature
