Re: [PATCH 1/2] VM: invalidate_inode_pages2_range() should not exit early

[Andrew Morton]

On Mon, 12 Feb 2007 23:43:35 -0800
Trond Myklebust <[EMAIL PROTECTED]> wrote:

> From: Trond Myklebust <[EMAIL PROTECTED]>
> 
> Fix invalidate_inode_pages2_range() so that it does not immediately exit
> just because a single page in the specified range could not be removed.
> 

One man's "fix" is another man's "slow down" ;)

Could we please have a description of why this change is needed?

> ---
> 
>  mm/truncate.c |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/truncate.c b/mm/truncate.c
> index ebf3fcb..0f4b6d1 100644
> --- a/mm/truncate.c
> +++ b/mm/truncate.c
> @@ -375,10 +375,10 @@ int invalidate_inode_pages2_range(struct
>  
>   pagevec_init(, 0);
>   next = start;
> - while (next <= end && !ret && !wrapped &&
> + while (next <= end && !wrapped &&
>   pagevec_lookup(, mapping, next,
>   min(end - next, (pgoff_t)PAGEVEC_SIZE - 1) + 1)) {
> - for (i = 0; !ret && i < pagevec_count(); i++) {
> + for (i = 0; i < pagevec_count(); i++) {
>   struct page *page = pvec.pages[i];
>   pgoff_t page_index;
>  
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] VM: invalidate_inode_pages2_range() should not exit early

[Andrew Morton]

On Mon, 12 Feb 2007 23:43:35 -0800
Trond Myklebust [EMAIL PROTECTED] wrote:

 From: Trond Myklebust [EMAIL PROTECTED]
 
 Fix invalidate_inode_pages2_range() so that it does not immediately exit
 just because a single page in the specified range could not be removed.
 

One man's fix is another man's slow down ;)

Could we please have a description of why this change is needed?

 ---
 
  mm/truncate.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
 
 diff --git a/mm/truncate.c b/mm/truncate.c
 index ebf3fcb..0f4b6d1 100644
 --- a/mm/truncate.c
 +++ b/mm/truncate.c
 @@ -375,10 +375,10 @@ int invalidate_inode_pages2_range(struct
  
   pagevec_init(pvec, 0);
   next = start;
 - while (next = end  !ret  !wrapped 
 + while (next = end  !wrapped 
   pagevec_lookup(pvec, mapping, next,
   min(end - next, (pgoff_t)PAGEVEC_SIZE - 1) + 1)) {
 - for (i = 0; !ret  i  pagevec_count(pvec); i++) {
 + for (i = 0; i  pagevec_count(pvec); i++) {
   struct page *page = pvec.pages[i];
   pgoff_t page_index;
  
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/