subject:"Re\: \[PATCH 1\/2\] drm\: bridge\: sil902x"

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread Ilia Mirkin

On Wed, Jan 6, 2016 at 10:26 AM, Sascha Hauer  wrote:
> On Wed, Jan 06, 2016 at 02:53:30PM +0100, Boris Brezillon wrote:
>> Hi Sascha,
>>
>> On Wed, 6 Jan 2016 14:47:36 +0100
>> Sascha Hauer  wrote:
>>
>> > Hi Boris,
>> >
>> > On Wed, Jan 06, 2016 at 12:25:50PM +0100, Boris Brezillon wrote:
>> > > Add basic support for the sil902x RGB -> HDMI bridge.
>> > > This driver does not support audio output yet.
>> > >
>> > > Signed-off-by: Boris Brezillon 
>> > > ---
>> > > Hello,
>> > >
>> > > This patch is only adding basic support for the sil9022 chip.
>> >
>> > This thing is a SiI9022 for camel case "Silicon Image" with a capital 'I',
>> > not a small 'l'.
>>
>> Oh, my bad, I'll fix that, but the vendor prefix defined in
>> Documentation/devicetree/bindings/vendor-prefixes.txt is not helping in
>> getting this right.
>
> No, indeed not. Unfortunately sii is already taken by Seiko.
>
>>
>> Should I also change the driver name?
>
> I would suggest so, yes.

For opposing opinions:

drivers/gpu/drm/i2c/sil164_drv.c
drivers/media/platform/s5p-tv/sii9234_drv.c

One of each :)

  -ilia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread Sascha Hauer

On Wed, Jan 06, 2016 at 02:53:30PM +0100, Boris Brezillon wrote:
> Hi Sascha,
> 
> On Wed, 6 Jan 2016 14:47:36 +0100
> Sascha Hauer  wrote:
> 
> > Hi Boris,
> > 
> > On Wed, Jan 06, 2016 at 12:25:50PM +0100, Boris Brezillon wrote:
> > > Add basic support for the sil902x RGB -> HDMI bridge.
> > > This driver does not support audio output yet.
> > > 
> > > Signed-off-by: Boris Brezillon 
> > > ---
> > > Hello,
> > > 
> > > This patch is only adding basic support for the sil9022 chip.
> > 
> > This thing is a SiI9022 for camel case "Silicon Image" with a capital 'I',
> > not a small 'l'.
> 
> Oh, my bad, I'll fix that, but the vendor prefix defined in
> Documentation/devicetree/bindings/vendor-prefixes.txt is not helping in
> getting this right.

No, indeed not. Unfortunately sii is already taken by Seiko.

> 
> Should I also change the driver name?

I would suggest so, yes.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread Boris Brezillon

Hi Sascha,

On Wed, 6 Jan 2016 14:47:36 +0100
Sascha Hauer  wrote:

> Hi Boris,
> 
> On Wed, Jan 06, 2016 at 12:25:50PM +0100, Boris Brezillon wrote:
> > Add basic support for the sil902x RGB -> HDMI bridge.
> > This driver does not support audio output yet.
> > 
> > Signed-off-by: Boris Brezillon 
> > ---
> > Hello,
> > 
> > This patch is only adding basic support for the sil9022 chip.
> 
> This thing is a SiI9022 for camel case "Silicon Image" with a capital 'I',
> not a small 'l'.

Oh, my bad, I'll fix that, but the vendor prefix defined in
Documentation/devicetree/bindings/vendor-prefixes.txt is not helping in
getting this right.

Should I also change the driver name?

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread Sascha Hauer

Hi Boris,

On Wed, Jan 06, 2016 at 12:25:50PM +0100, Boris Brezillon wrote:
> Add basic support for the sil902x RGB -> HDMI bridge.
> This driver does not support audio output yet.
> 
> Signed-off-by: Boris Brezillon 
> ---
> Hello,
> 
> This patch is only adding basic support for the sil9022 chip.

This thing is a SiI9022 for camel case "Silicon Image" with a capital 'I',
not a small 'l'.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread kbuild test robot

Hi Boris,

[auto build test WARNING on drm/drm-next]
[also build test WARNING on v4.4-rc8 next-20160106]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improving the system]

url:
https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-bridge-sil902x/20160106-192921
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: powerpc-allyesconfig (attached as .config)
reproduce:
wget 
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
 -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc 

All warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/bridge/sil902x.c:31:0:
   drivers/gpu/drm/bridge/sil902x.c: In function 'sil902x_bridge_mode_set':
>> drivers/gpu/drm/bridge/sil902x.c:300:13: warning: format '%zd' expects 
>> argument of type 'signed size_t', but argument 2 has type 'int' [-Wformat=]
  DRM_ERROR("failed to pack AVI infoframe: %zd\n", ret);
^
   include/drm/drmP.h:168:10: note: in definition of macro 'DRM_ERROR'
 drm_err(fmt, ##__VA_ARGS__)
 ^
   drivers/gpu/drm/bridge/sil902x.c: In function 'sil902x_probe':
   drivers/gpu/drm/bridge/sil902x.c:401:16: warning: format '%d' expects 
argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
  dev_err(dev, "Failed to retrieve/request reset gpio: %d\n",
   ^

vim +300 drivers/gpu/drm/bridge/sil902x.c

   284   SIL902X_TPI_AVI_PIXEL_REP_BUS_24BIT;
   285  buf[9] = SIL902X_TPI_AVI_INPUT_RANGE_AUTO |
   286   SIL902X_TPI_AVI_INPUT_COLORSPACE_RGB;
   287  
   288  ret = regmap_bulk_write(regmap, SIL902X_TPI_VIDEO_DATA, buf, 
10);
   289  if (ret)
   290  return;
   291  
   292  ret = drm_hdmi_avi_infoframe_from_display_mode(, adj);
   293  if (ret < 0) {
   294  DRM_ERROR("couldn't fill AVI infoframe\n");
   295  return;
   296  }
   297  
   298  ret = hdmi_avi_infoframe_pack(, buf, sizeof(buf));
   299  if (ret < 0) {
 > 300  DRM_ERROR("failed to pack AVI infoframe: %zd\n", ret);
   301  return;
   302  }
   303  
   304  /* Do not send the infoframe header, but keep the CRC field. */
   305  regmap_bulk_write(regmap, SIL902X_TPI_AVI_INFOFRAME,
   306buf + HDMI_INFOFRAME_HEADER_SIZE - 1,
   307HDMI_AVI_INFOFRAME_SIZE + 1);
   308  }

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: Binary data

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread kbuild test robot

Hi Boris,

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.4-rc8 next-20160106]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improving the system]

url:
https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-bridge-sil902x/20160106-192921
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: i386-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/gpu/drm/bridge/sil902x.c: In function 'sil902x_probe':
>> drivers/gpu/drm/bridge/sil902x.c:401:16: warning: format '%d' expects 
>> argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
  dev_err(dev, "Failed to retrieve/request reset gpio: %d\n",
   ^
   In file included from drivers/gpu/drm/bridge/sil902x.c:26:0:
   drivers/gpu/drm/bridge/sil902x.c: At top level:
>> drivers/gpu/drm/bridge/sil902x.c:476:26: error: 'sil9022_id' undeclared here 
>> (not in a function)
MODULE_DEVICE_TABLE(i2c, sil9022_id);
 ^
   include/linux/module.h:223:21: note: in definition of macro 
'MODULE_DEVICE_TABLE'
extern const typeof(name) __mod_##type##__##name##_device_table  \
^
>> include/linux/module.h:223:27: error: '__mod_i2c__sil9022_id_device_table' 
>> aliased to undefined symbol 'sil9022_id'
extern const typeof(name) __mod_##type##__##name##_device_table  \
  ^
>> drivers/gpu/drm/bridge/sil902x.c:476:1: note: in expansion of macro 
>> 'MODULE_DEVICE_TABLE'
MODULE_DEVICE_TABLE(i2c, sil9022_id);
^

vim +/sil9022_id +476 drivers/gpu/drm/bridge/sil902x.c

   395  sil902x->regmap = devm_regmap_init_i2c(client, 
_regmap_config);
   396  if (IS_ERR(sil902x->regmap))
   397  return PTR_ERR(sil902x->regmap);
   398  
   399  sil902x->reset_gpio = devm_gpiod_get(dev, "reset", 
GPIOD_OUT_LOW);
   400  if (IS_ERR(sil902x->reset_gpio)) {
 > 401  dev_err(dev, "Failed to retrieve/request reset gpio: 
 > %d\n",
   402  PTR_ERR(sil902x->reset_gpio));
   403  return PTR_ERR(sil902x->reset_gpio);
   404  }
   405  
   406  sil902x_reset(sil902x);
   407  
   408  ret = regmap_write(sil902x->regmap, SIL902X_REG_TPI_RQB, 0x0);
   409  if (ret)
   410  return ret;
   411  
   412  ret = regmap_bulk_read(sil902x->regmap, SIL902X_REG_CHIPID(0),
   413 , 4);
   414  if (ret) {
   415  dev_err(dev, "regmap_read failed %d\n", ret);
   416  return ret;
   417  }
   418  
   419  if (chipid[0] != 0xb0) {
   420  dev_err(dev, "Invalid chipid: %02x (expecting 0xb0)\n",
   421  chipid[0]);
   422  return -EINVAL;
   423  }
   424  
   425  /* Clear all pending interrupts */
   426  regmap_read(sil902x->regmap, SI902X_INT_STATUS, );
   427  regmap_write(sil902x->regmap, SI902X_INT_STATUS, status);
   428  
   429  if (client->irq > 0) {
   430  regmap_write(sil902x->regmap, SI902X_INT_ENABLE,
   431   SI902X_HOTPLUG_EVENT);
   432  
   433  ret = devm_request_threaded_irq(dev, client->irq, NULL,
   434  sil902x_interrupt,
   435  IRQF_ONESHOT, 
dev_name(dev),
   436  sil902x);
   437  if (ret)
   438  return ret;
   439  }
   440  
   441  sil902x->bridge.funcs = _bridge_funcs;
   442  sil902x->bridge.of_node = dev->of_node;
   443  ret = drm_bridge_add(>bridge);
   444  if (ret) {
   445  dev_err(dev, "Failed to add drm_bridge\n");
   446  return ret;
   447  }
   448  
   449  i2c_set_clientdata(client, sil902x);
   450  
   451  return 0;
   452  }
   453  
   454  static int sil902x_remove(struct i2c_client *client)
   455  
   456  {
   457  struct sil902x *sil902x = i2c_get_clientdata(client);
   458  
   459  drm_bridge_remove(>bridge);
   460  
   461  return 0;
   462  }
   463  
   464  #ifdef CONFIG_OF
   465  static const struct of_device_id sil902x_dt_ids[] = {
   466  { .compatible = "sil,sil9022", },
   467  { }
   468  };
   469  MODULE_DEVICE_TABLE(of, sil902x_dt_ids);
   470  #endif
   471  
   472  static const struct i2c_device_id sil902x_i2c_ids[] = {
   473  { "sil9022", 0 },
   474  { },
   475  };
 > 476  MODULE_DEVICE_TABLE(i2c, sil9022_id);
   477  
   478  static struct i2c_driver sil902x_driver = {
   479

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread kbuild test robot

Hi Boris,

[auto build test WARNING on drm/drm-next]
[also build test WARNING on v4.4-rc8 next-20160106]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improving the system]

url:
https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-bridge-sil902x/20160106-192921
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: powerpc-allyesconfig (attached as .config)
reproduce:
wget 
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
 -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=powerpc 

All warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/bridge/sil902x.c:31:0:
   drivers/gpu/drm/bridge/sil902x.c: In function 'sil902x_bridge_mode_set':
>> drivers/gpu/drm/bridge/sil902x.c:300:13: warning: format '%zd' expects 
>> argument of type 'signed size_t', but argument 2 has type 'int' [-Wformat=]
  DRM_ERROR("failed to pack AVI infoframe: %zd\n", ret);
^
   include/drm/drmP.h:168:10: note: in definition of macro 'DRM_ERROR'
 drm_err(fmt, ##__VA_ARGS__)
 ^
   drivers/gpu/drm/bridge/sil902x.c: In function 'sil902x_probe':
   drivers/gpu/drm/bridge/sil902x.c:401:16: warning: format '%d' expects 
argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
  dev_err(dev, "Failed to retrieve/request reset gpio: %d\n",
   ^

vim +300 drivers/gpu/drm/bridge/sil902x.c

   284   SIL902X_TPI_AVI_PIXEL_REP_BUS_24BIT;
   285  buf[9] = SIL902X_TPI_AVI_INPUT_RANGE_AUTO |
   286   SIL902X_TPI_AVI_INPUT_COLORSPACE_RGB;
   287  
   288  ret = regmap_bulk_write(regmap, SIL902X_TPI_VIDEO_DATA, buf, 
10);
   289  if (ret)
   290  return;
   291  
   292  ret = drm_hdmi_avi_infoframe_from_display_mode(, adj);
   293  if (ret < 0) {
   294  DRM_ERROR("couldn't fill AVI infoframe\n");
   295  return;
   296  }
   297  
   298  ret = hdmi_avi_infoframe_pack(, buf, sizeof(buf));
   299  if (ret < 0) {
 > 300  DRM_ERROR("failed to pack AVI infoframe: %zd\n", ret);
   301  return;
   302  }
   303  
   304  /* Do not send the infoframe header, but keep the CRC field. */
   305  regmap_bulk_write(regmap, SIL902X_TPI_AVI_INFOFRAME,
   306buf + HDMI_INFOFRAME_HEADER_SIZE - 1,
   307HDMI_AVI_INFOFRAME_SIZE + 1);
   308  }

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation


.config.gz
Description: Binary data

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread Sascha Hauer

Hi Boris,

On Wed, Jan 06, 2016 at 12:25:50PM +0100, Boris Brezillon wrote:
> Add basic support for the sil902x RGB -> HDMI bridge.
> This driver does not support audio output yet.
> 
> Signed-off-by: Boris Brezillon 
> ---
> Hello,
> 
> This patch is only adding basic support for the sil9022 chip.

This thing is a SiI9022 for camel case "Silicon Image" with a capital 'I',
not a small 'l'.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread Boris Brezillon

Hi Sascha,

On Wed, 6 Jan 2016 14:47:36 +0100
Sascha Hauer  wrote:

> Hi Boris,
> 
> On Wed, Jan 06, 2016 at 12:25:50PM +0100, Boris Brezillon wrote:
> > Add basic support for the sil902x RGB -> HDMI bridge.
> > This driver does not support audio output yet.
> > 
> > Signed-off-by: Boris Brezillon 
> > ---
> > Hello,
> > 
> > This patch is only adding basic support for the sil9022 chip.
> 
> This thing is a SiI9022 for camel case "Silicon Image" with a capital 'I',
> not a small 'l'.

Oh, my bad, I'll fix that, but the vendor prefix defined in
Documentation/devicetree/bindings/vendor-prefixes.txt is not helping in
getting this right.

Should I also change the driver name?

Best Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread kbuild test robot

Hi Boris,

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.4-rc8 next-20160106]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improving the system]

url:
https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-bridge-sil902x/20160106-192921
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: i386-allmodconfig (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/gpu/drm/bridge/sil902x.c: In function 'sil902x_probe':
>> drivers/gpu/drm/bridge/sil902x.c:401:16: warning: format '%d' expects 
>> argument of type 'int', but argument 3 has type 'long int' [-Wformat=]
  dev_err(dev, "Failed to retrieve/request reset gpio: %d\n",
   ^
   In file included from drivers/gpu/drm/bridge/sil902x.c:26:0:
   drivers/gpu/drm/bridge/sil902x.c: At top level:
>> drivers/gpu/drm/bridge/sil902x.c:476:26: error: 'sil9022_id' undeclared here 
>> (not in a function)
MODULE_DEVICE_TABLE(i2c, sil9022_id);
 ^
   include/linux/module.h:223:21: note: in definition of macro 
'MODULE_DEVICE_TABLE'
extern const typeof(name) __mod_##type##__##name##_device_table  \
^
>> include/linux/module.h:223:27: error: '__mod_i2c__sil9022_id_device_table' 
>> aliased to undefined symbol 'sil9022_id'
extern const typeof(name) __mod_##type##__##name##_device_table  \
  ^
>> drivers/gpu/drm/bridge/sil902x.c:476:1: note: in expansion of macro 
>> 'MODULE_DEVICE_TABLE'
MODULE_DEVICE_TABLE(i2c, sil9022_id);
^

vim +/sil9022_id +476 drivers/gpu/drm/bridge/sil902x.c

   395  sil902x->regmap = devm_regmap_init_i2c(client, 
_regmap_config);
   396  if (IS_ERR(sil902x->regmap))
   397  return PTR_ERR(sil902x->regmap);
   398  
   399  sil902x->reset_gpio = devm_gpiod_get(dev, "reset", 
GPIOD_OUT_LOW);
   400  if (IS_ERR(sil902x->reset_gpio)) {
 > 401  dev_err(dev, "Failed to retrieve/request reset gpio: 
 > %d\n",
   402  PTR_ERR(sil902x->reset_gpio));
   403  return PTR_ERR(sil902x->reset_gpio);
   404  }
   405  
   406  sil902x_reset(sil902x);
   407  
   408  ret = regmap_write(sil902x->regmap, SIL902X_REG_TPI_RQB, 0x0);
   409  if (ret)
   410  return ret;
   411  
   412  ret = regmap_bulk_read(sil902x->regmap, SIL902X_REG_CHIPID(0),
   413 , 4);
   414  if (ret) {
   415  dev_err(dev, "regmap_read failed %d\n", ret);
   416  return ret;
   417  }
   418  
   419  if (chipid[0] != 0xb0) {
   420  dev_err(dev, "Invalid chipid: %02x (expecting 0xb0)\n",
   421  chipid[0]);
   422  return -EINVAL;
   423  }
   424  
   425  /* Clear all pending interrupts */
   426  regmap_read(sil902x->regmap, SI902X_INT_STATUS, );
   427  regmap_write(sil902x->regmap, SI902X_INT_STATUS, status);
   428  
   429  if (client->irq > 0) {
   430  regmap_write(sil902x->regmap, SI902X_INT_ENABLE,
   431   SI902X_HOTPLUG_EVENT);
   432  
   433  ret = devm_request_threaded_irq(dev, client->irq, NULL,
   434  sil902x_interrupt,
   435  IRQF_ONESHOT, 
dev_name(dev),
   436  sil902x);
   437  if (ret)
   438  return ret;
   439  }
   440  
   441  sil902x->bridge.funcs = _bridge_funcs;
   442  sil902x->bridge.of_node = dev->of_node;
   443  ret = drm_bridge_add(>bridge);
   444  if (ret) {
   445  dev_err(dev, "Failed to add drm_bridge\n");
   446  return ret;
   447  }
   448  
   449  i2c_set_clientdata(client, sil902x);
   450  
   451  return 0;
   452  }
   453  
   454  static int sil902x_remove(struct i2c_client *client)
   455  
   456  {
   457  struct sil902x *sil902x = i2c_get_clientdata(client);
   458  
   459  drm_bridge_remove(>bridge);
   460  
   461  return 0;
   462  }
   463  
   464  #ifdef CONFIG_OF
   465  static const struct of_device_id sil902x_dt_ids[] = {
   466  { .compatible = "sil,sil9022", },
   467  { }
   468  };
   469  MODULE_DEVICE_TABLE(of, sil902x_dt_ids);
   470  #endif
   471  
   472  static const struct i2c_device_id sil902x_i2c_ids[] = {
   473  { "sil9022", 0 },
   474  { },
   475  };
 > 476  MODULE_DEVICE_TABLE(i2c, sil9022_id);
   477  
   478  static struct i2c_driver sil902x_driver = {
   479

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread Sascha Hauer

On Wed, Jan 06, 2016 at 02:53:30PM +0100, Boris Brezillon wrote:
> Hi Sascha,
> 
> On Wed, 6 Jan 2016 14:47:36 +0100
> Sascha Hauer  wrote:
> 
> > Hi Boris,
> > 
> > On Wed, Jan 06, 2016 at 12:25:50PM +0100, Boris Brezillon wrote:
> > > Add basic support for the sil902x RGB -> HDMI bridge.
> > > This driver does not support audio output yet.
> > > 
> > > Signed-off-by: Boris Brezillon 
> > > ---
> > > Hello,
> > > 
> > > This patch is only adding basic support for the sil9022 chip.
> > 
> > This thing is a SiI9022 for camel case "Silicon Image" with a capital 'I',
> > not a small 'l'.
> 
> Oh, my bad, I'll fix that, but the vendor prefix defined in
> Documentation/devicetree/bindings/vendor-prefixes.txt is not helping in
> getting this right.

No, indeed not. Unfortunately sii is already taken by Seiko.

> 
> Should I also change the driver name?

I would suggest so, yes.

Sascha

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] drm: bridge: sil902x

2016-01-06 Thread Ilia Mirkin

On Wed, Jan 6, 2016 at 10:26 AM, Sascha Hauer  wrote:
> On Wed, Jan 06, 2016 at 02:53:30PM +0100, Boris Brezillon wrote:
>> Hi Sascha,
>>
>> On Wed, 6 Jan 2016 14:47:36 +0100
>> Sascha Hauer  wrote:
>>
>> > Hi Boris,
>> >
>> > On Wed, Jan 06, 2016 at 12:25:50PM +0100, Boris Brezillon wrote:
>> > > Add basic support for the sil902x RGB -> HDMI bridge.
>> > > This driver does not support audio output yet.
>> > >
>> > > Signed-off-by: Boris Brezillon 
>> > > ---
>> > > Hello,
>> > >
>> > > This patch is only adding basic support for the sil9022 chip.
>> >
>> > This thing is a SiI9022 for camel case "Silicon Image" with a capital 'I',
>> > not a small 'l'.
>>
>> Oh, my bad, I'll fix that, but the vendor prefix defined in
>> Documentation/devicetree/bindings/vendor-prefixes.txt is not helping in
>> getting this right.
>
> No, indeed not. Unfortunately sii is already taken by Seiko.
>
>>
>> Should I also change the driver name?
>
> I would suggest so, yes.

For opposing opinions:

drivers/gpu/drm/i2c/sil164_drv.c
drivers/media/platform/s5p-tv/sii9234_drv.c

One of each :)

  -ilia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

Re: [PATCH 1/2] drm: bridge: sil902x

12 matches

Site Navigation

Mail list logo

Footer information