Re: [PATCH 1/2] rtc: s5m: Move enum from rtc.h to rtc-s5m.c

2018-03-12 Thread Gustavo A. R. Silva 



On 03/11/2018 11:39 AM, Krzysztof Kozlowski wrote:

On Sat, Mar 10, 2018 at 7:27 AM, Gustavo A. R. Silva
 wrote:

Move this enum to rtc-s5m.c once it is meaningless to others drivers [1].

[1] https://marc.info/?l=linux-rtc=152060068925948=2


Instead of external link (which might or might not work soon) you can
just put "Suggested-by: Krzysztof Kozlowski ".



I got it.
I'll do that next time.


Anyway:
Reviewed-by: Krzysztof Kozlowski 



Thanks for reviewing it.
--
Gustavo

Re: [PATCH 1/2] rtc: s5m: Move enum from rtc.h to rtc-s5m.c

2018-03-12 Thread Gustavo A. R. Silva 



On 03/11/2018 11:39 AM, Krzysztof Kozlowski wrote:

On Sat, Mar 10, 2018 at 7:27 AM, Gustavo A. R. Silva
 wrote:

Move this enum to rtc-s5m.c once it is meaningless to others drivers [1].

[1] https://marc.info/?l=linux-rtc=152060068925948=2


Instead of external link (which might or might not work soon) you can
just put "Suggested-by: Krzysztof Kozlowski ".



I got it.
I'll do that next time.


Anyway:
Reviewed-by: Krzysztof Kozlowski 



Thanks for reviewing it.
--
Gustavo

Re: [PATCH 1/2] rtc: s5m: Move enum from rtc.h to rtc-s5m.c

2018-03-12 Thread Lee Jones 
On Sat, 10 Mar 2018, Gustavo A. R. Silva wrote:

> Move this enum to rtc-s5m.c once it is meaningless to others drivers [1].
> 
> [1] https://marc.info/?l=linux-rtc=152060068925948=2
> 
> Signed-off-by: Gustavo A. R. Silva 
> ---
>  drivers/rtc/rtc-s5m.c   | 11 +++
>  include/linux/mfd/samsung/rtc.h | 11 ---

I don't think this will conflict with anything (unless some major
works are carried out within the next few weeks - in which case I'll
need a pull-request, but for now ...)

Acked-by: Lee Jones 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/2] rtc: s5m: Move enum from rtc.h to rtc-s5m.c

2018-03-12 Thread Lee Jones 
On Sat, 10 Mar 2018, Gustavo A. R. Silva wrote:

> Move this enum to rtc-s5m.c once it is meaningless to others drivers [1].
> 
> [1] https://marc.info/?l=linux-rtc=152060068925948=2
> 
> Signed-off-by: Gustavo A. R. Silva 
> ---
>  drivers/rtc/rtc-s5m.c   | 11 +++
>  include/linux/mfd/samsung/rtc.h | 11 ---

I don't think this will conflict with anything (unless some major
works are carried out within the next few weeks - in which case I'll
need a pull-request, but for now ...)

Acked-by: Lee Jones 

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/2] rtc: s5m: Move enum from rtc.h to rtc-s5m.c

2018-03-11 Thread Krzysztof Kozlowski 
On Sat, Mar 10, 2018 at 7:27 AM, Gustavo A. R. Silva
 wrote:
> Move this enum to rtc-s5m.c once it is meaningless to others drivers [1].
>
> [1] https://marc.info/?l=linux-rtc=152060068925948=2

Instead of external link (which might or might not work soon) you can
just put "Suggested-by: Krzysztof Kozlowski ".

Anyway:
Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof

Re: [PATCH 1/2] rtc: s5m: Move enum from rtc.h to rtc-s5m.c

2018-03-11 Thread Krzysztof Kozlowski 
On Sat, Mar 10, 2018 at 7:27 AM, Gustavo A. R. Silva
 wrote:
> Move this enum to rtc-s5m.c once it is meaningless to others drivers [1].
>
> [1] https://marc.info/?l=linux-rtc=152060068925948=2

Instead of external link (which might or might not work soon) you can
just put "Suggested-by: Krzysztof Kozlowski ".

Anyway:
Reviewed-by: Krzysztof Kozlowski 

Best regards,
Krzysztof